diff --git a/www/web-proxy-sso/src/opnsense/mvc/app/controllers/OPNsense/SSOProxyAD/Api/ServiceController.php b/www/web-proxy-sso/src/opnsense/mvc/app/controllers/OPNsense/SSOProxyAD/Api/ServiceController.php index 36e34017a..59e4239c5 100644 --- a/www/web-proxy-sso/src/opnsense/mvc/app/controllers/OPNsense/SSOProxyAD/Api/ServiceController.php +++ b/www/web-proxy-sso/src/opnsense/mvc/app/controllers/OPNsense/SSOProxyAD/Api/ServiceController.php @@ -44,7 +44,12 @@ class ServiceController extends ApiControllerBase $mdlSSOProxyAD = new SSOProxyAD(); if ((string)$mdlSSOProxyAD->general->UpdateCron == "") { $mdlCron = new Cron(); - $mdlSSOProxyAD->general->UpdateCron = $mdlCron->newDailyJob("SSOProyAD", "ssoproxyad updateDomain", "SSOProxyAD updateDomain cron", "1"); + $mdlSSOProxyAD->general->UpdateCron = $mdlCron->newDailyJob( + "SSOProyAD", + "ssoproxyad updateDomain", + "SSOProxyAD updateDomain cron", + "1" + ); if ($mdlCron->performValidation()->count() == 0) { $mdlCron->serializeToConfig(); $mdlMymodule->serializeToConfig($validateFullModel = false, $disable_validation = true); diff --git a/www/web-proxy-sso/src/opnsense/mvc/app/library/OPNsense/Auth/SSOProxyAD.php b/www/web-proxy-sso/src/opnsense/mvc/app/library/OPNsense/Auth/SSOProxyAD.php index 3fdd4f38f..bdd737810 100644 --- a/www/web-proxy-sso/src/opnsense/mvc/app/library/OPNsense/Auth/SSOProxyAD.php +++ b/www/web-proxy-sso/src/opnsense/mvc/app/library/OPNsense/Auth/SSOProxyAD.php @@ -69,5 +69,6 @@ class SSOProxyAD implements IAuthConnector public function authenticate($username, $password) { + return false; } } diff --git a/www/web-proxy-sso/src/opnsense/scripts/OPNsense/SSOProxyAD/updateDomain.php b/www/web-proxy-sso/src/opnsense/scripts/OPNsense/SSOProxyAD/updateDomain.php index 68008d9b5..3c32cc12c 100755 --- a/www/web-proxy-sso/src/opnsense/scripts/OPNsense/SSOProxyAD/updateDomain.php +++ b/www/web-proxy-sso/src/opnsense/scripts/OPNsense/SSOProxyAD/updateDomain.php @@ -49,7 +49,13 @@ if (isset($configObj->OPNsense->ssoproxyad)) { if ($enabled == 1) { $keytab = '/usr/local/etc/ssoproxyad/PROXY.keytab'; if (file_exists($keytab)) { - $cmd = '/usr/local/sbin/msktutil --auto-update --computer-name ' . strtolower($hostname) . ' --keytab ' . $keytab . ' 2>&1'; + $cmd = exec_safe('/usr/local/sbin/msktutil %s %s %s %s %s 2>&1', array( + '--auto-update', + '--computer-name', + strtolower($hostname), + ' --keytab', + $keytab + )); exec($cmd, $output_msktutil, $error_msktutil); $out = implode($output_msktutil); if ($error_msktutil > 0) {