net/ndproxy: Disable promiscuous mode forced by port (#4676)

* net/ndproxy: Disable promiscuous mode forced by port

* net/ndproxy: Bump version, add release notes, put variable inside conditional.

* Update net/ndproxy/pkg-descr

Co-authored-by: Franco Fichtner <franco@opnsense.org>

---------

Co-authored-by: Franco Fichtner <franco@opnsense.org>

net/ndproxy/Makefile

@@ -1,5 +1,5 @@
 PLUGIN_NAME=		ndproxy
-PLUGIN_VERSION=		1.0
+PLUGIN_VERSION=		1.1
 PLUGIN_DEPENDS=		ndproxy
 PLUGIN_COMMENT=		Neighbor Discovery Proxy
 PLUGIN_MAINTAINER=	cedrik@pischem.com

net/ndproxy/pkg-descr

@@ -3,6 +3,10 @@ Ndproxy is a kernel module that implements IPv6 Neighbor Discovery proxying over
 Plugin Changelog
 ================
 
+1.1
+
+* Promiscuous mode for the Uplink Interface is no longer enabled
+
 1.0
 
 * Initial Release

net/ndproxy/src/opnsense/service/templates/OPNsense/Ndproxy/rc.conf.d/ndproxy

@@ -2,6 +2,8 @@
 {% set generalSettings = helpers.getNodeByTag('OPNsense.ndproxy.general') %}
 {% if generalSettings.enabled|default("0") == "1" %}
 ndproxy_enable="YES"
+{# Always disable promiscuous mode forced by port since it should be controlled via interface settings if needed. #}
+ndproxy_promisc_enable="NO"
 {%     if generalSettings.ndproxy_uplink_interface %}
 ndproxy_uplink_interface="{{ helpers.physical_interface(generalSettings.ndproxy_uplink_interface) }}"
 {%     endif %}