From d70df18c9dbc2321f3ed1c92a787c23096192b74 Mon Sep 17 00:00:00 2001 From: Monviech <79600909+Monviech@users.noreply.github.com> Date: Tue, 6 May 2025 15:33:47 +0200 Subject: [PATCH] net/ndproxy: Disable promiscuous mode forced by port (#4676) * net/ndproxy: Disable promiscuous mode forced by port * net/ndproxy: Bump version, add release notes, put variable inside conditional. * Update net/ndproxy/pkg-descr Co-authored-by: Franco Fichtner --------- Co-authored-by: Franco Fichtner --- net/ndproxy/Makefile | 2 +- net/ndproxy/pkg-descr | 4 ++++ .../service/templates/OPNsense/Ndproxy/rc.conf.d/ndproxy | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/net/ndproxy/Makefile b/net/ndproxy/Makefile index 17d690256..9c7a2855b 100644 --- a/net/ndproxy/Makefile +++ b/net/ndproxy/Makefile @@ -1,5 +1,5 @@ PLUGIN_NAME= ndproxy -PLUGIN_VERSION= 1.0 +PLUGIN_VERSION= 1.1 PLUGIN_DEPENDS= ndproxy PLUGIN_COMMENT= Neighbor Discovery Proxy PLUGIN_MAINTAINER= cedrik@pischem.com diff --git a/net/ndproxy/pkg-descr b/net/ndproxy/pkg-descr index ee59b68dd..a0c380fb0 100644 --- a/net/ndproxy/pkg-descr +++ b/net/ndproxy/pkg-descr @@ -3,6 +3,10 @@ Ndproxy is a kernel module that implements IPv6 Neighbor Discovery proxying over Plugin Changelog ================ +1.1 + +* Promiscuous mode for the Uplink Interface is no longer enabled + 1.0 * Initial Release diff --git a/net/ndproxy/src/opnsense/service/templates/OPNsense/Ndproxy/rc.conf.d/ndproxy b/net/ndproxy/src/opnsense/service/templates/OPNsense/Ndproxy/rc.conf.d/ndproxy index f907ee032..aa5066c63 100644 --- a/net/ndproxy/src/opnsense/service/templates/OPNsense/Ndproxy/rc.conf.d/ndproxy +++ b/net/ndproxy/src/opnsense/service/templates/OPNsense/Ndproxy/rc.conf.d/ndproxy @@ -2,6 +2,8 @@ {% set generalSettings = helpers.getNodeByTag('OPNsense.ndproxy.general') %} {% if generalSettings.enabled|default("0") == "1" %} ndproxy_enable="YES" +{# Always disable promiscuous mode forced by port since it should be controlled via interface settings if needed. #} +ndproxy_promisc_enable="NO" {% if generalSettings.ndproxy_uplink_interface %} ndproxy_uplink_interface="{{ helpers.physical_interface(generalSettings.ndproxy_uplink_interface) }}" {% endif %}