netbird/plugins
0
0
Fork 0
mirror of https://github.com/netbirdio/plugins.git synced 2026-05-22 18:44:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

www/caddy: Reduce scope of variables in javascript - replace var with let (#3956)

Browse Source 
* Update general.volt - Reduce scope of variables

The declared variables are only used in the block, so the scope can be reduced from "var" to "let".

* Update reverse_proxy.volt

Replace var with let
This commit is contained in:
Monviech
2024-05-06 16:12:43 +02:00
committed by GitHub
parent 71e78ac011
commit 045976e339
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/general.volt
+3 -3
View File
@@ -26,7 +26,7 @@
<script type="text/javascript">
$(document).ready(function() {
var data_get_map = {'frm_GeneralSettings':"/api/caddy/General/get"};
let data_get_map = {'frm_GeneralSettings':"/api/caddy/General/get"};
mapDataToFormUI(data_get_map).done(function(data){
// Refresh selectpicker for these dropdowns
@@ -34,8 +34,8 @@
// Function to show alerts in the HTML message area
function showAlert(message, type = "error") {
var alertClass = type === "error" ? "alert-danger" : "alert-success";
var messageArea = $("#messageArea");
let alertClass = type === "error" ? "alert-danger" : "alert-success";
let messageArea = $("#messageArea");
// Stop any current animation, clear the queue, and immediately hide the element
messageArea.stop(true, true).hide();
www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/reverse_proxy.volt
+6 -6
View File
@@ -29,7 +29,7 @@
// Function to handle the search filter request modification
function addDomainFilterToRequest(request) {
var selectedDomains = $('#reverseFilter').val();
let selectedDomains = $('#reverseFilter').val();
if (selectedDomains && selectedDomains.length > 0) {
request['reverseUuids'] = selectedDomains.join(',');
}
@@ -99,8 +99,8 @@
// Function to show alerts in the HTML message area
function showAlert(message, type = "error") {
var alertClass = type === "error" ? "alert-danger" : "alert-success";
var messageArea = $("#messageArea");
let alertClass = type === "error" ? "alert-danger" : "alert-success";
let messageArea = $("#messageArea");
// Stop any current animation, clear the queue, and immediately hide the element
messageArea.stop(true, true).hide();
@@ -171,7 +171,7 @@
type: 'GET',
dataType: 'json',
success: function(data) {
var select = $('#reverseFilter');
let select = $('#reverseFilter');
select.empty(); // Clear current options
if (data && data.rows) {
data.rows.forEach(function(item) {
@@ -204,12 +204,12 @@
}
// Initialize visibility based on the active tab on page load
var activeTab = $('#maintabs .active a').attr('href').replace('#', '');
let activeTab = $('#maintabs .active a').attr('href').replace('#', '');
toggleSelectPicker(activeTab);
// Change event when switching tabs
$('#maintabs a').on('click', function (e) {
var currentTab = $(this).attr('href').replace('#', '');
let currentTab = $(this).attr('href').replace('#', '');
toggleSelectPicker(currentTab);
});