From 045976e3396ae004c57dffa259148c7eec5758a4 Mon Sep 17 00:00:00 2001
From: Monviech <79600909+Monviech@users.noreply.github.com>
Date: Mon, 6 May 2024 16:12:43 +0200
Subject: [PATCH] www/caddy: Reduce scope of variables in javascript - replace
 var with let (#3956)

* Update general.volt - Reduce scope of variables

The declared variables are only used in the block, so the scope can be reduced from "var" to "let".

* Update reverse_proxy.volt

Replace var with let
---
 .../mvc/app/views/OPNsense/Caddy/general.volt        |  6 +++---
 .../mvc/app/views/OPNsense/Caddy/reverse_proxy.volt  | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/general.volt b/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/general.volt
index df6b749a4..7e704763d 100644
--- a/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/general.volt
+++ b/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/general.volt
@@ -26,7 +26,7 @@
 
 <script type="text/javascript">
     $(document).ready(function() {
-        var data_get_map = {'frm_GeneralSettings':"/api/caddy/General/get"};
+        let data_get_map = {'frm_GeneralSettings':"/api/caddy/General/get"};
         mapDataToFormUI(data_get_map).done(function(data){
 
             // Refresh selectpicker for these dropdowns
@@ -34,8 +34,8 @@
 
             // Function to show alerts in the HTML message area
             function showAlert(message, type = "error") {
-                var alertClass = type === "error" ? "alert-danger" : "alert-success";
-                var messageArea = $("#messageArea");
+                let alertClass = type === "error" ? "alert-danger" : "alert-success";
+                let messageArea = $("#messageArea");
 
                 // Stop any current animation, clear the queue, and immediately hide the element
                 messageArea.stop(true, true).hide();
diff --git a/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/reverse_proxy.volt b/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/reverse_proxy.volt
index a8d4cf525..7cfd98bc8 100644
--- a/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/reverse_proxy.volt
+++ b/www/caddy/src/opnsense/mvc/app/views/OPNsense/Caddy/reverse_proxy.volt
@@ -29,7 +29,7 @@
 
         // Function to handle the search filter request modification
         function addDomainFilterToRequest(request) {
-            var selectedDomains = $('#reverseFilter').val();
+            let selectedDomains = $('#reverseFilter').val();
             if (selectedDomains && selectedDomains.length > 0) {
                 request['reverseUuids'] = selectedDomains.join(',');
             }
@@ -99,8 +99,8 @@
 
         // Function to show alerts in the HTML message area
         function showAlert(message, type = "error") {
-            var alertClass = type === "error" ? "alert-danger" : "alert-success";
-            var messageArea = $("#messageArea");
+            let alertClass = type === "error" ? "alert-danger" : "alert-success";
+            let messageArea = $("#messageArea");
 
             // Stop any current animation, clear the queue, and immediately hide the element
             messageArea.stop(true, true).hide();
@@ -171,7 +171,7 @@
                 type: 'GET',
                 dataType: 'json',
                 success: function(data) {
-                    var select = $('#reverseFilter');
+                    let select = $('#reverseFilter');
                     select.empty(); // Clear current options
                     if (data && data.rows) {
                         data.rows.forEach(function(item) {
@@ -204,12 +204,12 @@
         }
 
         // Initialize visibility based on the active tab on page load
-        var activeTab = $('#maintabs .active a').attr('href').replace('#', '');
+        let activeTab = $('#maintabs .active a').attr('href').replace('#', '');
         toggleSelectPicker(activeTab);
 
         // Change event when switching tabs
         $('#maintabs a').on('click', function (e) {
-            var currentTab = $(this).attr('href').replace('#', '');
+            let currentTab = $(this).attr('href').replace('#', '');
             toggleSelectPicker(currentTab);
         });