Remove check for ICEControlling for TCP ICE

Closes #249
This commit is contained in:
Jerko Steiner
2020-07-18 23:30:04 -07:00
committed by Sean DuBois
parent d40d5bf5e7
commit 1f596427e8
2 changed files with 0 additions and 12 deletions
-1
View File
@@ -37,7 +37,6 @@ func TestTCP_Recv(t *testing.T) {
msg := stun.New()
msg.Type = stun.MessageType{Method: stun.MethodBinding, Class: stun.ClassRequest}
msg.Add(stun.AttrUsername, []byte("myufrag:otherufrag"))
msg.Add(stun.AttrICEControlling, nil)
msg.Encode()
n, err := writeStreamingPacket(conn, msg.Raw)
-11
View File
@@ -144,17 +144,6 @@ func (m *tcpMux) handleConn(conn net.Conn) {
m.params.Logger.Debugf("msg attr: %s\n", attr.String())
}
// Firefox will send ICEControlling for its Active canddiate. We
// currently support passive local TCP candidates only.
//
// TODO: not sure what will be sent for caniddate with tcptype S-O.
_, err = msg.Get(stun.AttrICEControlling)
if err != nil {
m.closeAndLogError(conn)
m.params.Logger.Warnf("No ICEControlling attribute in STUN message from %s to %s\n", conn.RemoteAddr(), conn.LocalAddr())
return
}
attr, err := msg.Get(stun.AttrUsername)
if err != nil {
m.closeAndLogError(conn)