From 1f596427e8326f5718cd6fd9ebe0db62c67a9cd1 Mon Sep 17 00:00:00 2001 From: Jerko Steiner Date: Sat, 18 Jul 2020 08:20:54 +0200 Subject: [PATCH] Remove check for ICEControlling for TCP ICE Closes #249 --- tcp_ip_mux_test.go | 1 - tcp_mux.go | 11 ----------- 2 files changed, 12 deletions(-) diff --git a/tcp_ip_mux_test.go b/tcp_ip_mux_test.go index 68bc927..1007aae 100644 --- a/tcp_ip_mux_test.go +++ b/tcp_ip_mux_test.go @@ -37,7 +37,6 @@ func TestTCP_Recv(t *testing.T) { msg := stun.New() msg.Type = stun.MessageType{Method: stun.MethodBinding, Class: stun.ClassRequest} msg.Add(stun.AttrUsername, []byte("myufrag:otherufrag")) - msg.Add(stun.AttrICEControlling, nil) msg.Encode() n, err := writeStreamingPacket(conn, msg.Raw) diff --git a/tcp_mux.go b/tcp_mux.go index a577a89..5892b0d 100644 --- a/tcp_mux.go +++ b/tcp_mux.go @@ -144,17 +144,6 @@ func (m *tcpMux) handleConn(conn net.Conn) { m.params.Logger.Debugf("msg attr: %s\n", attr.String()) } - // Firefox will send ICEControlling for its Active canddiate. We - // currently support passive local TCP candidates only. - // - // TODO: not sure what will be sent for caniddate with tcptype S-O. - _, err = msg.Get(stun.AttrICEControlling) - if err != nil { - m.closeAndLogError(conn) - m.params.Logger.Warnf("No ICEControlling attribute in STUN message from %s to %s\n", conn.RemoteAddr(), conn.LocalAddr()) - return - } - attr, err := msg.Get(stun.AttrUsername) if err != nil { m.closeAndLogError(conn)