netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

sentry: remove unnecessary NAT TODOs

Browse Source 
Like any other feature, we'll add this if it's requested/used. No reason to
keep TODOs around for every feature gap.

Fixes #5772.

PiperOrigin-RevId: 600906541
This commit is contained in:
Kevin Krakauer
2024-01-23 14:26:32 -08:00
committed by gVisor bot
parent 9db874189a
commit ff8ea9b2b9
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sentry/socket/netfilter/dnat.go
-2
View File
@@ -104,8 +104,6 @@ func (*dnatTargetMakerV4) unmarshal(buf []byte, filter stack.IPHeaderFilter) (ta
return nil, syserr.ErrInvalidArgument
}
// TODO(gvisor.dev/issue/5772): If the rule doesn't specify the source port,
// choose one automatically.
if nfRange.RangeIPV4.MinPort == 0 {
nflog("dnatTargetMakerV4: dnat target needs to specify a non-zero port")
return nil, syserr.ErrInvalidArgument
pkg/sentry/socket/netfilter/snat.go
-2
View File
@@ -104,8 +104,6 @@ func (*snatTargetMakerV4) unmarshal(buf []byte, filter stack.IPHeaderFilter) (ta
return nil, syserr.ErrInvalidArgument
}
// TODO(gvisor.dev/issue/5772): If the rule doesn't specify the source port,
// choose one automatically.
if nfRange.RangeIPV4.MinPort == 0 {
nflog("snatTargetMakerV4: snat target needs to specify a non-zero port")
return nil, syserr.ErrInvalidArgument