From ff8ea9b2b9776695809edac0a338e05f6aaaa058 Mon Sep 17 00:00:00 2001 From: Kevin Krakauer Date: Tue, 23 Jan 2024 14:23:09 -0800 Subject: [PATCH] sentry: remove unnecessary NAT TODOs Like any other feature, we'll add this if it's requested/used. No reason to keep TODOs around for every feature gap. Fixes #5772. PiperOrigin-RevId: 600906541 --- pkg/sentry/socket/netfilter/dnat.go | 2 -- pkg/sentry/socket/netfilter/snat.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/pkg/sentry/socket/netfilter/dnat.go b/pkg/sentry/socket/netfilter/dnat.go index ecbc9a6cf..75143f040 100644 --- a/pkg/sentry/socket/netfilter/dnat.go +++ b/pkg/sentry/socket/netfilter/dnat.go @@ -104,8 +104,6 @@ func (*dnatTargetMakerV4) unmarshal(buf []byte, filter stack.IPHeaderFilter) (ta return nil, syserr.ErrInvalidArgument } - // TODO(gvisor.dev/issue/5772): If the rule doesn't specify the source port, - // choose one automatically. if nfRange.RangeIPV4.MinPort == 0 { nflog("dnatTargetMakerV4: dnat target needs to specify a non-zero port") return nil, syserr.ErrInvalidArgument diff --git a/pkg/sentry/socket/netfilter/snat.go b/pkg/sentry/socket/netfilter/snat.go index d3e9a9c32..7f7a0e37e 100644 --- a/pkg/sentry/socket/netfilter/snat.go +++ b/pkg/sentry/socket/netfilter/snat.go @@ -104,8 +104,6 @@ func (*snatTargetMakerV4) unmarshal(buf []byte, filter stack.IPHeaderFilter) (ta return nil, syserr.ErrInvalidArgument } - // TODO(gvisor.dev/issue/5772): If the rule doesn't specify the source port, - // choose one automatically. if nfRange.RangeIPV4.MinPort == 0 { nflog("snatTargetMakerV4: snat target needs to specify a non-zero port") return nil, syserr.ErrInvalidArgument