netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

netstack: remove TODOs for not-planned work

Browse Source 
Decluttering the comments and bug tracker.

Fixes #4689.

PiperOrigin-RevId: 634040367
This commit is contained in:
Kevin Krakauer
2024-05-15 12:36:11 -07:00
committed by gVisor bot
parent 2c842da781
commit dd3124fa81
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/tcpip/stack/route.go
+6 -6
View File
@@ -183,9 +183,9 @@ func makeRoute(netProto tcpip.NetworkProtocolNumber, gateway, localAddr, remoteA
loop := PacketOut
// TODO(gvisor.dev/issue/4689): Loopback interface loops back packets at the
// link endpoint level. We can remove this check once loopback interfaces
// loop back packets at the network layer.
// Loopback interface loops back packets at the link endpoint level. We
// could remove this check if loopback interfaces looped back packets
// at the network layer.
if !outgoingNIC.IsLoopback() {
if handleLocal && localAddr != (tcpip.Address{}) && remoteAddr == localAddr {
loop = PacketLoop
@@ -264,9 +264,9 @@ func makeRouteInner(netProto tcpip.NetworkProtocolNumber, localAddr, remoteAddr
// A local route is a route to a destination that is local to the stack.
func makeLocalRoute(netProto tcpip.NetworkProtocolNumber, localAddr, remoteAddr tcpip.Address, outgoingNIC, localAddressNIC *nic, localAddressEndpoint AssignableAddressEndpoint) *Route {
loop := PacketLoop
// TODO(gvisor.dev/issue/4689): Loopback interface loops back packets at the
// link endpoint level. We can remove this check once loopback interfaces
// loop back packets at the network layer.
// Loopback interface loops back packets at the link endpoint level. We
// could remove this check if loopback interfaces looped back packets
// at the network layer.
if outgoingNIC.IsLoopback() {
loop = PacketOut
}