From dd3124fa81e86538fe158d6fbd5da3030e4bba4b Mon Sep 17 00:00:00 2001 From: Kevin Krakauer Date: Wed, 15 May 2024 12:31:56 -0700 Subject: [PATCH] netstack: remove TODOs for not-planned work Decluttering the comments and bug tracker. Fixes #4689. PiperOrigin-RevId: 634040367 --- pkg/tcpip/stack/route.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/tcpip/stack/route.go b/pkg/tcpip/stack/route.go index 4fae6c36e..d51a2ebac 100644 --- a/pkg/tcpip/stack/route.go +++ b/pkg/tcpip/stack/route.go @@ -183,9 +183,9 @@ func makeRoute(netProto tcpip.NetworkProtocolNumber, gateway, localAddr, remoteA loop := PacketOut - // TODO(gvisor.dev/issue/4689): Loopback interface loops back packets at the - // link endpoint level. We can remove this check once loopback interfaces - // loop back packets at the network layer. + // Loopback interface loops back packets at the link endpoint level. We + // could remove this check if loopback interfaces looped back packets + // at the network layer. if !outgoingNIC.IsLoopback() { if handleLocal && localAddr != (tcpip.Address{}) && remoteAddr == localAddr { loop = PacketLoop @@ -264,9 +264,9 @@ func makeRouteInner(netProto tcpip.NetworkProtocolNumber, localAddr, remoteAddr // A local route is a route to a destination that is local to the stack. func makeLocalRoute(netProto tcpip.NetworkProtocolNumber, localAddr, remoteAddr tcpip.Address, outgoingNIC, localAddressNIC *nic, localAddressEndpoint AssignableAddressEndpoint) *Route { loop := PacketLoop - // TODO(gvisor.dev/issue/4689): Loopback interface loops back packets at the - // link endpoint level. We can remove this check once loopback interfaces - // loop back packets at the network layer. + // Loopback interface loops back packets at the link endpoint level. We + // could remove this check if loopback interfaces looped back packets + // at the network layer. if outgoingNIC.IsLoopback() { loop = PacketOut }