100 Commits
Author SHA1 Message Date
isanae 234ee923fe model() can return null for invalid indexes
happens when looking at the mod info for a mod filtered out of the mod list
2021-03-20 14:51:44 -04:00
isanae 00120605fb don't disable dialogs that are children of other dialogs 2021-03-02 14:41:23 -05:00
isanae 4040dc12b7 Merge pull request #1436 from isanae/tutorial-fix
Fix tutorial stuck on mod info dialog
2021-02-24 05:46:48 -05:00
isanae d4fc7c3de1 emit modInfoDisplayed, it's required by the tutorial 2021-02-24 04:57:54 -05:00
isanae d22d77d921 handle network shares for NtOpenFile()
changed error messages to use formatNtMessage(), which handles NTSTATUS errors
2021-02-22 18:28:07 -05:00
isanae 3fad475013 Merge pull request #1416 from isanae/plugin-blacklist
Broken plugins blacklist
2021-02-21 11:50:32 -05:00
isanae 2bd755743c clarified comment 2021-02-20 12:49:08 -05:00
isanae 9eb1dd0ec0 clearPlugins() must be called to load the blacklist or it will be empty when loadPlugins() runs 2021-02-20 05:03:17 -05:00
isanae e473caf14a Merge pull request #1415 from isanae/master
2.4rc3
2021-02-19 18:23:01 -05:00
isanae 1c87f1d8d4 rc3 2021-02-19 18:21:53 -05:00
isanae 406d6f28c0 force instance selection when the current instance cannot be used
the problem is that an empty instance name means the portable instance, but MO clears the name when it needs instance selection, which can create a loop if the portable instance can't be used
2021-02-13 07:54:05 -05:00
isanae 48274f3357 - renamed instance::name() to displayName() to reduce confusion with portable instances
- better errors when running incorrect shortcuts
- fixed shortcuts being created with moshortcut://Portable:exe instead of an empty instance name for portable instances
2021-02-12 03:22:52 -05:00
isanae d179ad01c8 maxIds was local to the loop, not doubled
handle ERROR_MORE_DATA, it seems to sometimes happen, not sure why
added more logging, a user actually got that error
2021-02-10 10:01:39 -05:00
isanae 6feab2ea8f moved criticalOnTop() to uibase
changed all calls to reportError(), which now uses the main window if it exists as a parent, or calls criticalOnTop()
added errors when running something from the command line for a different instance/profile
removed unused crap
2021-01-18 08:21:42 -05:00
isanae 0d641f3977 make plugins wait until after the refresh is completed when they request a refresh
this is a change in behaviour, but it makes sure plugins don't have a stale view of the mods after running something
2021-01-18 08:21:41 -05:00
isanae 181acfe832 renamed Refresh to TriggerRefresh, added WaitForRefresh
removed duplicate refreshDirectoryStructure() call that could never work
added --logs to output logs to stdout, added final "mod organizer done" log
added -i with no arguments to output the current instance name
`run -e` now does an additional, case insensitive check for names
fixed error being output along with --help
2021-01-18 08:21:41 -05:00
isanae 1c4d09d9e1 comments 2021-01-18 08:20:08 -05:00
isanae 16ba428e44 fixed runPostMultiProcess() not being called
comments
2021-01-18 08:20:08 -05:00
isanae 06109a568b put more stuff in Meta to simplify 2021-01-18 08:20:08 -05:00
isanae 65a9e51e0e added refresh command
added more help for run
2021-01-18 08:20:08 -05:00
isanae 09eb507dda moved externalMessage() to MOApplication
commands can forward to the primary instance
added reload-plugin command
MessageDialog now tries to find the main window when the reference is null, which actually used to happen often because activeWindow() is typically used, but that's null when the main window doesn't have focus (like when downloading from nexus, for example)
2021-01-18 08:20:08 -05:00
isanae 7e80184812 merged exe and run commands, added -e flag instead
added dialog when selected profile doesn't exist, this can happen with -p on the command line
2021-01-18 08:20:08 -05:00
isanae aa7a552654 implemented exe command
better error when cwd doesn't exist
2021-01-18 08:20:07 -05:00
isanae e4ae41e3a2 fixed all commands being legacy
split running command into pre and post organizer
2021-01-18 08:20:07 -05:00
isanae 3bca0e7615 split run() into setup() and run()
this is so command line processing can happen outside of MOApplication
many important objects were local to run(), so they're not members of MOApplication instead
2021-01-18 08:20:07 -05:00
isanae 8ee1f94b0f Merge pull request #1365 from isanae/master
Fix crash on bad bsa
2021-01-16 16:56:35 -05:00
isanae 9092c096d5 fix crash on bad bsa 2021-01-16 16:53:50 -05:00
isanae a680dfa3e9 Merge pull request #1353 from isanae/master
Task dialog for deleting downloads
2021-01-11 02:09:09 -05:00
isanae 2f16f07f6e task dialog for deleting downloads
also shows filename
2021-01-10 20:41:59 -05:00
isanae eaec140f7c Merge pull request #1349 from isanae/master
Handle category cycles by putting parent ids in a set
2021-01-09 15:12:56 -05:00
isanae 6781451ab2 handle cycles by putting parent ids in a set 2021-01-09 15:07:20 -05:00
isanae 135d23c20a Merge pull request #1347 from isanae/master
Fix game selection not appearing on startup
2021-01-09 14:01:25 -05:00
isanae ea76c33710 fix skipping pages in single page mode
in single page mode, ready() can return false for some pages like the instance type if the selected page is past it, so skip() has to be checked too
2021-01-09 13:56:21 -05:00
isanae e3e54bc8d3 Merge pull request #1342 from isanae/shortcut-nolock
Fix running shortcuts with locking disabled
2021-01-05 07:06:50 -05:00
isanae 24a6749157 fix running shortcuts with locking disabled
when a ProcessRunner gets ForceWait|PreventExit and locking is disabled, wait for the process normally but without showing the ui
changed references to UILocker::Session to pointers because they can now be null
2021-01-04 20:49:05 -05:00
isanae 09f07ddae9 Merge pull request #1341 from isanae/profile-crash
Fixes for the profiles dialog
2021-01-04 20:46:43 -05:00
isanae 7c0479b098 fixes for the profiles dialog:
- don't refresh before showing the dialog, this happened because setCurrentIndex() was called to reselect the old item after <manage> was selected
 - can't use previousIndex after the dialog has been shown, the ordering might have changed if profiles were created/removed
 - don't call activateSelectedProfile() manually when 'select' is clicked from the dialog, just call setCurrentText() and let it fire the event again, then return immediately so it's not done twice
2021-01-04 09:40:52 -05:00
isanae 1b101bda36 Merge pull request #1333 from isanae/more-stuff-2
More stuff 2
2020-12-29 07:29:53 -05:00
isanae 33a177f1ed profiles dialog:
- added select button
  - select new profile in the list after creating
2020-12-29 02:42:07 -05:00
isanae cc997c3704 editable combobox for output mod name 2020-12-29 02:10:33 -05:00
isanae 91e1cc9cca update mod counts for creating/restoring backups 2020-12-28 06:59:39 -05:00
isanae f01fe9ce7c refresh action, added in toolbar and menu 2020-12-28 06:37:50 -05:00
isanae e43f6e6f37 disallow renaming the active profile 2020-12-28 06:24:26 -05:00
isanae 4b059fa71f Merge pull request #1332 from isanae/more-stuff
More stuff
2020-12-28 06:23:44 -05:00
isanae 9b3e91b53e renamed DownloadList::lessThan to lessThanPredicate and added a comment that it's used with the filter widget 2020-12-28 06:01:43 -05:00
isanae c2c0f7c98d added open in explorer in save game context menu 2020-12-28 05:44:51 -05:00
isanae f46a14f3bf delete shortcut for save games 2020-12-28 05:37:14 -05:00
isanae a8f6f0d7a0 split saves tab, no changes 2020-12-28 05:28:37 -05:00
isanae 462ea08c34 fixed warning about ini files with utf8 bom
fixed main thread name still getting clobbered by QWebEngine
2020-12-28 04:17:16 -05:00
isanae 3c62a048da fixed crash for ignore data/mark converted on multiple mods
also fixes only half the selected items being handled at a time
the selection must be copied first because it's live and will get invalidated when filters are being used
there was some weird connect() calls for every item, not sure why
2020-12-28 03:37:20 -05:00
isanae 1be2006359 offline mode:
- don't try to login on startup
- don't try to update loot when sorting and display a warning that the master list might be stale
2020-12-28 03:12:15 -05:00
isanae 51db1f99f0 custom browser command
changed some places that used QDesktopServices to use shell::Open() from uibase instead
2020-12-28 01:25:33 -05:00
isanae 106ed49bae removed setUpdateDelay(false) calls, it's the default
FilterWidget for downloads tab
2020-12-26 20:58:06 -05:00
isanae 3eb64c32e8 split downloads tab 2020-12-26 19:51:47 -05:00
isanae 2b2bb69351 don't update mods after installing in offline mode 2020-12-26 19:14:34 -05:00
isanae 2e86e36a8e allow selecting another instance when the game/variant isn't found 2020-12-26 19:09:59 -05:00
isanae 89bbdf22cd Merge pull request #1328 from isanae/stuff
Stuff
2020-12-24 23:06:53 -05:00
isanae 9441d49c6d added citrix to checks 2020-12-24 12:37:19 -05:00
isanae 1b700785bb don't log modules in winroot
dashes to dots
2020-12-24 11:22:24 -05:00
isanae da0771853a added BlueAmulet to contributors (conflict icons)
sorted names
2020-12-24 10:59:46 -05:00
isanae 5183b2f47a optimizations for download manager:
- use envfs for walking directory
 - minimize string copies, disk access
 - use set of filenames to check for duplicates
 - use file size from envfs
2020-12-24 10:55:55 -05:00
isanae c8cff6166d added version to dmp filename
replaced QApplication calls so createVersionInfo() can be called without one, happens with dump_running_process.bat
2020-12-24 10:02:56 -05:00
isanae 28d24b3caa don't count overwrite, m_Overwrite is dead code 2020-12-24 09:50:43 -05:00
isanae 444f12c7c4 replaced "validator" logs with "nexus", clearer for users 2020-12-24 09:45:26 -05:00
isanae b20b458299 also log primary handler 2020-12-24 09:42:23 -05:00
isanae b2af1e340f dump nxmhandler.ini 2020-12-24 09:36:04 -05:00
isanae c676247f99 ignore steam username when dumping settings 2020-12-24 09:13:11 -05:00
isanae 4bff983527 regex for osds
added gigabyte 3d osd, more nahimic
2020-12-24 09:12:16 -05:00
isanae 06ca11edfb Merge pull request #1327 from isanae/instance-icons
Fixed incorrect instance icons
2020-12-22 15:00:49 -05:00
isanae d08ed01438 fixed instanceIcon() so it works when game plugins fail auto detection but the instance has a custom path
had to change PluginContainer to non const in a few places
2020-12-22 14:40:51 -05:00
isanae b7486d9157 typo 2020-12-21 09:49:00 -05:00
isanae 5560931ad9 Merge pull request #1324 from isanae/master
Added 6788 and trosski to the about diaog
2020-12-20 23:13:40 -05:00
isanae f1ea330df0 added 6788 and trosski to the about diaog 2020-12-20 23:13:07 -05:00
isanae 97dab75c75 Merge pull request #1323 from isanae/master
Added timing for vfs mapping
2020-12-20 23:08:53 -05:00
isanae 598a99e420 added timing for vfs mapping 2020-12-20 23:08:14 -05:00
isanae 0a6a5eb786 Merge pull request #1316 from isanae/master
Spaces in paths
2020-12-04 04:24:37 -05:00
isanae 50dde6c94e quotes for spaces in paths 2020-12-04 04:23:55 -05:00
isanae b2ec5fa70a Merge pull request #1315 from isanae/download-crash
Handle null plugin when adding a download
2020-12-03 20:04:21 -05:00
isanae 43f20f511c handle null plugin when adding a download
happens when some plugins refer to other plugins that are missing
2020-12-03 20:03:35 -05:00
isanae dffec4fd9d Merge pull request #1305 from ModOrganizer2/revert-1277-master
Revert "Changing the location of several directories"
2020-11-27 07:47:19 -05:00
isanae 5dd9bbe33a Revert "Changing the location of several directories" 2020-11-27 07:34:00 -05:00
isanae 5f7e2988cd Merge pull request #1297 from isanae/master
Fix crash when clicking ... in path page
2020-11-15 04:07:40 -05:00
isanae 18106aa945 fixed crash when clicking ...
lambda was taking a local variable by reference
2020-11-15 04:06:56 -05:00
isanae 4833e494d5 Merge pull request #1277 from Qudix/master
Changing the location of several directories
2020-11-14 06:54:51 -05:00
isanae 579f94b5b6 Merge pull request #1296 from isanae/master
Adding Qudix to contributors
2020-11-13 23:54:47 -05:00
isanae 6a6cf8b0e7 added Qudix to contributors 2020-11-13 23:54:08 -05:00
isanae 85f515da2d Merge pull request #1294 from isanae/master
Bunch of instance and command line stuff
2020-11-12 03:16:44 -05:00
isanae 6ae27224b0 fixed a bunch of instance and command line stuff
- clear instance manager overrides when restarting, or switching instances after starting MO with moshortcut://instance: won't do anything
- clear overrides when the last selected instance can't be opened; MO would keep trying to open shortcuts even after selecting a different instance
- command line was cleared too early, before the first run, so shortcuts were broken
- the instance manager dialog can be opened without an instance loaded if the last selected instance doesn't exist, createNew() would throw because it tried to access the global Settings
- fixed some problems with parts of MO wanting to restart and others expecting flow to continue
- fixed create instance dialog using settings pointer to decide whether to restart; it restarts when it's the first created instance, which is not always the case even if the settings are null, so just check whether there are instances
2020-11-12 03:15:14 -05:00
isanae f7de861812 Merge pull request #1293 from isanae/master
Crash when highlighting plugins from the Data directory
2020-11-12 00:18:41 -05:00
isanae a0c2651702 highlighting plugins from the data directory would crash
the mod name is "data" and getByName() crashes with a mod name that doesn't exist
2020-11-12 00:17:36 -05:00
isanae e1dceec67a Merge pull request #1290 from isanae/master
Local saves don't work
2020-11-10 21:01:57 -05:00
isanae ca54d5c55b Merge branch 'master' of https://github.com/ModOrganizer2/modorganizer 2020-11-10 21:00:54 -05:00
isanae be2456e815 detectGame() must be called before init() 2020-11-10 20:59:47 -05:00
isanae 9c21d1e4f6 Merge pull request #1289 from isanae/master
Don't delete user directories by default
2020-11-10 12:53:02 -05:00
isanae 849a8bd6b9 uncheck directories changed by the user by default to match the old behaviour of deleting an instance 2020-11-10 12:45:16 -05:00
isanae 49f208c5a2 Merge pull request #1287 from isanae/master
Stuff doesn't run
2020-11-10 11:52:34 -05:00
isanae 5fa4df5525 whitespace 2020-11-10 10:20:10 -05:00
isanae 92773706b9 don't attempt to parse the command line for launch, it fails in all sorts of ways
don't try to time stuff before logging is initialized, an exception before initLogging() will crash because ~TimeThis() tries to log
2020-11-09 17:17:04 -05:00
isanae fef8543a58 Merge pull request #1286 from isanae/master
Nexus state not updated in settings
2020-11-09 08:55:50 -05:00
isanae 713e053d2c fixed nexus state not being updated 2020-11-09 08:55:09 -05:00