Since I restricted the default GitHub Actions token to read-only permissions, this permission needs to be explicitly granted to allow the creation of a release and the upload of release assets.
So that new warnings don't cause issues for library consumers.
Instead use CMake's CMAKE_COMPILE_WARNING_AS_ERROR option to treat them as errors in CI.
libloot hasn't been built or tested on Windows 7 as part of CI since 2018, and probably hasn't worked on Windows 7, 8 or 8.1 since at least May 2024, and developing for Windows 7 hasn't been practical for some time, so this isn't increasing the requirement so much as reflecting that it increased at some point in the past.
Their Windows builds take a combined ~ 19 minutes compared to the Linux builds taking ~ 3 minutes. Since the wrappers are experimental the Windows builds aren't adding much value.
It doesn't make much of a difference to performance in CI, as the docs
dependencies install time is dominated by getting Doxygen, but uv's use
of a lockfile does make builds more reliable.
Splitting up the build job means that each of the build targets (tests
with coverage, C++ wrapper, Python wrapper, Node.js wrapper) don't need
to wait for the things they don't use, but it does:
- increase duplication within the job, as GitHub Actions doesn't support
using YAML anchors
- increase the total build cache usage: together the jobs use 2450 MB vs
1740 MB
Oliver Hamlet
Oliver HamletandGitHub
dependabot[bot]andGitHub