Since I restricted the default GitHub Actions token to read-only permissions, this permission needs to be explicitly granted to allow the creation of a release and the upload of release assets.
Instead set their target-specific equivalents.
The POSITION_INDEPENDENT_CODE property isn't set because it already defaults to ON for shared libraries.
So that new warnings don't cause issues for library consumers.
Instead use CMake's CMAKE_COMPILE_WARNING_AS_ERROR option to treat them as errors in CI.
This reverts commit da0e35bb2b.
The minimum version of libloadorder has been increased because 18.5.0
included some changes to support symlinked plugins, without which
symlink support is incomplete.
The tests all pass when using the bottom of the new version ranges on Windows.
The unicase dependency's lower bound is limited by rust-ini even after using the latest master branch versions of esplugin, libloadorder and loot-condition-interpreter.
The proc-macro2 and quote dependencies' lower bounds are limited by pyo3's dependency tree.
The nodejs wrapper's dependencies haven't been touched.
I only test libloot for x86 Windows, x86-64 Windows and x86-64 Linux in CI.
Ideally there would be a way to tell cargo-vet to ignore dependencies
that aren't relevant to a given set of targets, as having them exempt
like this could hide the need to audit them if they do become relevant
to those targets in the future, but without the supression `cargo vet
suggest`'s output is just too noisy.
Oliver Hamlet
Oliver HamletandGitHub
dependabot[bot]andGitHub