Don't treat compiler warnings as errors by default

So that new warnings don't cause issues for library consumers.

Instead use CMake's CMAKE_COMPILE_WARNING_AS_ERROR option to treat them as errors in CI.

.github/workflows/ci.yml

@@ -193,6 +193,7 @@ jobs:
         run: |
           cmake \
             -DCMAKE_BUILD_TYPE=${{ env.CMAKE_CONFIG }} \
+            -DCMAKE_COMPILE_WARNING_AS_ERROR=ON \
             -DCPACK_PACKAGE_VERSION="${{ steps.get-libloot-version.outputs.version }}" \
             -DCPACK_THREADS=0 \
             -DRUST_TARGET="${{ matrix.target.triple }}" \
@@ -205,6 +206,7 @@ jobs:
         run: |
           cmake -G "Visual Studio 17 2022" `
             -A ${{ matrix.target.platform }} `
+            -DCMAKE_COMPILE_WARNING_AS_ERROR=ON `
             -DCPACK_PACKAGE_VERSION="${{ steps.get-libloot-version.outputs.version }}" `
             -DCPACK_THREADS=0 `
             -DRUST_TARGET="${{ matrix.target.triple }}" `

cpp/CMakeLists.txt

@@ -181,7 +181,6 @@ endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
     target_compile_options(loot PRIVATE
-        "-Werror"
         "-Wall"
         "-Wextra"
         "-Wpedantic"
@@ -211,7 +210,6 @@ if(MSVC)
         "/permissive-"
         "/W4"
         "/Wall"
-        "/WX"
         "/wd4514"
         "/wd4623"
         "/wd4625"