linuxmsm/laptops-kernel
0
0
Fork 0
mirror of https://github.com/linux-msm/laptops-kernel.git synced 2026-08-13 14:19:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

staging: gpib: Using struct gpib_pad_ioctl

Browse Source 
Using Linux code style for 'struct gpib_pad_ioctl' to remove typedef.

Adhering to Linux code style.

Reported by checkpatch.pl

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-14-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Michael Rubin
2025-04-15 16:46:09 +02:00
committed by Greg Kroah-Hartman
parent 419a3433f0
commit faebdfab31
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/staging/gpib/common/gpib_os.c
+1 -1
View File
@@ -1438,7 +1438,7 @@ static int line_status_ioctl(struct gpib_board *board, unsigned long arg)
static int pad_ioctl(struct gpib_board *board, struct gpib_file_private *file_priv,
unsigned long arg)
{
pad_ioctl_t cmd;
struct gpib_pad_ioctl cmd;
int retval;
struct gpib_descriptor *desc;
drivers/staging/gpib/uapi/gpib_ioctl.h
+3 -3
View File
@@ -92,10 +92,10 @@ struct gpib_ppoll_config_ioctl {
unsigned clear_ist : 1;
};
typedef struct {
struct gpib_pad_ioctl {
unsigned int handle;
unsigned int pad;
} pad_ioctl_t;
};
typedef struct {
unsigned int handle;
@@ -134,7 +134,7 @@ enum gpib_ioctl {
IBGTS = _IO(GPIB_CODE, 11),
IBCAC = _IOW(GPIB_CODE, 12, int),
IBLINES = _IOR(GPIB_CODE, 14, short),
IBPAD = _IOW(GPIB_CODE, 15, pad_ioctl_t),
IBPAD = _IOW(GPIB_CODE, 15, struct gpib_pad_ioctl),
IBSAD = _IOW(GPIB_CODE, 16, sad_ioctl_t),
IBTMO = _IOW(GPIB_CODE, 17, unsigned int),
IBRSP = _IOWR(GPIB_CODE, 18, struct gpib_serial_poll_ioctl),