linuxmsm/laptops-kernel
0
0
Fork 0
mirror of https://github.com/linux-msm/laptops-kernel.git synced 2026-08-13 14:19:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

staging: gpib: Using struct gpib_ppoll_config_ioctl`

Browse Source 
Using Linux code style for 'struct gpib_ppoll_config_ioctl' to remove typedef.

Adhering to Linux code style.

Reported by checkpatch.pl

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-13-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Michael Rubin
2025-04-15 16:46:09 +02:00
committed by Greg Kroah-Hartman
parent 4c2170378c
commit 419a3433f0
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/staging/gpib/common/gpib_os.c
+1 -1
View File
@@ -1692,7 +1692,7 @@ static int timeout_ioctl(struct gpib_board *board, unsigned long arg)
static int ppc_ioctl(struct gpib_board *board, unsigned long arg)
{
ppoll_config_ioctl_t cmd;
struct gpib_ppoll_config_ioctl cmd;
int retval;
retval = copy_from_user(&cmd, (void __user *)arg, sizeof(cmd));
drivers/staging/gpib/uapi/gpib_ioctl.h
+3 -3
View File
@@ -86,11 +86,11 @@ struct gpib_select_pci_ioctl {
int pci_slot;
};
typedef struct {
struct gpib_ppoll_config_ioctl {
uint8_t config;
unsigned set_ist : 1;
unsigned clear_ist : 1;
} ppoll_config_ioctl_t;
};
typedef struct {
unsigned int handle;
@@ -147,7 +147,7 @@ enum gpib_ioctl {
IBMUTEX = _IOW(GPIB_CODE, 26, int),
IBSPOLL_BYTES = _IOWR(GPIB_CODE, 27, struct gpib_spoll_bytes_ioctl),
IBPPC = _IOW(GPIB_CODE, 28, ppoll_config_ioctl_t),
IBPPC = _IOW(GPIB_CODE, 28, struct gpib_ppoll_config_ioctl),
IBBOARD_INFO = _IOR(GPIB_CODE, 29, struct gpib_board_info_ioctl),
IBQUERY_BOARD_RSV = _IOR(GPIB_CODE, 31, int),