paul chipchase ee70eb2ee5 Add checks before allocating buffers during bulkdata serialization. ...

#rb Per.Larsson
#rnx

- If archive is corrupt we could serialize an unreasonable value for the payload size from disk. This could cause very large allocations to be made which could cause the process to OOM or to allocate resources that it doesn't need.
- To avoid this we can check the archive we are serializing from and make sure that, at the very least, it will be possible to load all of the payload bytes from it. This way we will never make an allocation larger than the remaining space in the archive. It would then be up to the higher level code to validate that overall size of the provided file makes sense.
- Note that we are not able to do this is we are loading a payload from legacy bulkdata format that was marked as compressed as we only know the uncompressed payload size, not the compressed size on disk.

[CL 32755840 by paul chipchase in ue5-main branch]

2024-04-05 06:33:52 -04:00

..

AdpcmAudioDecoder/Module

Fix for Client Crash - ADPCM::DecodeBlock() - Code by Aaron.

2024-03-12 19:34:04 -04:00

AdvancedWidgets

[AdvancedWidgets] URadialSlider: changed category name from "Behaviour" to "Behavior" to comply with coding standards (When using Naming Conventions, all code and comments should use U.S. English spelling and grammar.)

2024-04-03 06:06:54 -04:00

Advertising

…

AIModule

Added a new flag "bStartFromPreviousPath" in FAIMoveRequest and BTTask_MoveTo. This allows the AI to request a new path that will continue from the end of the previous one. This is useful for AIs that need to request the next part of their path before reaching the last point.

2024-04-03 18:58:55 -04:00

Analytics

Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).

2024-02-19 16:51:58 -05:00

Android

Allow to set a custom debug keystore instead of always using default one

2024-02-27 03:54:20 -05:00

AnimationCore

…

AnimGraphRuntime

Moving USkeletalBodySetup out of "PhysicsEngine/PhysicsAsset.h" and into its own header "PhysicsEngine/SkeletalBodySetup.h"

2024-03-22 17:23:45 -04:00

AppFramework

…

Apple

Metal RHI

2024-04-03 12:10:36 -04:00

ApplicationCore

ios.UnifyMotionSpace added to let iOS motion input match other platforms

2024-04-03 23:25:08 -04:00

AssetRegistry

Temporarily disable multithreaded data processing for Asset Registry.

2024-04-04 16:43:30 -04:00

AudioAnalyzer

…

AudioCaptureCore

…

AudioCaptureImplementations

…

AudioExtensions

Move Resonance submix load to its own function called during engine init

2024-02-29 19:58:21 -05:00

AudioLink

…

AudioMixer

Add ability to remove envelope follower delegates from submixes

2024-03-28 15:54:33 -04:00

AudioMixerCore

…

AudioPlatformConfiguration

…

AugmentedReality

Removed some headers dependencies on 'FHitResult' and 'FOverlapResult'

2024-02-14 09:15:30 -05:00

AutomationMessages

…

AutomationTest

…

AutomationWorker

Validate active screenshot id before accepting screenshot comparison completion

2024-03-08 11:48:08 -05:00

AVEncoder

Fixing single header compiles.

2024-03-20 11:49:44 -04:00

AVIWriter

…

BinkAudioDecoder

Add error logs to BinkAudioInfo for failure cases when parsing the header.

2024-04-04 17:34:52 -04:00

BlueprintRuntime

…

BuildSettings

…

Cbor

Fix narrowing of store directory string

2024-03-28 07:44:55 -04:00

CEF3Utils

…

CinematicCamera

…

ClientPilot

…

ClothingSystemRuntimeCommon

SkeletalMesh.h is needed for all builds, not just Editor builds.

2024-03-22 17:39:58 -04:00

ClothingSystemRuntimeInterface

…

ClothingSystemRuntimeNv

Added UE_DEPRECATED_HEADER which acts like UE_DEPRECATED and should be placed in headers that should no longer be included.

2024-03-18 07:05:59 -04:00

ColorManagement

ColorManagement: Remaining deprecation of headers & color management module, since they were moved to Core at CL 32299544.

2024-03-25 11:04:55 -04:00

CookOnTheFly

Zen transport plugin for staged builds serving using the platform protocol interface and FStorageServerConnection adaptation for platform backends

2024-04-03 07:34:34 -04:00

Core

Vectorized TMatrix<float>::To3x4MatrixTranspose, FRenderTransform::To3x4MatrixTranspose, and FRenderTransform::ToMatrix44f

2024-04-04 23:11:03 -04:00

CoreOnline

…

CorePreciseFP

- Make FDoubleProperty and FFloatProperty use Verse's extensional float equality semantics, and support value hashing. This should only affect comparison of NaNs: thanks to -ffast-math/fp:fast compiler flags, the previous behavior of FDoubleProperty::Identical/FDoubleProperty::Identical was for them to treat NaNs as equal to all other values. The new behavior is to treat all NaNs as equal to each other, and unequal to numbers.

2024-04-03 10:01:56 -04:00

CoreUObject

Add checks before allocating buffers during bulkdata serialization.

2024-04-05 06:33:52 -04:00

CrashReportCore

- Straightforward IOS compile fixes

2024-03-15 19:19:14 -04:00

CUDA/Source

…

D3D12RHI

Implement support for reserved textures with mip maps in D3D12 RHI. Allow reserved render targets and depth buffers.

2024-04-04 16:10:53 -04:00

Datasmith

Performance improvements: Part #1

2024-03-28 14:27:53 -04:00

DeveloperSettings

…

Engine

Iris

2024-04-05 06:13:16 -04:00

EngineMessages

…

EngineSettings

[Console]

2024-02-23 07:00:11 -05:00

Experimental

GeometryCollection : AppendSkeletalMesh updates

2024-04-04 23:52:30 -04:00

ExternalRPCRegistry

Add Swagger.json endpoint to ExternalRpcRegistry

2024-03-15 13:49:25 -04:00

EyeTracker

…

FieldNotification

…

Foliage

Fix UGrassInstancedStaticMeshComponent to return correct value for GetNumRenderInstances().

2024-03-21 14:52:17 -04:00

FriendsAndChat

…

GameMenuBuilder

…

GameplayDebugger

If the Gameplay Debugger is active while quitting, then restore the temporarily disabled GAreScreenMessagesEnabled flag (which allows messages to log to the screen).

2024-02-22 13:27:31 -05:00

GameplayMediaEncoder

Remove FRHICommandListExecutor::GetImmediateCommandList() in Media modules

2024-03-15 08:24:24 -04:00

GameplayTags

Optimize FGameplayTagContainer::AppendTags to be much faster when appending large containers to small containers.

2024-04-03 16:30:08 -04:00

GameplayTasks

Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).

2024-02-19 16:51:58 -05:00

GeometryCore

Fix clang 18 errors

2024-04-04 19:05:47 -04:00

GeometryFramework

add a limit to the number of simultaneous dynamic mesh component distance field builds that can be active

2024-03-28 11:32:35 -04:00

HardwareSurvey

…

HeadMountedDisplay

Deprecate:

2024-02-22 11:38:35 -05:00

IESFile

…

ImageCore

Texture UEDelta filter to replace PNG filter

2024-04-01 18:31:48 -04:00

ImageWrapper

Texture UEDelta filter to replace PNG filter

2024-04-01 18:31:48 -04:00

ImageWriteQueue

Deprecate:

2024-02-22 11:38:35 -05:00

InputCore

Deprecated fields on FPropertyTag that are now represented by its TypeName

2024-03-01 17:32:43 -05:00

InputDevice

…

InstallBundleManager

Deprecate EInstallBundleSourceType and replace with FInstallBundleSourceType

2024-03-20 21:48:59 -04:00

InteractiveToolsFramework

Backing out changelist 32526171 which was submitted accidentally.

2024-03-26 18:30:44 -04:00

Interchange

Interchange: fix threadsafe translator logic in interchange manager

2024-04-04 18:29:50 -04:00

IOS

Add missing #undef

2024-03-08 19:56:16 -05:00

IPC

…

Json

Compilation Fix

2024-04-04 13:22:59 -04:00

JsonUtilities

[Backout] - CL32587777 - CIS Compile Error

2024-03-28 15:53:24 -04:00

Landscape

Landscape: Fix mobile texture arrays

2024-03-27 11:24:04 -04:00

Launch

UE-208424 VisionOS: View lagging behind head motion

2024-03-26 18:25:31 -04:00

LevelSequence

Making the asset gatherer tick run on a background thread. In order to do this, it was also necessary to refactor PostLoadAssetRegistryTags, deprecating the existing function and implementing a new ThreadedPostLoadAssetRegistryTagsOverride. The multithreading functionality is disabled in this checkin. -dpcvars=AssetRegistry.TickGatherOnGTOnly=0 will enable it.

2024-03-20 20:13:47 -04:00

Linux/AudioMixerSDL

…

LiveLinkAnimationCore

…

LiveLinkInterface

LiveLinkHub - Fix missing content from staged UEFN distribution

2024-03-01 00:27:39 -05:00

LiveLinkMessageBusFramework

LiveLinkHub - Fix timecode setting being sent out to clients that weren't enabled

2024-03-15 17:27:01 -04:00

MaterialShaderQualitySettings

…

MathCore

Created MathCore module, a module meant to regroup all math utils that are not generic enough that they should be in Core (in order not to bloat it) or owned by the foundation team :

2024-02-21 09:41:51 -05:00

Media

Media: Allow peeking at the time range covered by the enqueued media samples.

2024-03-27 03:38:33 -04:00

MediaAssets

ColorManagement: Remaining deprecation of headers & color management module, since they were moved to Core at CL 32299544.

2024-03-25 11:04:55 -04:00

MediaUtils

Adding PTS resync capability to MFW's PlayerFacade to better enable us to play video-only life streams from webcams (with V2 players)

2024-03-28 16:34:05 -04:00

MeshConversion

MeshConversion - DynamicMeshToMeshDescription conversion: Fix crash occuring when input mesh has no attributes

2024-03-20 11:42:49 -04:00

MeshConversionEngineTypes

…

MeshDescription

MeshDescription: Back-comp fix for meshes that somehow got saved with FTransform attributes prior to bulk-data saving being disabled for those attributes.

2024-03-06 20:49:33 -05:00

MeshUtilitiesCommon

…

Messaging

…

MessagingCommon

…

MessagingRpc

…

MoviePlayer

Deprecate:

2024-02-22 11:38:35 -05:00

MoviePlayerProxy

…

MovieScene

Sequencer- Fix regression where Binding Overrides specified on a Level Sequence Actor wouldn't preview in editor in Sequencer.

2024-04-03 10:55:31 -04:00

MovieSceneCapture

Deprecate:

2024-02-22 11:38:35 -05:00

MovieSceneTracks

Sequencer- UX Improvements for the Binding Properties menu.

2024-04-03 05:12:27 -04:00

MRMesh

…

NavigationSystem

Stop trying to interpret very large position/rotation/scale values on a Nav Mesh. Instead, forcibly truncate those values to fit inside a 32 bit integer.

2024-04-04 08:13:46 -04:00

Navmesh

Added unsafe type cast as warnings in AI related plugins/modules: StateTree, Mass, SmartObject. NavigationSystem, and ZoneGraph (partial)

2024-03-21 09:44:11 -04:00

Net

Iris

2024-03-28 13:28:54 -04:00

NetworkFile

…

NetworkFileSystem

Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).

2024-02-19 16:51:58 -05:00

Networking

…

NetworkReplayStreaming

…

NNE

…

NonRealtimeAudioRenderer

…

NullDrv

Make IRHICommandContext::RHICopyBufferRegion pure virtual

2024-03-18 06:53:12 -04:00

NullInstallBundleManager

Deprecate EInstallBundleSourceType and replace with FInstallBundleSourceType

2024-03-20 21:48:59 -04:00

Online

Refactor function FHttpRetrySystem::FManager::ShouldRetry to use early returns.

2024-04-04 14:01:11 -04:00

OodleDataCompression

…

OpenColorIOWrapper

ColorManagement: Remaining deprecation of headers & color management module, since they were moved to Core at CL 32299544.

2024-03-25 11:04:55 -04:00

OpenGLDrv

Fix warning V595: The 'VertexShader' pointer was utilized before it was verified against nullptr.

2024-04-04 11:27:53 -04:00

OpusAudioDecoder/Module

…

Overlay

…

PacketHandlers

…

PakFile

FCompression interface update to 64 bit.

2024-02-21 12:49:23 -05:00

PerfCounters

…

PhysicsCore

TSQVisitor needs to initialize HitFaceNormal in all constructors

2024-03-25 23:17:35 -04:00

PlatformThirdPartyHelpers/PosixShim

…

Portal

…

PreLoadScreen

…

Projects

Adding GameTarget Allow/Deny Lists to UBT

2024-04-04 04:41:05 -04:00

PropertyPath

[Backout] - CL32585960 - CIS Compile Error

2024-03-28 15:39:39 -04:00

RadAudioCodec

…

RawMesh

…

RenderCore

Vectorized TMatrix<float>::To3x4MatrixTranspose, FRenderTransform::To3x4MatrixTranspose, and FRenderTransform::ToMatrix44f

2024-04-04 23:11:03 -04:00

Renderer

[Nanite-Skinning] AVX2 bulk bone transform transpose optimization (courtesy of Fabian Giesen). Currently only used on platforms we can guarantee have AVX2 support.

2024-04-05 00:00:12 -04:00

RHI

Implement support for reserved textures with mip maps in D3D12 RHI. Allow reserved render targets and depth buffers.

2024-04-04 16:10:53 -04:00

RHICore

Remove use of SwitchPipeline at the bottom-of-pipe (i.e. during RHI command list execution).

2024-03-13 13:49:59 -04:00

RSA

…

RuntimeAssetCache

…

SandboxFile

…

Serialization

[Backout] - CL32587777 - CIS Compile Error

2024-03-28 15:53:24 -04:00

SessionMessages

…

SessionServices

…

SignalProcessing

[metasound] optimization for mixer node (avoid memset / memzero)

2024-03-05 14:25:25 -05:00

SkeletalMeshDescription

Skeletal Mesh: Change storage of morph target normals to be on vertex instances rather than vertices, to match how the base normals are stored. Add a backward compatibility path for skeletal meshes imported from Alembic files that have manually constructed UMorphTargets to support non-standard normals on the morph targets.

2024-02-16 11:06:04 -05:00

Slate

Slate: Remove visibility attribute in TableViewBase.

2024-04-04 08:33:04 -04:00

SlateCore

Slate: Invalidation for visibility is now processed in the update lool. An active timer or a tick function can change the visibility. That would clear the cached elements but would not prevent the cached to be replaced during the OnPaint. The widget visibility is collapsed but the cache is valid and batched. Explored another solution to prevent the OnPaint when it changed. But the layout would be wrong and we would have empty spaces for one frame. Better draw it and fix it on the next frame.

2024-04-04 08:25:11 -04:00

SlateNullRenderer

Change World that widget previews use to fix Material Parameter Collections not updating correctly.

2024-03-21 16:05:32 -04:00

SlateRHIRenderer

Change World that widget previews use to fix Material Parameter Collections not updating correctly.

2024-03-21 16:05:32 -04:00

Sockets

…

SoundFieldRendering

…

StaticMeshDescription

MeshAutoUV - Fix array out of bound crash that could occur during the mesh description -> dynamic mesh -> mesh description roundtrip.

2024-03-13 21:29:12 -04:00

StorageServerClient

Adding an error msg in case we find but fail to deserialize ue.projectstore

2024-04-03 10:02:35 -04:00

StreamingFile

…

StreamingPauseRendering

Deprecate:

2024-02-22 11:38:35 -05:00

SymsLib

…

SynthBenchmark

…

TextureUtilitiesCommon

UDIM index Parser : fix previous restriction to max Y of 9 is too conservative, increase to max Y of 90

2024-03-04 17:32:59 -05:00

TimeManagement

…

Toolbox/Private

…

TraceLog

[Insights]

2024-03-14 12:28:28 -04:00

TypedElementFramework

Memento support for undo/redo of deletion through TEDS.

2024-04-04 15:44:30 -04:00

TypedElementRuntime

[Typed Element Bridge] Add TEDS selection set name to the rest of the selection set options structs.

2024-03-01 11:36:31 -05:00

UEJpegComp

…

UELibrary

Entire engine compiling with -DisableUnity -IncludeHeaders

2024-02-23 16:51:32 -05:00

UEWavComp

…

UMG

Panel Slot:

2024-04-01 15:14:04 -04:00

UniversalObjectLocator

Fix UOL ImportTextItem not incrementing past the parsed buffer on success

2024-04-02 11:41:04 -04:00

Unix/UnixCommonStartup

…

UnrealGame

…

VectorVM

…

VirtualFileCache

…

VirtualProduction/StageDataCore

…

VorbisAudioDecoder/Module

…

VulkanRHI

Fix stat RHI memory counter when using Vulkan.

2024-04-02 16:37:59 -04:00

WebBrowser

[Backout] - CL32587777 - CIS Compile Error

2024-03-28 15:53:24 -04:00

WebBrowserTexture

Deprecate:

2024-02-22 11:38:35 -05:00

WidgetCarousel

…

Windows

Fix or suppress Clang 18 issues, support Intel compiler 2024.1

2024-03-29 13:13:48 -04:00

XmlParser

…