Commit Graph

13382 Commits

Author SHA1 Message Date
dan elksnitis
b083d56fb1 [shaders] partial backout of preprocessor optimizations. the reasons for the performance gain were incorrectly assessed and the additional cache is not providing any measurable gains, so removing it as unnecessary complexity.
#rb Jason.Nadro
#preflight 64779d234b0d5a1eb16000b3

[CL 25724429 by dan elksnitis in ue5-main branch]
2023-06-01 09:03:52 -04:00
axel riffard
956db9c900 Add Secondary Remote Mac category to Remote Build in iOS Project Settings
#rb trivial
#preflight 64782d1d5d23eca37d5ff7c3

[CL 25721002 by axel riffard in ue5-main branch]
2023-06-01 02:54:04 -04:00
daren cheng
d7d121f724 [Backout] - CL25717383
[FYI] daren.cheng
Original CL Desc
-----------------------------------------------------------------
Re-submit 25712585 with manual tuple expansion to prevent use before define.
-----------------------------------------------------------------
Slate batching improvements for large element sets
---
Group similar elements at compile time using tuples instead of maps
Merge similar renderbatches in same-typed element buckets (Currently for box and lines only).
Reserve verticies / elements in a batch before using them
Add some comments to invalidation.

#rb Patrick.Boutot
#preflight 646ff8505b484acfee7cc9fa
#jira UE-173455

[CL 25720199 by daren cheng in ue5-main branch]
2023-05-31 23:37:20 -04:00
daren cheng
30e7727aaf Re-submit 25712585 with manual tuple expansion to prevent use before define.
-----------------------------------------------------------------
Slate batching improvements for large element sets
---
Group similar elements at compile time using tuples instead of maps
Merge similar renderbatches in same-typed element buckets (Currently for box and lines only).
Reserve verticies / elements in a batch before using them
Add some comments to invalidation.

#rb Patrick.Boutot
#preflight 646ff8505b484acfee7cc9fa
#jira UE-173455

[CL 25717402 by daren cheng in ue5-main branch]
2023-05-31 18:57:56 -04:00
devin doucette
695762674e DDC: Reverted the change to FCacheStoreAsync::LegacyStats() because it breaks assumptions in reporting of cook stats
#rb none
#rnx

[CL 25717089 by devin doucette in ue5-main branch]
2023-05-31 18:40:14 -04:00
daren cheng
7622b67782 [Backout] - CL25712585
[FYI] daren.cheng
Original CL Desc
-----------------------------------------------------------------
Slate batching improvements for large element sets
---
Group similar elements at compile time using tuples instead of maps
Merge similar renderbatches in same-typed element buckets (Currently for box and lines only).
Reserve verticies / elements in a batch before using them
Add some comments to invalidation.

#rb Patrick.Boutot
#preflight 646ff8505b484acfee7cc9fa
#jira UE-173455

[CL 25716613 by daren cheng in ue5-main branch]
2023-05-31 18:20:34 -04:00
keaton stewart
8bc2626ba4 [Backout] - CL25713520
#fyi Jerome.Delattre
#jira FORT-617474
Original CL Desc
-----------------------------------------------------------------
Add Support for shader model in automation test framework exclusion list

#jira UE-185221
#preflight 646685c83660522200415d43
#rnx
#rb Chris.Constantinescu

[CL 25715585 by keaton stewart in ue5-main branch]
2023-05-31 17:39:06 -04:00
Jerome Delattre
82bc568a43 Add Support for shader model in automation test framework exclusion list
#jira UE-185221
#preflight 646685c83660522200415d43
#rnx
#rb Chris.Constantinescu

[CL 25713520 by Jerome Delattre in ue5-main branch]
2023-05-31 16:39:48 -04:00
devin doucette
6fff9c0396 DDC: Started toward exposing the cache store owner to the cache stores and flattening the hierarchy
- Construct an empty hierarchy first and populate it as the graph is parsed.
- Record the need for async and verify nodes, and create them only at the end.
- Extract parsing of debug options including throttling into the cache store owner.
- Expose the cache store owner to the cache store parsing/creation functions.
- Remove the unused speed class debug option.

#preflight 64777c254b0d5a1eb157ac8b
#rb Joe.Pribele
#rnx

[CL 25713242 by devin doucette in ue5-main branch]
2023-05-31 16:32:05 -04:00
daren cheng
6165a76847 Slate batching improvements for large element sets
---
Group similar elements at compile time using tuples instead of maps
Merge similar renderbatches in same-typed element buckets (Currently for box and lines only).
Reserve verticies / elements in a batch before using them
Add some comments to invalidation.

#rb Patrick.Boutot
#preflight 646ff8505b484acfee7cc9fa
#jira UE-173455

[CL 25712708 by daren cheng in ue5-main branch]
2023-05-31 16:20:47 -04:00
JeanMichel Dignard
e2515d259e Fixed asset rename not updating the soft object paths for packages that were just renamed and left a redirector.
The issue was that when moving folder A and B, where A has assets that depends on assets in B, we'd ask the asset registry for the B assets referencers and it was returning to original packages which are now a redirectors. We'd then try to patch soft object paths on a redirector instead of on an actual asset.

We now force a rescan of the moved folders so that the asset registry is up-to-date throughout the move folders process.

#jira UE-187092
#rb matt.peters, julien.stjean
#preflight 64779c080d55081f54a1eca0

[CL 25710991 by JeanMichel Dignard in ue5-main branch]
2023-05-31 15:30:56 -04:00
dan elksnitis
2acbcb9533 [shaders]
- add new fields to FShaderCompilerOutput which should be populated with the shader source and entry point name if modified by a backend compile process (in a format implementing the independent preprocessing API). this is intended to supercede "OptionalFinalShaderSource" for such shader formats, as well as being used as the source for preprocessed debug dumps when enabled.
- modify the PCD3D shader format to use these fields as intended (and so fix the debug output for pipelines which remove unused interpolators to match the final modified source).

#rb Laura.Hermanns
#preflight 64777f850848b7126dda194c

[CL 25706448 by dan elksnitis in ue5-main branch]
2023-05-31 13:31:39 -04:00
dan elksnitis
459ef8ba65 [shader preprocessor] resubmit - optimizations
- keep a preprocessor-specific shared cache of loaded shader files in ANSI format similar to the one in ShaderCore but skipping the unnecessary additional load to widechar, along with the associated extra allocations and conversions, and stripping comments directly as part of the load
- for in-memory source contained in the environment, which can't use the above due to potential different contents of same-named includes across jobs, perform the widechar->ansichar conversion and comment strip in a single step rather than converting then stripping, to save an additional allocation of the full source

#rb Jason.Nadro
#rb Yuriy.ODonnell
#preflight 64775dca2e6c1a0737f6aaef

[CL 25702732 by dan elksnitis in ue5-main branch]
2023-05-31 11:08:31 -04:00
jonathan bard
7a170c9f24 A couple of adjustments to console input :
* Closed the suggestion box when using the keyboard shortcut (tilde key, usually) to switch between status bar console input to output log console input
* Auto-adjusted the editable text box size so that we better see the content for long console commands

#rb sebastian.arleryd
#preflight 647715d80848b7126daffd3f

[CL 25700377 by jonathan bard in ue5-main branch]
2023-05-31 09:09:27 -04:00
ryan mangin
cc3ce65292 Fix for Sample Rate cook issue on switch
Version bump: UE_AUDIO_ADPCM_VER

#jira: FORT-610231
#rb: seth.weedin

[FYI] helen.yang, jimmy.smith


#rnx

[CL 25680663 by ryan mangin in ue5-main branch]
2023-05-30 13:04:41 -04:00
jonathan bard
4621ca71a1 Fixed position of debug text for UE_VLOG_OBOX
#rb Mieszko.Zielinski
#preflight 6475f045b310540a8d74d378

[CL 25677262 by jonathan bard in ue5-main branch]
2023-05-30 10:31:31 -04:00
ionut matasaru
1a973fd151 [Insights]
- Session Info: Added "Project Name" info, if available.
  - Session Info: Added "Other Metadata" info, if available.
  - Session Info: Added "TraceId" as an optional metadata.

#rb Johan.Berg
#preflight 6475e3ab03438130a4e09691

[CL 25676376 by ionut matasaru in ue5-main branch]
2023-05-30 09:53:56 -04:00
Joakim Lindqvist
3924fcb886 DDC is Derived Data Cache - update the message to reflect that.
#preflight none
#rb none

[CL 25674030 by Joakim Lindqvist in ue5-main branch]
2023-05-30 05:49:24 -04:00
axel riffard
a37fb1865c Fix iOS remote build project settings category
#rb trivial
#jira none
#preflight 6475bc6141108655e07f37a5

[CL 25673826 by axel riffard in ue5-main branch]
2023-05-30 05:22:13 -04:00
Johan Berg
5a69019c18 Enable functionality in Insights toolbar and session browser for all platforms.
Some options in the toolbar and the session browser were not displayed on Linux and Mac since they didn't have UnrealTraceServer. With this feature enabled we can display all options on all platforms.

#rb ionut.matasaru
#preflight 6474ac1dd36191bd261337d1

[CL 25672740 by Johan Berg in ue5-main branch]
2023-05-30 04:25:01 -04:00
joe pribele
bcf1352880 finish initializing the garbage collector allowing tests to run GC
#rb Chris.Constantinescu
https://p4-swarm.epicgames.net/reviews/25665144
#preflight 6474e4595152deaa1097fb22

[CL 25667530 by joe pribele in ue5-main branch]
2023-05-29 15:37:03 -04:00
ionut matasaru
35811d683a [Insights]
- Improved FBaseTreeNode API.
    * Made the array of filtered nodes optional (allocated only when needed).
    * Removed the Tooltip and Context from FGroupNodeData (there are not needed anymore as these info can be added in a FTableTreeNode derived class when needed).
    * These saves memory used by large tree views (for a tree view of 3M allocations grouped by callstack the saving is ~25%).
    * Updated the banner text displayed when tree is empty or filtered.
  - Memory Insights: Added new FCallstackFrameGroupNode for the group nodes used in by Callstack grouping. Also fixed the special tooltip for these nodes to be formatted on multiple lines.

#rb none
#preflight 6474a8b8d36191bd2612fc09

[CL 25664232 by ionut matasaru in ue5-main branch]
2023-05-29 10:54:56 -04:00
Alexis Matte
e02363dd23 Change the AssetImportTask interchange options to use FSoftObjectPath instead of TObjectPtr to allow adding python and blueprint pipeline when filling the options.
#jira UE-171404
#rb none
#rnx
#preflight 6474b34cd36191bd261644fe

[CL 25664015 by Alexis Matte in ue5-main branch]
2023-05-29 10:34:59 -04:00
Johan Berg
2a0a9d8ec7 Disable internal trace store for all platforms.
Standalone servers have been submitted for all desktop platform. Disable hosted trace store everywhere and enable launching of the server.

#rb ionut.matasaru
#preflight 64749db03535a898de7c1983

[CL 25663303 by Johan Berg in ue5-main branch]
2023-05-29 08:52:39 -04:00
paul chipchase
735fef839d Fix potential threading crash in UnrealPak
#rb Per.Larsson
#jira UE-186965
#preflight 6470b4a9f3773f755083fa2c

- The compressor stat arrays belonging to FOutputPakFile were being initialized right after async pakfile work has been scheduled. In rare cases the scheduled work could run before the initialization was completed and we would attempt to write out stats into uninitialized memory.
- We now make sure that the stat arrays are initialized before any work can be scheduled.
- I did a quick pass to check for similar patterns but couldn't find any.

[CL 25661995 by paul chipchase in ue5-main branch]
2023-05-29 02:46:04 -04:00