Commit Graph

291 Commits

Author SHA1 Message Date
henrik karlsson
2b3ad519a5 Fixed compile error surfaced when orphaned headers got compiled (they were never included in their own module so compiler warning settings was never applied)
Changes include
* Removed #pragma once in cpp files
* Removed dll export on templated types
* Fixed code in headers that didn't compile (probably never included anywhere
* Added casting for code going from int to float. Header was never compiled in the owning module that had warnings as errors

#preflight 637b10c6fa348e848054bd0d
#rb none (devin.doucette for a couple files)

[CL 23218414 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:34 -05:00
henrik karlsson
b5164ac775 Fixes to make modules compile with IWYU. We've added to IWYU toolchain so it compiles "orphaned" headers which does not have a owning cpp file. This identified lots of headers that couldn't be compiled by themselves (or if they were to included first)
Change consist of only forward declaration and additional includes

#preflight 63789c1de30d438849c48188
#rb none

[CL 23218412 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:23 -05:00
ryan schmidt
ef1f0f9960 GeometryCore: DynamicMeshAttributeSet now serializes bone weight layer FNames as strings. Conceivably this is a breaking change, however the previous code was completely broken and so no "in the wild" serialized dynamic meshes with skin weight layers should exist.
#rb michael.balzer
#preflight 636a89ef843e6ac794ce915d

[CL 23207953 by ryan schmidt in ue5-main branch]
2022-11-18 17:50:41 -05:00
Jimmy Andrews
6459e6d93f Make C-array exact predicate calls const-correct, and remove/deprecate confusing 'template VectorType' versions that were making the C-array versions difficult to call. To do the deprecation, the 'template VectorType' has been replaced with explicit inline functions that handle the existing vector types.
#rb david.hill
#preflight 637556d4953c19d4352a7bee

[CL 23184198 by Jimmy Andrews in ue5-main branch]
2022-11-17 16:46:44 -05:00
Jimmy Andrews
941db20dc4 fix incorrect direct assignments to TFunctionRef
#rb rex.hill
#preflight 63769b2cf514e1ded961caed

[CL 23183068 by Jimmy Andrews in ue5-main branch]
2022-11-17 15:52:12 -05:00
henrik karlsson
5b96352978 Fixes for c++ headerunits/modules.
* Adding forward declarations
* Adding "inline" in front of const/constexpr variables in headers
* Adding includes
* A few moves of ctor/dtor to cpp file

#preflight 6372b3ac0c74adb48b49f313
#rb none

[CL 23130896 by henrik karlsson in ue5-main branch]
2022-11-14 19:59:41 -05:00
matija kecman
3741003f3b RenderCaptureBaking: Improve performance when adding/removing capture channels
- When adding a new channel: Only the newly requested channel is captured, previously all enabled channels were (re)captured
- When removing an already captured channel: We no longer recompute all remaining channels, we just wipe the one that was removed


#rnx
#rb ryan.schmidt
#preflight 6372120fbf76990b71f17750

[CL 23115901 by matija kecman in ue5-main branch]
2022-11-14 05:09:53 -05:00
Jimmy Andrews
0a7d11eeb3 fix broken tet mesh test by making tets consistently generate by default in the UE orientation (orient3d gives negative sign), and switching the Validate function back to expecting that orientation
#rb tyson.brochu
#preflight 636d86315368a3230a6629e2

[CL 23090187 by Jimmy Andrews in ue5-main branch]
2022-11-10 18:45:07 -05:00
Jimmy Andrews
48486e8cb5 Add 3D Delaunay + tests
#rb david.hill
#preflight 636d3d0db839cb7ec554f864

[CL 23086658 by Jimmy Andrews in ue5-main branch]
2022-11-10 15:20:34 -05:00
Jimmy Andrews
5ad977f642 fix unity build by removing CA_SUPPRESS, as I could not reproduce the static analysis warning it was meant to suppress
#preflight 636bdacd376a9cd6a8a695e5
#rb trivial

[CL 23056660 by Jimmy Andrews in ue5-main branch]
2022-11-09 12:03:00 -05:00
Jimmy Andrews
c9905f983c Add InSphere to exact predicates + test coverage
#rb tyson.brochu
#preflight 636932a3ed07daaa9ab89d3b

[CL 23016482 by Jimmy Andrews in ue5-main branch]
2022-11-07 15:16:04 -05:00
henrik karlsson
998789b3fc Fixed non-unity/pch errors
#rb none
#jira none
#preflight skipped

[CL 22982751 by henrik karlsson in ue5-main branch]
2022-11-04 03:02:59 -04:00
Jimmy Andrews
af1c5f56a7 Add exact triangle intersection methods
#rb david.hill
#preflight 63642c0b1052c15f13a32564

[CL 22967491 by Jimmy Andrews in ue5-main branch]
2022-11-03 17:29:47 -04:00
rinat abdrashitov
1da1ecb3f0 -Added a new flag (bBlendZeroInfluence) to the FBoneWeightSettings to allow control over how zero-influence bones are treated during the blend. The Blend method will now consider the flag when performing the interpolation.
-Added a Blend function overload that handles barycentric interpolation of 3 skin weights.
-Refactored SetBoneWeightsFromBary (in DynamicVertexSkinWeightsAttribute.h) and ConstructVertexSkinWeightsAttribute (in SelectiveTessellate.cpp) functions to use the newly added Blend function for barycentric interpolation.
-Since the default Blend behavior has changed, make sure that unit tests in BoneWeightTests.cpp are refactored. Added more tests for cases when bBlendZeroInfluence is set to true and when using Blend for barycentric interpolation.

#rb halfdan.ingvarsson
#jira None
#preflight 6361de120c2e7c8f91668a75

[CL 22921407 by rinat abdrashitov in ue5-main branch]
2022-11-02 13:53:31 -04:00
jimmy andrews
56855bd081 Add a GetFace method to TConvexHull3 and use it to get polygonal faces for convex hulls when building a convex hull for Chaos. This makes us less likely to add near-degenerate faces for which we cannot compute the normals.
#rb Chris.Caulfield
#preflight 63613dae41625be270d322c4

[CL 22890192 by jimmy andrews in ue5-main branch]
2022-11-01 16:03:10 -04:00
jimmy andrews
2991d7503d fix for edge collapse leaving isolated elements with parents, which breaks overlay validity
#jira UE-167932
#rb david.hill
#preflight 635302fd777a77c4407286ec

[CL 22712189 by jimmy andrews in ue5-main branch]
2022-10-22 15:36:09 -04:00
tyson brochu
2e19cd43f6 Cloth Editor: enable adding/deleting weight maps directly in the weight map paint tool. (Currently the user has to go through the Attribute Editor tool to do this.)
#rb david.hill rinat.abdrashitov
#preflight 633f3fd52a0a2c1ead43571b

[CL 22383750 by tyson brochu in ue5-main branch]
2022-10-06 16:57:39 -04:00
jimmy andrews
4456058517 Make visual studio compile exact predicate code with precise math compile settings, for more consistent performance results, and change to generally compute in double precision for predicates where the 'difficult' cases can be ~50x more expensive to compute.
Add a TODO to reconsider the INEXACT volatile setting now that we compile with precise floating point math; preliminary testing indicates it should work and be significantly faster in 'difficult' cases.

#rb david.hill
#preflight 63327ebec7791417aa9b2737

[CL 22217357 by jimmy andrews in ue5-main branch]
2022-09-27 22:55:36 -04:00
tyson brochu
7d7a4c3697 FindNearestCurveToRay: when processing segments in a curve, balance the distance-to-ray-origin against the ray-segment distance to find the optimal segment
#jira UE-139813
#rb jimmy.andrews david.hill
#preflight 6331db9e7b582f58ab76ee10

[CL 22193238 by tyson brochu in ue5-main branch]
2022-09-26 16:25:25 -04:00
jimmy andrews
4837ae2192 fix epsilon's type in extreme points class
#rb tyson.brochu
#preflight 632527cd121ffddebcc8c155

[CL 22086973 by jimmy andrews in ue5-main branch]
2022-09-19 21:55:34 -04:00
jimmy andrews
1fb9676459 Make mesh symmetry detection detect more symmetry cases, more robustly, so VSculpt will recognize symmetry after using Mirror Tool
#jira UE-159448
#rb david.hill
#preflight 63237c365a44869a7d0922f8

[CL 22040790 by jimmy andrews in ue5-main branch]
2022-09-15 18:44:06 -04:00
rinat abdrashitov
8c57151ead Extend FSweepGeneratorBase and FGeneralizedCylinderGenerator to support open 2D profile curves, and custom UV for the profile and path.
#rb ryan.schmidt
#preflight 631b9d27d31788ea3ab11611
#rnx

[CL 21935699 by rinat abdrashitov in ue5-main branch]
2022-09-10 00:04:32 -04:00
jimmy andrews
e1a6e9f692 Fix AABB -> FBox/FBox2D casts for LWC (don't cast to float)
#rb david.hill
#preflight 63197dc3967ffc68fbc61b06

[CL 21908827 by jimmy andrews in ue5-main branch]
2022-09-08 20:30:09 -04:00
Jimmy Andrews
e5cb5549f0 Fix FTransformSRT3d::InverseTransformNormal applying the scaling and rotation in the wrong order
#rb david.hill
#preflight 630fde5d0345de4ccfdf7fa2

[CL 21734185 by Jimmy Andrews in ue5-main branch]
2022-08-31 20:32:07 -04:00
Jimmy Andrews
6fe4d60ab1 Handle mesh inversions due to transforms in ComponentCollisionUtil + add missing transform calls
#rb ryan.schmidt
#preflight 630d2ad8e54ec9d58164fba7

[CL 21707736 by Jimmy Andrews in ue5-main branch]
2022-08-30 15:41:50 -04:00