mirror of
https://github.com/encounter/engine.git
synced 2026-03-30 11:09:55 -07:00
Update comment on Scenic shapes following feedback from schwa423@ (#4563)
This commit is contained in:
@@ -24,10 +24,12 @@ class PhysicalShapeLayer : public ContainerLayer {
|
||||
} else if (path.isRRect(&frameRRect_)) {
|
||||
isRect_ = frameRRect_.isRect();
|
||||
} else {
|
||||
// Fuchsia's compositor currently only supports rounded rectangle frames.
|
||||
// Scenic currently doesn't provide an easy way to create shapes from
|
||||
// arbitrary paths.
|
||||
// For shapes that cannot be represented as a rounded rectangle we
|
||||
// default to use the bounding rectangle.
|
||||
// TODO(amirh): fix this once Fuchsia supports arbitrary shaped frames.
|
||||
// TODO(amirh): fix this once we have a way to create a Scenic shape from
|
||||
// an SkPath.
|
||||
frameRRect_ = SkRRect::MakeRect(path.getBounds());
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user