From d5cd548b5ddabe68d8526a0cdd96500a8539b587 Mon Sep 17 00:00:00 2001 From: amirh Date: Wed, 17 Jan 2018 14:39:40 -0800 Subject: [PATCH] Update comment on Scenic shapes following feedback from schwa423@ (#4563) --- flow/layers/physical_shape_layer.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/flow/layers/physical_shape_layer.h b/flow/layers/physical_shape_layer.h index db6d75646..d4c035079 100644 --- a/flow/layers/physical_shape_layer.h +++ b/flow/layers/physical_shape_layer.h @@ -24,10 +24,12 @@ class PhysicalShapeLayer : public ContainerLayer { } else if (path.isRRect(&frameRRect_)) { isRect_ = frameRRect_.isRect(); } else { - // Fuchsia's compositor currently only supports rounded rectangle frames. + // Scenic currently doesn't provide an easy way to create shapes from + // arbitrary paths. // For shapes that cannot be represented as a rounded rectangle we // default to use the bounding rectangle. - // TODO(amirh): fix this once Fuchsia supports arbitrary shaped frames. + // TODO(amirh): fix this once we have a way to create a Scenic shape from + // an SkPath. frameRRect_ = SkRRect::MakeRect(path.getBounds()); } }