Zebediah Figura
6919d12eba
ntdll-CriticalSection: Remove patch set. ...
This patch set is currently broken, as the RtlEnterCriticalSection()
implementation has changed without corresponding changes to the inline version.
More broadly, it is very surprising, and never really substantiated, that
inlining helps significantly. There is no record of why the patches were
written, but my guess is that they were written in an attempt to optimize heap
allocation, and my further guess is that targeting critical sections in
particular was motivated by perf traces.
Besides the fact that perf traces are unreliable on the best days, and that
anything that spins or uses atomics like our CS implementation is going to be
overrepresented especially relative to the practical impact, the heap
implementation was optimized for cases that matter with the introduction of the
LFH, and crucially, the LFH is lock free.
As for threadpools, I suspect that Sebastian took note of them as the only other
user of locking in ntdll, and that the inline version was used there because
there was no real reason not to.
At the end of the day, these patches are incorrect, probably help nothing, and
even if we did find they helped something we'd want to do a lot more
investigation and probably solve the problem a different way. Remove them.
2024-04-28 18:46:00 -05:00
2024-01-14 09:17:25 +11:00
2024-03-08 17:40:23 -06:00
2022-12-11 11:12:41 +11:00
2020-01-27 16:55:18 -06:00
2023-08-31 09:24:21 +10:00
2024-04-24 07:57:47 +10:00
2024-01-13 13:33:10 -06:00
2023-10-10 18:41:08 +11:00
2020-02-12 11:49:28 +03:00
2023-08-16 10:04:48 +10:00
2023-09-26 09:26:16 +10:00
2023-07-22 10:12:24 +10:00
2024-01-14 09:17:25 +11:00
2024-04-23 07:48:05 +10:00
2023-06-07 08:26:53 +10:00
2023-08-02 09:58:16 +10:00
2023-11-02 14:01:32 +11:00
2023-07-14 11:08:23 +10:00
2024-03-27 11:44:08 +11:00
2023-08-16 10:04:48 +10:00
2024-03-13 15:56:53 +11:00
2023-03-28 18:40:22 +11:00
2023-07-08 15:20:31 +10:00
2024-03-21 19:29:09 -05:00
2023-07-08 10:49:44 +10:00
2020-12-17 08:14:07 +11:00
2024-02-29 11:17:10 +11:00
2024-01-14 09:17:25 +11:00
2024-01-27 12:32:15 +11:00
2022-03-23 10:56:10 +11:00
2023-06-13 07:55:27 +10:00
2023-11-29 18:35:48 -06:00
2021-10-07 13:16:17 +11:00
2024-04-20 13:18:16 +10:00
2021-06-08 12:21:21 +10:00
2024-03-23 17:27:34 +11:00
2024-03-27 13:53:01 -05:00
2022-02-14 18:52:59 -06:00
2023-11-25 13:08:00 +11:00
2023-08-23 12:43:48 +10:00
2024-01-24 13:12:34 +11:00
2024-03-23 17:27:34 +11:00
2024-01-24 13:13:27 +11:00
2024-03-30 05:37:35 +11:00
2021-05-24 22:39:23 -05:00
2023-08-23 12:05:42 +10:00
2022-03-04 12:57:42 +11:00
2024-01-06 10:00:35 +11:00
2024-01-25 16:25:39 +11:00
2024-02-29 11:17:10 +11:00
2024-03-07 23:34:34 -06:00
2024-01-14 09:17:25 +11:00
2021-02-28 15:06:13 -06:00
2023-02-25 19:56:00 +11:00
2024-04-27 08:23:43 +10:00
2022-09-01 17:13:59 -05:00
2023-12-03 13:42:02 -06:00
2024-04-05 10:27:32 +11:00
2022-11-23 12:08:59 +11:00
2022-11-27 13:39:48 +11:00
2022-11-23 12:08:59 +11:00
2022-11-23 12:08:59 +11:00
2024-01-13 13:33:21 -06:00
2020-01-27 16:05:11 -06:00
2024-02-29 18:06:56 -06:00
2024-03-01 19:19:58 -06:00
2023-09-21 08:08:08 +10:00
2024-02-29 18:06:56 -06:00
2023-11-02 14:01:32 +11:00
2023-10-31 10:54:56 +11:00
2023-04-16 16:19:00 -05:00
2023-11-17 11:20:22 +11:00
2024-01-24 13:42:41 +11:00
2024-03-01 23:50:11 -06:00
2024-03-21 19:15:54 -05:00
2024-03-21 19:29:09 -05:00
2023-10-06 08:38:46 +11:00
2024-03-22 00:12:27 -05:00
2021-02-02 10:51:17 +11:00
2024-03-21 19:15:54 -05:00
2023-11-04 14:20:40 +11:00
2023-12-13 18:28:24 +11:00
2022-03-15 09:46:34 +11:00
2024-03-07 23:29:47 -06:00
2022-02-03 11:11:23 +11:00
2024-03-19 18:42:11 -05:00
2021-09-16 09:35:15 +10:00
2022-03-16 12:49:27 +11:00
2022-08-09 07:58:38 +10:00
2024-01-24 10:55:59 +11:00
2022-07-29 08:38:12 +10:00
2022-05-04 12:28:16 +10:00
2022-03-18 11:29:35 +11:00
2022-07-29 08:38:12 +10:00
2020-09-23 17:32:29 -05:00
2023-06-29 08:52:05 +10:00
2021-12-07 14:08:29 +11:00
2022-03-18 11:29:35 +11:00
2024-03-23 17:27:34 +11:00
2022-03-18 11:29:35 +11:00
2024-01-26 17:41:53 -06:00
2024-03-09 11:53:27 +11:00
2021-06-01 19:05:11 -05:00
2024-03-10 07:38:53 +11:00
2023-09-22 09:25:26 +10:00
2022-06-09 18:45:26 -05:00
2022-11-08 16:54:42 -06:00
2024-01-27 12:32:15 +11:00
2022-03-15 09:48:31 +11:00
2024-04-24 09:06:04 +10:00
2022-11-16 10:25:40 +11:00
2024-04-23 18:55:33 -05:00
2024-03-25 08:50:14 +11:00
2022-03-16 13:09:22 +11:00
2023-07-28 08:02:08 +10:00
2024-03-01 19:37:39 -06:00
2023-09-09 12:01:15 +10:00
2022-02-07 23:49:59 -06:00
2023-10-17 10:12:05 +11:00
2020-04-18 14:54:07 +10:00
2019-11-12 19:56:51 -06:00
2023-02-11 11:20:39 +11:00
2023-07-28 08:02:08 +10:00
2022-02-05 13:01:18 +11:00
2023-07-28 08:02:08 +10:00
2023-07-28 08:02:08 +10:00
2023-04-20 07:28:44 +10:00
2022-03-12 11:27:46 +11:00
2022-07-28 16:20:21 +10:00
2024-03-27 18:08:14 -05:00
2024-04-19 07:51:57 +10:00
2024-01-14 09:17:25 +11:00
2023-05-10 09:48:48 +10:00
2022-08-18 20:07:09 +10:00
2023-11-17 11:20:22 +11:00
2023-11-29 18:35:48 -06:00
2024-04-25 16:57:40 -05:00
2023-12-01 17:23:49 -06:00
2023-04-06 09:14:54 +10:00
2023-05-26 09:22:33 +10:00
2022-04-14 11:35:35 -05:00
2022-06-16 09:05:11 +10:00
2022-04-15 19:33:13 -05:00
2022-04-20 15:13:50 -05:00
2024-02-19 16:23:40 -06:00
2023-09-15 08:19:50 +10:00
2022-05-06 10:48:57 +10:00
2024-04-25 16:57:40 -05:00
2021-05-11 01:01:15 -05:00
2021-05-29 14:24:02 +10:00
2023-07-28 17:54:06 +10:00
2024-01-13 13:33:54 -06:00
6919d12eba