Release v9.9

Squashed for release.

.github/workflows/macOS.yml

@@ -7,17 +7,20 @@ on:
 
 jobs:
   wine-staging:
-    runs-on:  macos-latest
+    # https://github.com/actions/runner-images/issues/9741
+    runs-on:  macos-13
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Install dependencies
         run: |
           brew install --cask xquartz
-          brew install  bison \
+          brew install  autoconf \
+                        bison \
                         gphoto2 \
-                        gst-plugins-base \
+                        gstreamer \
+                        gcenx/wine/libinotify-kqueue \
                         mingw-w64 \
                         molten-vk \
                         sdl2
@@ -52,7 +55,6 @@ jobs:
                         --without-alsa \
                         --without-capi \
                         --without-dbus \
-                        --without-inotify \
                         --without-oss \
                         --without-pulse \
                         --without-udev \

patches/Compiler_Warnings/0003-d2d1-Avoid-implicit-cast-of-interface-pointer.patch

@@ -1,4 +1,4 @@
-From 683fab1d88342c11a52ac3b919964837e6f36823 Mon Sep 17 00:00:00 2001
+From ef7171d2eb01b4b8aaf8c4c608ceebd698d96e3c Mon Sep 17 00:00:00 2001
 From: Sebastian Lackner <sebastian@fds-team.de>
 Date: Tue, 22 Mar 2016 21:54:26 +0100
 Subject: [PATCH] d2d1: Avoid implicit cast of interface pointer.
@@ -66,15 +66,15 @@ index 75cd72b5b9f..314123373b7 100644
  
  static HRESULT STDMETHODCALLTYPE d2d_bitmap_brush_QueryInterface(ID2D1BitmapBrush1 *iface,
 diff --git a/dlls/d2d1/d2d1_private.h b/dlls/d2d1/d2d1_private.h
-index dced9847390..e86e1945bdd 100644
+index c0ac5ba9a44..e171c1c6bd8 100644
 --- a/dlls/d2d1/d2d1_private.h
 +++ b/dlls/d2d1/d2d1_private.h
 @@ -697,7 +697,7 @@ struct d2d_factory
  
  static inline struct d2d_factory *unsafe_impl_from_ID2D1Factory(ID2D1Factory *iface)
  {
--    return CONTAINING_RECORD(iface, struct d2d_factory, ID2D1Factory3_iface);
-+    return CONTAINING_RECORD((ID2D1Factory3*)iface, struct d2d_factory, ID2D1Factory3_iface);
+-    return CONTAINING_RECORD(iface, struct d2d_factory, ID2D1Factory7_iface);
++    return CONTAINING_RECORD((ID2D1Factory7*)iface, struct d2d_factory, ID2D1Factory7_iface);
  }
  
  void d2d_effects_init_builtins(struct d2d_factory *factory);

patches/Pipelight/0001-winex11-Implement-X11DRV_FLUSH_GDI_DISPLAY-ExtEscape-c.patch

@@ -1,41 +0,0 @@
-From 32ae090ad4a99862a420cfe44847d8e2905cdde7 Mon Sep 17 00:00:00 2001
-From: Sebastian Lackner <sebastian@fds-team.de>
-Date: Sat, 21 Dec 2013 23:57:02 +0100
-Subject: winex11: Implement X11DRV_FLUSH_GDI_DISPLAY ExtEscape command
-
----
- dlls/winex11.drv/init.c   |    3 +++
- dlls/winex11.drv/x11drv.h |    3 ++-
- 2 files changed, 5 insertions(+), 1 deletion(-)
-
-diff --git a/dlls/winex11.drv/init.c b/dlls/winex11.drv/init.c
-index 5a7d316..68d3f96 100644
---- a/dlls/winex11.drv/init.c
-+++ b/dlls/winex11.drv/init.c
-@@ -440,6 +440,9 @@ static INT X11DRV_ExtEscape( PHYSDEV dev, INT escape, INT in_count, LPCVOID in_d
-                     return TRUE;
-                 }
-                 break;
-+            case X11DRV_FLUSH_GDI_DISPLAY:
-+                XFlush( gdi_display );
-+                return TRUE;
-             default:
-                 break;
-             }
-diff --git a/dlls/winex11.drv/x11drv.h b/dlls/winex11.drv/x11drv.h
-index 9008db6..85dd2a5 100644
---- a/dlls/winex11.drv/x11drv.h
-+++ b/dlls/winex11.drv/x11drv.h
-@@ -277,7 +277,8 @@ enum x11drv_escape_codes
-     X11DRV_GET_DRAWABLE,     /* get current drawable for a DC */
-     X11DRV_START_EXPOSURES,  /* start graphics exposures */
-     X11DRV_END_EXPOSURES,    /* end graphics exposures */
--    X11DRV_FLUSH_GL_DRAWABLE /* flush changes made to the gl drawable */
-+    X11DRV_FLUSH_GL_DRAWABLE, /* flush changes made to the gl drawable */
-+    X11DRV_FLUSH_GDI_DISPLAY /* flush the gdi display */
- };
- 
- struct x11drv_escape_set_drawable
--- 
-1.7.9.5
-

patches/Pipelight/0002-user32-Decrease-minimum-SetTimer-interval-to-5-ms.patch

@@ -1,25 +0,0 @@
-From ebe00ceb4f2d24f2611dbec87486d6597a3466a9 Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Michael=20M=C3=BCller?= <michael@fds-team.de>
-Date: Fri, 2 May 2014 20:46:19 +0200
-Subject: [PATCH] user32: Decrease minimum SetTimer interval to 5 ms. (try 2)
-
----
- dlls/win32u/message.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/dlls/win32u/message.c b/dlls/win32u/message.c
-index d2909339983..337d4a2cc1d 100644
---- a/dlls/win32u/message.c
-+++ b/dlls/win32u/message.c
-@@ -3975,7 +3975,7 @@ UINT_PTR WINAPI NtUserSetTimer( HWND hwnd, UINT_PTR id, UINT timeout, TIMERPROC
- 
-     if (proc) winproc = alloc_winproc( (WNDPROC)proc, TRUE );
- 
--    timeout = min( max( USER_TIMER_MINIMUM, timeout ), USER_TIMER_MAXIMUM );
-+    timeout = min( max( 5, timeout ), USER_TIMER_MAXIMUM );
- 
-     SERVER_START_REQ( set_win_timer )
-     {
--- 
-2.42.0
-

patches/Pipelight/0004-winex11.drv-Indicate-direct-rendering-through-OpenGL.patch

@@ -1,46 +0,0 @@
-From a9cf27a493697c97249ce526483d25c871c053c4 Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Michael=20M=C3=BCller?= <michael@fds-team.de>
-Date: Sun, 1 Jun 2014 22:51:32 +0200
-Subject: [PATCH] winex11.drv: Indicate direct rendering through OpenGL
- extension
-
----
- dlls/winex11.drv/opengl.c | 7 +++++--
- 1 file changed, 5 insertions(+), 2 deletions(-)
-
-diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c
-index 92555841f71..71e7ecbcf7c 100644
---- a/dlls/winex11.drv/opengl.c
-+++ b/dlls/winex11.drv/opengl.c
-@@ -410,6 +410,7 @@ static int GLXErrorHandler(Display *dpy, XErrorEvent *event, void *arg)
- static BOOL X11DRV_WineGL_InitOpenglInfo(void)
- {
-     static const char legacy_extensions[] = " WGL_EXT_extensions_string WGL_EXT_swap_control";
-+    static const char direct_extension[] = " WINE_EXT_direct_rendering";
- 
-     int screen = DefaultScreen(gdi_display);
-     Window win = 0, root = 0;
-@@ -465,16 +466,18 @@ static BOOL X11DRV_WineGL_InitOpenglInfo(void)
-     }
-     gl_renderer = (const char *)opengl_funcs.gl.p_glGetString(GL_RENDERER);
-     gl_version  = (const char *)opengl_funcs.gl.p_glGetString(GL_VERSION);
-+    glx_direct = pglXIsDirect(gdi_display, ctx);
-     str = (const char *) opengl_funcs.gl.p_glGetString(GL_EXTENSIONS);
--    glExtensions = malloc( strlen(str) + sizeof(legacy_extensions) );
-+    glExtensions = malloc( strlen(str)+sizeof(legacy_extensions)+sizeof(direct_extension) );
-     strcpy(glExtensions, str);
-     strcat(glExtensions, legacy_extensions);
-+    if (glx_direct)
-+        strcat(glExtensions, direct_extension);
- 
-     /* Get the common GLX version supported by GLX client and server ( major/minor) */
-     pglXQueryVersion(gdi_display, &glxVersion[0], &glxVersion[1]);
- 
-     glxExtensions = pglXQueryExtensionsString(gdi_display, screen);
--    glx_direct = pglXIsDirect(gdi_display, ctx);
- 
-     TRACE("GL version             : %s.\n", gl_version);
-     TRACE("GL renderer            : %s.\n", gl_renderer);
--- 
-2.35.1
-

patches/Pipelight/definition

@@ -1,2 +0,0 @@
-Fixes: Reduced SetTimer minimum value from 10 ms to 5 ms (improves Silverlight framerates)
-Fixes: Other Pipelight-specific enhancements

patches/d3dx9_SetRawValue/0001-d3dx9-Implement-d3dx_effect_SetRawValue.patch

@@ -0,0 +1,182 @@
+From ae80ae124a784078a9838a8aca4b3af308d645dd Mon Sep 17 00:00:00 2001
+From: Patrick Hibbs <hibbsncc1701@gmail.com>
+Date: Fri, 30 Sep 2022 17:58:15 -0400
+Subject: [PATCH] d3dx9: Implement d3dx_effect_SetRawValue
+
+Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012
+
+Signed-off-by: Patrick Hibbs <hibbsncc1701@gmail.com>
+---
+ dlls/d3dx9_36/effect.c | 154 ++++++++++++++++++++++++++++++++++++++++-
+ 1 file changed, 152 insertions(+), 2 deletions(-)
+
+diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
+index ea965ce789b..625af4af36b 100644
+--- a/dlls/d3dx9_36/effect.c
++++ b/dlls/d3dx9_36/effect.c
+@@ -4445,10 +4445,160 @@ static HRESULT WINAPI d3dx_effect_CloneEffect(ID3DXEffect *iface, IDirect3DDevic
+ static HRESULT WINAPI d3dx_effect_SetRawValue(ID3DXEffect *iface, D3DXHANDLE parameter, const void *data,
+         UINT byte_offset, UINT bytes)
+ {
+-    FIXME("iface %p, parameter %p, data %p, byte_offset %u, bytes %u stub!\n",
++    struct d3dx_effect *effect = impl_from_ID3DXEffect(iface);
++    struct d3dx_parameter *param = (parameter == INVALID_HANDLE_VALUE) ? NULL : get_valid_parameter(effect, parameter);
++    const unsigned int single_size = sizeof(DWORD);
++    unsigned int x, index_offset, remaining_byte_offset, remaining_bytes;
++    void *raw;
++
++    TRACE("iface %p, parameter %p, data %p, byte_offset %u, bytes %u.\n",
+             iface, parameter, data, byte_offset, bytes);
+ 
+-    return E_NOTIMPL;
++    /* pendentic */
++    index_offset = 0;
++    remaining_byte_offset = 0;
++
++    /* BOOLs and Matries with a single value copy require sanitization of the
++        byte_offset.
++
++        Specificly, matries with a single value copy only allow byte shifts that
++        are not multiples of the value (DWORD) size. For multiples, we increment
++        the index of the promoted data type, then add any remainder as a byte
++        offset.
++
++        For BOOLs, due to their value sanitization, we only care about the
++        index of their promoted data type. Unless it's a non value size matrix.
++        In that case we do care about the byte offset.
++    */
++    if (byte_offset > 0 && (param->type == D3DXPT_BOOL ||
++            (param->class == D3DXPC_MATRIX_COLUMNS ||
++            param->class == D3DXPC_MATRIX_ROWS)))
++    {
++        remaining_byte_offset = byte_offset % single_size;
++        if (remaining_byte_offset != 0)
++            index_offset = byte_offset / single_size;
++        else
++            index_offset = byte_offset;
++        if (param->type != D3DXPT_BOOL || (bytes != single_size &&
++                (param->class == D3DXPC_MATRIX_COLUMNS ||
++                param->class == D3DXPC_MATRIX_ROWS)))
++        {
++            index_offset = index_offset * single_size;
++            if (param->type != D3DXPT_BOOL)
++                index_offset = index_offset * single_size;
++        }
++    }
++
++    /* If parameter is bad, we are expected to throw C0000005. */
++    switch (param->class)
++    {
++        case D3DXPC_STRUCT:
++            break;
++        case D3DXPC_OBJECT:
++            raw = param_get_data_and_dirtify(effect, param, param->bytes, TRUE);
++            if (data && bytes)
++            {
++                if (((char*)raw)[0] != '\0')
++                {
++                    memset(raw, '\0', param->bytes);
++                    return S_OK; /* This returns a false success. */
++                }
++                else
++                {
++                    return D3DERR_INVALIDCALL;
++                }
++            }
++            break;
++        case D3DXPC_SCALAR:
++            raw = param_get_data_and_dirtify(effect, param, param->bytes, TRUE);
++            if (param->type == D3DXPT_BOOL)
++                *(BOOL*)raw = *(BOOL*)data ? TRUE : FALSE;
++            else
++                memcpy((unsigned char*)raw + byte_offset, data, bytes);
++            return S_OK;
++            break;
++        case D3DXPC_VECTOR:
++            raw = (unsigned char*)param_get_data_and_dirtify(effect, param, param->bytes, TRUE);
++            if (param->type == D3DXPT_BOOL)
++            {
++                raw = (unsigned char*)raw + index_offset;
++                *(DWORD*)raw = *(DWORD*)data ? TRUE : FALSE;
++                memset((unsigned char*)raw + single_size, \
++                        '\0', param->bytes - index_offset - single_size);
++            }
++            else
++            {
++                raw = (unsigned char*)raw + byte_offset;
++                for (x = 0; (x * single_size) + byte_offset < param->bytes && (x * single_size) < bytes; x++)
++                {
++                    memcpy((unsigned char*)raw + (x * single_size), \
++                            (unsigned char*)data + (x * single_size), \
++                            single_size);
++                }
++            }
++            return S_OK;
++            break;
++        case D3DXPC_MATRIX_COLUMNS:
++        case D3DXPC_MATRIX_ROWS:
++            raw = (unsigned char*)param_get_data_and_dirtify(effect, param, param->bytes, TRUE);
++            if (param->type == D3DXPT_BOOL)
++            {
++                if (bytes == single_size)
++                {
++                    raw = (unsigned char*)raw + index_offset;
++                    for (x = 0; (x * single_size) < param->bytes - index_offset; x++)
++                    {
++                        remaining_bytes = param->bytes - index_offset - \
++                                (x * single_size) - single_size;
++                        *(DWORD*)raw = *(DWORD*)data ? TRUE : FALSE;
++                        memset((unsigned char*)raw + single_size, \
++                                '\0', (remaining_bytes > (single_size * 4) ? \
++                                single_size * 4 : remaining_bytes));
++                        raw = (unsigned char*)raw + (remaining_bytes > (single_size * 4) ? \
++                                single_size * 4 : remaining_bytes);
++                    }
++                }
++                else
++                {
++                    raw = (unsigned char*)raw + index_offset;
++                    for (x = 0; (x * single_size) < param->bytes - index_offset; x++)
++                    {
++                        ((DWORD*)raw)[x] = ((DWORD*)data)[x] ? TRUE : FALSE;
++                    }
++                }
++            }
++            else
++            {
++                if (bytes == single_size)
++                {
++                    raw = (unsigned char*)raw + index_offset + remaining_byte_offset;
++                    for (x = 0; (x * single_size) + byte_offset < param->bytes && (x * single_size) < bytes; x++)
++                    {
++                        memcpy((unsigned char*)raw + (x * single_size), \
++                                (unsigned char*)data + (x * single_size), \
++                                single_size);
++                    }
++                }
++                else
++                {
++                    raw = (unsigned char*)raw + byte_offset;
++                    for (x = 0; byte_offset + (x * single_size) < param->bytes &&
++                            (x * single_size) < bytes; x++)
++                    {
++                        memcpy((unsigned char*)raw + (x * single_size), \
++                                (unsigned char*)data + (x * single_size), \
++                                single_size);
++                    }
++                }
++            }
++            return S_OK;
++            break;
++        default:
++            FIXME("Unhandled param class %s.\n", debug_d3dxparameter_class(param->class));
++            break;
++    };
++
++    return D3DERR_INVALIDCALL;
+ }
+ #endif
+ 
+-- 
+2.43.0
+

patches/d3dx9_SetRawValue/definition

@@ -0,0 +1,3 @@
+Fixes: [46012] d3d9: Implement ID3DXEffect::SetRawValue
+
+# https://gitlab.winehq.org/wine/wine/-/merge_requests/979

patches/ddraw-GetPickRecords/0001-ddraw-Implement-Pick-and-GetPickRecords.patch

@@ -1,4 +1,4 @@
-From 0a5214d0fe032778fa3ca4ee60c3d2ba64f8f4c0 Mon Sep 17 00:00:00 2001
+From 274e40a7f25d8041f5b93d132f01e0a66fefe481 Mon Sep 17 00:00:00 2001
 From: Matthew Wong <itsmattkc@gmail.com>
 Date: Fri, 18 Sep 2020 00:47:13 +0000
 Subject: [PATCH] ddraw: Implement Pick() and GetPickRecords().
@@ -37,10 +37,10 @@ Signed-off-by: Myah Caron <qsniyg@protonmail.com>
  4 files changed, 373 insertions(+), 10 deletions(-)
 
 diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h
-index 6fc93b91860..c90b894ea61 100644
+index 1f0c94a9c6e..157384e3579 100644
 --- a/dlls/ddraw/ddraw_private.h
 +++ b/dlls/ddraw/ddraw_private.h
-@@ -338,6 +338,11 @@ struct d3d_device
+@@ -337,6 +337,11 @@ struct d3d_device
      struct d3d_viewport *current_viewport;
      D3DVIEWPORT7 active_viewport;
  
@@ -52,7 +52,7 @@ index 6fc93b91860..c90b894ea61 100644
      /* Required to keep track which of two available texture blending modes in d3ddevice3 is used */
      BOOL legacyTextureBlending;
      D3DTEXTUREBLEND texture_map_blend;
-@@ -571,7 +576,7 @@ struct d3d_execute_buffer *unsafe_impl_from_IDirect3DExecuteBuffer(IDirect3DExec
+@@ -573,7 +578,7 @@ struct d3d_execute_buffer *unsafe_impl_from_IDirect3DExecuteBuffer(IDirect3DExec
  
  /* The execute function */
  HRESULT d3d_execute_buffer_execute(struct d3d_execute_buffer *execute_buffer,
@@ -62,11 +62,11 @@ index 6fc93b91860..c90b894ea61 100644
  /*****************************************************************************
   * IDirect3DVertexBuffer
 diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c
-index bc1d91ee00b..82a813f9064 100644
+index f64db3aa633..60c43c250b1 100644
 --- a/dlls/ddraw/device.c
 +++ b/dlls/ddraw/device.c
-@@ -349,6 +349,9 @@ static ULONG WINAPI d3d_device_inner_Release(IUnknown *iface)
-             IDirect3DDevice3_DeleteViewport(&This->IDirect3DDevice3_iface, &vp->IDirect3DViewport3_iface);
+@@ -333,6 +333,9 @@ static ULONG WINAPI d3d_device_inner_Release(IUnknown *iface)
+             This->ddraw = NULL;
          }
  
 +        if (This->pick_record_size > 0)
@@ -75,7 +75,7 @@ index bc1d91ee00b..82a813f9064 100644
          TRACE("Releasing render target %p.\n", This->rt_iface);
          rt_iface = This->rt_iface;
          This->rt_iface = NULL;
-@@ -758,7 +761,7 @@ static HRESULT WINAPI d3d_device1_Execute(IDirect3DDevice *iface,
+@@ -739,7 +742,7 @@ static HRESULT WINAPI d3d_device1_Execute(IDirect3DDevice *iface,
  
      /* Execute... */
      wined3d_mutex_lock();
@@ -84,7 +84,7 @@ index bc1d91ee00b..82a813f9064 100644
      wined3d_mutex_unlock();
  
      return hr;
-@@ -1025,16 +1028,44 @@ static HRESULT WINAPI d3d_device1_NextViewport(IDirect3DDevice *iface,
+@@ -1006,16 +1009,44 @@ static HRESULT WINAPI d3d_device1_NextViewport(IDirect3DDevice *iface,
   *        x2 and y2 are ignored.
   *
   * Returns:
@@ -133,7 +133,7 @@ index bc1d91ee00b..82a813f9064 100644
  }
  
  /*****************************************************************************
-@@ -1050,13 +1081,35 @@ static HRESULT WINAPI d3d_device1_Pick(IDirect3DDevice *iface, IDirect3DExecuteB
+@@ -1031,13 +1062,35 @@ static HRESULT WINAPI d3d_device1_Pick(IDirect3DDevice *iface, IDirect3DExecuteB
   *  D3DPickRec: Address to store the resulting D3DPICKRECORD array.
   *
   * Returns:
@@ -172,7 +172,7 @@ index bc1d91ee00b..82a813f9064 100644
      return D3D_OK;
  }
 diff --git a/dlls/ddraw/executebuffer.c b/dlls/ddraw/executebuffer.c
-index 320ce6649d4..84366dafd7d 100644
+index 0cf0bf121f3..89915fb7145 100644
 --- a/dlls/ddraw/executebuffer.c
 +++ b/dlls/ddraw/executebuffer.c
 @@ -45,15 +45,106 @@ static void _dump_D3DEXECUTEBUFFERDESC(const D3DEXECUTEBUFFERDESC *lpDesc) {
@@ -378,7 +378,7 @@ index 320ce6649d4..84366dafd7d 100644
                              /* Drop through. */
                          case 2:
                              indices[(i * primitive_size) + 1] = ci->v2;
-@@ -426,6 +597,7 @@ HRESULT d3d_execute_buffer_execute(struct d3d_execute_buffer *buffer, struct d3d
+@@ -424,6 +595,7 @@ HRESULT d3d_execute_buffer_execute(struct d3d_execute_buffer *buffer, struct d3d
  end_of_buffer:
      return D3D_OK;
  }
@@ -387,10 +387,10 @@ index 320ce6649d4..84366dafd7d 100644
  static inline struct d3d_execute_buffer *impl_from_IDirect3DExecuteBuffer(IDirect3DExecuteBuffer *iface)
  {
 diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c
-index d8fcb188c40..bacd9049d6e 100644
+index 96047744635..2364c92eb96 100644
 --- a/dlls/ddraw/tests/ddraw1.c
 +++ b/dlls/ddraw/tests/ddraw1.c
-@@ -15467,6 +15467,137 @@ static void test_enum_devices(void)
+@@ -15507,6 +15507,137 @@ static void test_enum_devices(void)
      ok(!refcount, "Device has %lu references left.\n", refcount);
  }
  
@@ -528,7 +528,7 @@ index d8fcb188c40..bacd9049d6e 100644
  /* Emperor: Rise of the Middle Kingdom locks a sysmem surface and then accesses
   * the pointer after unlocking it. This test roughly replicates the calls that
   * it makes. */
-@@ -15527,6 +15658,7 @@ static void test_pinned_sysmem(void)
+@@ -15567,6 +15698,7 @@ static void test_pinned_sysmem(void)
      IDirectDrawSurface_Release(surface);
      refcount = IDirectDraw_Release(ddraw);
      ok(!refcount, "Device has %lu references left.\n", refcount);
@@ -536,7 +536,7 @@ index d8fcb188c40..bacd9049d6e 100644
      DestroyWindow(window);
  }
  
-@@ -15646,6 +15778,7 @@ START_TEST(ddraw1)
+@@ -15789,6 +15921,7 @@ START_TEST(ddraw1)
      test_vtbl_protection();
      test_window_position();
      test_get_display_mode();

patches/fltmgr.sys-FltBuildDefaultSecurityDescriptor/0001-fltmgr.sys-Implement-FltBuildDefaultSecurityDescript.patch

@@ -1,153 +0,0 @@
-From 8caf8262a8ae8b5f0275172a62d807240d86968d Mon Sep 17 00:00:00 2001
-From: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
-Date: Sun, 29 Aug 2021 13:26:53 +1000
-Subject: [PATCH 1/3] fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
-
-Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
----
- dlls/fltmgr.sys/Makefile.in     |  1 +
- dlls/fltmgr.sys/fltmgr.sys.spec |  4 +-
- dlls/fltmgr.sys/main.c          | 75 ++++++++++++++++++++++++++++++++-
- include/ddk/fltkernel.h         |  3 +-
- 4 files changed, 79 insertions(+), 4 deletions(-)
-
-diff --git a/dlls/fltmgr.sys/Makefile.in b/dlls/fltmgr.sys/Makefile.in
-index 6ebd48d9412..ae0e812cb22 100644
---- a/dlls/fltmgr.sys/Makefile.in
-+++ b/dlls/fltmgr.sys/Makefile.in
-@@ -1,5 +1,6 @@
- MODULE    = fltmgr.sys
- EXTRADLLFLAGS = -Wl,--subsystem,native
-+IMPORTS = ntoskrnl
- 
- SOURCES = \
- 	fltmgr.sys.spec \
-diff --git a/dlls/fltmgr.sys/fltmgr.sys.spec b/dlls/fltmgr.sys/fltmgr.sys.spec
-index 39ce6798178..8943b9f85cf 100644
---- a/dlls/fltmgr.sys/fltmgr.sys.spec
-+++ b/dlls/fltmgr.sys/fltmgr.sys.spec
-@@ -10,7 +10,7 @@
- @ stub FltAllocatePoolAlignedWithTag
- @ stub FltAttachVolume
- @ stub FltAttachVolumeAtAltitude
--@ stub FltBuildDefaultSecurityDescriptor
-+@ stdcall FltBuildDefaultSecurityDescriptor(ptr long)
- @ stub FltCancelFileOpen
- @ stub FltCancelIo
- @ stub FltCbdqDisable
-@@ -60,7 +60,7 @@
- @ stub FltFreeFileLock
- @ stub FltFreeGenericWorkItem
- @ stub FltFreePoolAlignedWithTag
--@ stub FltFreeSecurityDescriptor
-+@ stdcall FltFreeSecurityDescriptor(ptr)
- @ stub FltFsControlFile
- @ stub FltGetBottomInstance
- @ stub FltGetContexts
-diff --git a/dlls/fltmgr.sys/main.c b/dlls/fltmgr.sys/main.c
-index e1016a4989c..9a85f4b6c82 100644
---- a/dlls/fltmgr.sys/main.c
-+++ b/dlls/fltmgr.sys/main.c
-@@ -23,7 +23,6 @@
- #include "ntstatus.h"
- #define WIN32_NO_STATUS
- #include "windef.h"
--#include "winbase.h"
- #include "winternl.h"
- #include "ddk/fltkernel.h"
- 
-@@ -93,3 +92,77 @@ void* WINAPI FltGetRoutineAddress(LPCSTR name)
- 
-     return func;
- }
-+
-+NTSTATUS WINAPI FltBuildDefaultSecurityDescriptor(PSECURITY_DESCRIPTOR *descriptor, ACCESS_MASK access)
-+{
-+    PACL dacl;
-+    NTSTATUS ret = STATUS_INSUFFICIENT_RESOURCES;
-+    DWORD sid_len;
-+    SID *sid;
-+    SID *sid_system = NULL;
-+    PSECURITY_DESCRIPTOR sec_desc = NULL;
-+    SID_IDENTIFIER_AUTHORITY auth = { SECURITY_NULL_SID_AUTHORITY };
-+
-+    *descriptor = NULL;
-+
-+    sid_len = RtlLengthRequiredSid(2);
-+    sid = ExAllocatePool(PagedPool, sid_len);
-+    if (!sid)
-+        goto done;
-+    RtlInitializeSid(sid, &auth, 2);
-+    sid->SubAuthority[1] = DOMAIN_GROUP_RID_ADMINS;
-+    sid->SubAuthority[0] = SECURITY_BUILTIN_DOMAIN_RID;
-+
-+    sid_len = RtlLengthRequiredSid(1);
-+    sid_system = ExAllocatePool(PagedPool, sid_len);
-+    if (!sid_system)
-+        goto done;
-+    RtlInitializeSid(sid_system, &auth, 1);
-+    sid_system->SubAuthority[0] = SECURITY_LOCAL_SYSTEM_RID;
-+
-+    sid_len = SECURITY_DESCRIPTOR_MIN_LENGTH + sizeof(ACL) +
-+            sizeof(ACCESS_ALLOWED_ACE) + RtlLengthSid(sid) +
-+            sizeof(ACCESS_ALLOWED_ACE) + RtlLengthSid(sid_system);
-+
-+    sec_desc = ExAllocatePool(PagedPool, sid_len);
-+    if (!sec_desc)
-+    {
-+        ret = STATUS_NO_MEMORY;
-+        goto done;
-+    }
-+
-+    ret = RtlCreateSecurityDescriptor(sec_desc, SECURITY_DESCRIPTOR_REVISION);
-+    if (ret != STATUS_SUCCESS)
-+        goto done;
-+
-+    dacl = (PACL)((char*)sec_desc + SECURITY_DESCRIPTOR_MIN_LENGTH);
-+    ret = RtlCreateAcl(dacl, sid_len - SECURITY_DESCRIPTOR_MIN_LENGTH, ACL_REVISION);
-+    if (ret != STATUS_SUCCESS)
-+        goto done;
-+
-+    ret = RtlAddAccessAllowedAce(dacl, ACL_REVISION, access, sid);
-+    if (ret != STATUS_SUCCESS)
-+        goto done;
-+
-+    ret = RtlAddAccessAllowedAce(dacl, ACL_REVISION, access, sid_system);
-+    if (ret != STATUS_SUCCESS)
-+        goto done;
-+
-+    ret = RtlSetDaclSecurityDescriptor(sec_desc, 1, dacl, 0);
-+    if (ret == STATUS_SUCCESS)
-+        *descriptor = sec_desc;
-+
-+done:
-+    if (ret != STATUS_SUCCESS)
-+        ExFreePool(sec_desc);
-+
-+    ExFreePool(sid);
-+    ExFreePool(sid_system);
-+
-+    return ret;
-+}
-+
-+void WINAPI FltFreeSecurityDescriptor(PSECURITY_DESCRIPTOR descriptor)
-+{
-+    ExFreePool(descriptor);
-+}
-diff --git a/include/ddk/fltkernel.h b/include/ddk/fltkernel.h
-index 49c9d55dbaa..e5483d5a3fa 100644
---- a/include/ddk/fltkernel.h
-+++ b/include/ddk/fltkernel.h
-@@ -653,7 +653,8 @@ typedef struct _FLT_REGISTRATION
-     PFLT_SECTION_CONFLICT_NOTIFICATION_CALLBACK SectionNotificationCallback;
- } FLT_REGISTRATION, *PFLT_REGISTRATION;
- 
--
-+NTSTATUS WINAPI FltBuildDefaultSecurityDescriptor(PSECURITY_DESCRIPTOR *, ACCESS_MASK);
-+void     WINAPI FltFreeSecurityDescriptor(PSECURITY_DESCRIPTOR);
- void*    WINAPI FltGetRoutineAddress(LPCSTR name);
- NTSTATUS WINAPI FltRegisterFilter(PDRIVER_OBJECT, const FLT_REGISTRATION *, PFLT_FILTER *);
- NTSTATUS WINAPI FltStartFiltering(PFLT_FILTER);
--- 
-2.42.0
-

patches/fltmgr.sys-FltBuildDefaultSecurityDescriptor/0002-fltmgr.sys-Create-import-library.patch

@@ -1,23 +0,0 @@
-From c1af142bac149b296b2dea06cd99c13e0f8814c9 Mon Sep 17 00:00:00 2001
-From: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
-Date: Mon, 30 Aug 2021 15:15:35 +1000
-Subject: [PATCH 2/3] fltmgr.sys: Create import library
-
-Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
----
- dlls/fltmgr.sys/Makefile.in | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/dlls/fltmgr.sys/Makefile.in b/dlls/fltmgr.sys/Makefile.in
-index ae0e812cb22..ae02da9b5d6 100644
---- a/dlls/fltmgr.sys/Makefile.in
-+++ b/dlls/fltmgr.sys/Makefile.in
-@@ -1,4 +1,5 @@
- MODULE    = fltmgr.sys
-+IMPORTLIB = fltmgr
- EXTRADLLFLAGS = -Wl,--subsystem,native
- IMPORTS = ntoskrnl
- 
--- 
-2.42.0
-

patches/fltmgr.sys-FltBuildDefaultSecurityDescriptor/0003-ntoskrnl.exe-Add-FltBuildDefaultSecurityDescriptor-t.patch

@@ -1,133 +0,0 @@
-From c69247afcbd83af223f471342c67bc06deeffda0 Mon Sep 17 00:00:00 2001
-From: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
-Date: Mon, 30 Aug 2021 15:16:06 +1000
-Subject: [PATCH] ntoskrnl.exe: Add FltBuildDefaultSecurityDescriptor test
-
-Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
----
- dlls/ntoskrnl.exe/tests/Makefile.in |  2 +-
- dlls/ntoskrnl.exe/tests/driver.c    | 81 +++++++++++++++++++++++++++++
- 2 files changed, 82 insertions(+), 1 deletion(-)
-
-diff --git a/dlls/ntoskrnl.exe/tests/Makefile.in b/dlls/ntoskrnl.exe/tests/Makefile.in
-index f610df6a947..97dee8b25cf 100644
---- a/dlls/ntoskrnl.exe/tests/Makefile.in
-+++ b/dlls/ntoskrnl.exe/tests/Makefile.in
-@@ -1,7 +1,7 @@
- TESTDLL   = ntoskrnl.exe
- IMPORTS   = advapi32 crypt32 newdev setupapi user32 wintrust ws2_32 hid
- 
--driver_IMPORTS = winecrt0 ntoskrnl hal
-+driver_IMPORTS = winecrt0 ntoskrnl hal fltmgr
- driver_EXTRADLLFLAGS = -nodefaultlibs -nostartfiles -Wl,--subsystem,native
- driver2_IMPORTS = winecrt0 ntoskrnl hal
- driver2_EXTRADLLFLAGS = -nodefaultlibs -nostartfiles -Wl,--subsystem,native
-diff --git a/dlls/ntoskrnl.exe/tests/driver.c b/dlls/ntoskrnl.exe/tests/driver.c
-index ea4bd03ee44..844a181472c 100644
---- a/dlls/ntoskrnl.exe/tests/driver.c
-+++ b/dlls/ntoskrnl.exe/tests/driver.c
-@@ -36,6 +36,7 @@
- #include "ddk/ntddk.h"
- #include "ddk/ntifs.h"
- #include "ddk/wdm.h"
-+#include "ddk/fltkernel.h"
- 
- #include "driver.h"
- 
-@@ -2393,6 +2394,85 @@ static void test_default_modules(void)
-     ok(dxgmms1, "Failed to find dxgmms1.sys\n");
- }
- 
-+static void test_default_security(void)
-+{
-+    PSECURITY_DESCRIPTOR sd = NULL;
-+    NTSTATUS status;
-+    PSID group = NULL, owner = NULL;
-+    BOOLEAN isdefault, present;
-+    PACL acl = NULL;
-+    PACCESS_ALLOWED_ACE ace;
-+    SID_IDENTIFIER_AUTHORITY auth = { SECURITY_NULL_SID_AUTHORITY };
-+    SID_IDENTIFIER_AUTHORITY authwine7 = { SECURITY_NT_AUTHORITY };
-+    PSID sid1, sid2, sidwin7;
-+    BOOL ret;
-+
-+    status = FltBuildDefaultSecurityDescriptor(&sd, STANDARD_RIGHTS_ALL);
-+    ok(status == STATUS_SUCCESS, "got %#lx\n", status);
-+    if (status != STATUS_SUCCESS)
-+    {
-+        win_skip("Skipping FltBuildDefaultSecurityDescriptor tests\n");
-+        return;
-+    }
-+    ok(sd != NULL, "Failed to return descriptor\n");
-+
-+    status = RtlGetGroupSecurityDescriptor(sd, &group, &isdefault);
-+    ok(status == STATUS_SUCCESS, "got %#lx\n", status);
-+    ok(group == NULL, "group isn't NULL\n");
-+
-+    status = RtlGetOwnerSecurityDescriptor(sd, &owner, &isdefault);
-+    ok(status == STATUS_SUCCESS, "got %#lx\n", status);
-+    ok(owner == NULL, "owner isn't NULL\n");
-+
-+    status = RtlGetDaclSecurityDescriptor(sd, &present, &acl, &isdefault);
-+    ok(status == STATUS_SUCCESS, "got %#lx\n", status);
-+    ok(acl != NULL, "acl is NULL\n");
-+    ok(acl->AceCount == 2, "got %d\n", acl->AceCount);
-+
-+    sid1 = ExAllocatePool(NonPagedPool, RtlLengthRequiredSid(2));
-+    status = RtlInitializeSid(sid1, &auth, 2);
-+    ok(status == STATUS_SUCCESS, "got %#lx\n", status);
-+    *RtlSubAuthoritySid(sid1, 0)  = SECURITY_BUILTIN_DOMAIN_RID;
-+    *RtlSubAuthoritySid(sid1, 1) = DOMAIN_GROUP_RID_ADMINS;
-+
-+    sidwin7 = ExAllocatePool(NonPagedPool, RtlLengthRequiredSid(2));
-+    status = RtlInitializeSid(sidwin7, &authwine7, 2);
-+    ok(status == STATUS_SUCCESS, "got %#lx\n", status);
-+    *RtlSubAuthoritySid(sidwin7, 0)  = SECURITY_BUILTIN_DOMAIN_RID;
-+    *RtlSubAuthoritySid(sidwin7, 1) = DOMAIN_ALIAS_RID_ADMINS;
-+
-+    sid2 = ExAllocatePool(NonPagedPool, RtlLengthRequiredSid(1));
-+    RtlInitializeSid(sid2, &auth, 1);
-+    *RtlSubAuthoritySid(sid2, 0)  = SECURITY_LOCAL_SYSTEM_RID;
-+
-+    /* SECURITY_BUILTIN_DOMAIN_RID */
-+    status = RtlGetAce(acl, 0, (void**)&ace);
-+    ok(status == STATUS_SUCCESS, "got %#lx\n", status);
-+
-+    ok(ace->Header.AceType == ACCESS_ALLOWED_ACE_TYPE, "got %#x\n", ace->Header.AceType);
-+    ok(ace->Header.AceFlags == 0, "got %#x\n", ace->Header.AceFlags);
-+    ok(ace->Mask == STANDARD_RIGHTS_ALL, "got %#lx\n", ace->Mask);
-+
-+    ret = RtlEqualSid(sid1, (PSID)&ace->SidStart) || RtlEqualSid(sidwin7, (PSID)&ace->SidStart);
-+    ok(ret, "SID not equal\n");
-+
-+    /* SECURITY_LOCAL_SYSTEM_RID */
-+    status = RtlGetAce(acl, 1, (void**)&ace);
-+    ok(status == STATUS_SUCCESS, "got %#lx\n", status);
-+
-+    ok(ace->Header.AceType == ACCESS_ALLOWED_ACE_TYPE, "got %#x\n", ace->Header.AceType);
-+    ok(ace->Header.AceFlags == 0, "got %#x\n", ace->Header.AceFlags);
-+    ok(ace->Mask == STANDARD_RIGHTS_ALL, "got %#lx\n", ace->Mask);
-+
-+    ret = RtlEqualSid(sid2, (PSID)&ace->SidStart) || RtlEqualSid(sidwin7, (PSID)&ace->SidStart);
-+    ok(ret, "SID not equal\n");
-+
-+    ExFreePool(sid1);
-+    ExFreePool(sid2);
-+
-+    FltFreeSecurityDescriptor(sd);
-+}
-+
- static NTSTATUS main_test(DEVICE_OBJECT *device, IRP *irp, IO_STACK_LOCATION *stack)
- {
-     void *buffer = irp->AssociatedIrp.SystemBuffer;
-@@ -2438,6 +2518,7 @@ static NTSTATUS main_test(DEVICE_OBJECT *device, IRP *irp, IO_STACK_LOCATION *st
-     test_process_memory(test_input);
-     test_permanence();
-     test_driver_object_extension();
-+    test_default_security();
- 
-     IoMarkIrpPending(irp);
-     IoQueueWorkItem(work_item, main_test_task, DelayedWorkQueue, irp);
--- 
-2.42.0
-

patches/fltmgr.sys-FltBuildDefaultSecurityDescriptor/definition

@@ -1,2 +0,0 @@
-Fixes: [49089] fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
-Depends: winedevice-Default_Drivers

patches/kernel32-CopyFileEx/0001-kernel32-Add-support-for-progress-callback-in-CopyFi.patch

@@ -174,7 +174,7 @@ index 7806ad2ec1f..e5adc0d4e2c 100644
 +    basic_info.LastAccessTime = info.LastAccessTime;
 +    basic_info.LastWriteTime = info.LastWriteTime;
 +    basic_info.ChangeTime = info.ChangeTime;
-+    basic_info.FileAttributes &= FILE_ATTRIBUTE_READONLY;
++    basic_info.FileAttributes = info.FileAttributes & FILE_ATTRIBUTE_READONLY;
 +    NtSetInformationFile( h2, &io, &basic_info, sizeof(basic_info), FileBasicInformation );
      HeapFree( GetProcessHeap(), 0, buffer );
      CloseHandle( h1 );

patches/mfplat-streaming-support/0055-winegstreamer-Add-MFVideoFormat_ARGB32-output-for-th.patch

@@ -1,37 +0,0 @@
-From af54761b8536f81831f2813ef0ff9b627dcc5ca4 Mon Sep 17 00:00:00 2001
-From: Nikolay Sivov <nsivov@codeweavers.com>
-Date: Wed, 12 Jan 2022 22:48:35 +0300
-Subject: [PATCH] winegstreamer: Add MFVideoFormat_ARGB32 output for the
- source.
-
-(cherry picked from commit 9812591f0003c5c611faa59ab9b3cb73a85be637)
-
-CW-Bug-Id: #19975
----
- dlls/winegstreamer/media_source.c | 3 ++-
- 1 file changed, 2 insertions(+), 1 deletion(-)
-
-diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c
-index 00c40dc2f47..7a0f65b4247 100644
---- a/dlls/winegstreamer/media_source.c
-+++ b/dlls/winegstreamer/media_source.c
-@@ -856,7 +856,7 @@ static HRESULT new_media_stream(struct media_source *source,
- static HRESULT media_stream_init_desc(struct media_stream *stream)
- {
-     IMFMediaTypeHandler *type_handler = NULL;
--    IMFMediaType *stream_types[6];
-+    IMFMediaType *stream_types[7];
-     struct wg_format format;
-     DWORD type_count = 0;
-     unsigned int i;
-@@ -875,6 +875,7 @@ static HRESULT media_stream_init_desc(struct media_stream *stream)
-             WG_VIDEO_FORMAT_YV12,
-             WG_VIDEO_FORMAT_YUY2,
-             WG_VIDEO_FORMAT_I420,
-+            WG_VIDEO_FORMAT_BGRA,
-         };
- 
-         IMFMediaType *base_type = mf_media_type_from_wg_format(&format);
--- 
-2.40.0
-

patches/ntdll-CriticalSection/0002-ntdll-Add-inline-versions-of-RtlEnterCriticalSection.patch

@@ -1,65 +0,0 @@
-From 49fa193ec777f68372b549752482ef82fb63a7b7 Mon Sep 17 00:00:00 2001
-From: Sebastian Lackner <sebastian@fds-team.de>
-Date: Sat, 5 Aug 2017 03:38:38 +0200
-Subject: [PATCH] ntdll: Add inline versions of RtlEnterCriticalSection /
- RtlLeaveCriticalSections.
-
----
- dlls/ntdll/ntdll_misc.h | 34 ++++++++++++++++++++++++++++++++++
- 1 file changed, 34 insertions(+)
-
-diff --git a/dlls/ntdll/ntdll_misc.h b/dlls/ntdll/ntdll_misc.h
-index 171ded98c67..54a65e3bae5 100644
---- a/dlls/ntdll/ntdll_misc.h
-+++ b/dlls/ntdll/ntdll_misc.h
-@@ -29,6 +29,7 @@
- #include "winternl.h"
- #include "rtlsupportapi.h"
- #include "unixlib.h"
-+#include "wine/debug.h"
- #include "wine/asm.h"
- 
- #define MAX_NT_PATH_LENGTH 277
-@@ -106,6 +107,39 @@ extern void (FASTCALL *pBaseThreadInitThunk)(DWORD,LPTHREAD_START_ROUTINE,void *
- 
- extern struct _KUSER_SHARED_DATA *user_shared_data;
- 
-+/* inline version of RtlEnterCriticalSection */
-+static inline void enter_critical_section( RTL_CRITICAL_SECTION *crit )
-+{
-+    if (InterlockedIncrement( &crit->LockCount ))
-+    {
-+        if (crit->OwningThread == ULongToHandle(GetCurrentThreadId()))
-+        {
-+            crit->RecursionCount++;
-+            return;
-+        }
-+        RtlpWaitForCriticalSection( crit );
-+    }
-+    crit->OwningThread   = ULongToHandle(GetCurrentThreadId());
-+    crit->RecursionCount = 1;
-+}
-+
-+/* inline version of RtlLeaveCriticalSection */
-+static inline void leave_critical_section( RTL_CRITICAL_SECTION *crit )
-+{
-+    WINE_DECLARE_DEBUG_CHANNEL(ntdll);
-+    if (--crit->RecursionCount)
-+    {
-+        if (crit->RecursionCount > 0) InterlockedDecrement( &crit->LockCount );
-+        else ERR_(ntdll)( "section %p is not acquired\n", crit );
-+    }
-+    else
-+    {
-+        crit->OwningThread = 0;
-+        if (InterlockedDecrement( &crit->LockCount ) >= 0)
-+            RtlpUnWaitCriticalSection( crit );
-+    }
-+}
-+
- #ifdef _WIN64
- static inline TEB64 *NtCurrentTeb64(void) { return NULL; }
- #else
--- 
-2.43.0
-

patches/ntdll-CriticalSection/0003-ntdll-Use-fast-CS-functions-for-heap-locking.patch

@@ -1,74 +0,0 @@
-From 85e5938c50ad5a1eebc7ec21d6c01ea7f4faf49d Mon Sep 17 00:00:00 2001
-From: Sebastian Lackner <sebastian@fds-team.de>
-Date: Sat, 5 Aug 2017 03:39:23 +0200
-Subject: [PATCH] ntdll: Use fast CS functions for heap locking.
-
----
- dlls/ntdll/heap.c | 16 ++++++++--------
- 1 file changed, 8 insertions(+), 8 deletions(-)
-
-diff --git a/dlls/ntdll/heap.c b/dlls/ntdll/heap.c
-index cb1ff12c679..757e0246925 100644
---- a/dlls/ntdll/heap.c
-+++ b/dlls/ntdll/heap.c
-@@ -476,13 +476,13 @@ static inline ULONG heap_get_flags( const struct heap *heap, ULONG flags )
- static inline void heap_lock( struct heap *heap, ULONG flags )
- {
-     if (flags & HEAP_NO_SERIALIZE) return;
--    RtlEnterCriticalSection( &heap->cs );
-+    enter_critical_section( &heap->cs );
- }
- 
- static inline void heap_unlock( struct heap *heap, ULONG flags )
- {
-     if (flags & HEAP_NO_SERIALIZE) return;
--    RtlLeaveCriticalSection( &heap->cs );
-+    leave_critical_section( &heap->cs );
- }
- 
- static void heap_set_status( const struct heap *heap, ULONG flags, NTSTATUS status )
-@@ -1392,9 +1392,9 @@ HANDLE WINAPI RtlCreateHeap( ULONG flags, PVOID addr, SIZE_T totalSize, SIZE_T c
-     /* link it into the per-process heap list */
-     if (process_heap)
-     {
--        RtlEnterCriticalSection( &process_heap->cs );
-+        enter_critical_section( &process_heap->cs );
-         list_add_head( &process_heap->entry, &heap->entry );
--        RtlLeaveCriticalSection( &process_heap->cs );
-+        leave_critical_section( &process_heap->cs );
-     }
-     else if (!addr)
-     {
-@@ -1451,9 +1451,9 @@ HANDLE WINAPI RtlDestroyHeap( HANDLE handle )
-     if (heap == process_heap) return handle; /* cannot delete the main process heap */
- 
-     /* remove it from the per-process list */
--    RtlEnterCriticalSection( &process_heap->cs );
-+    enter_critical_section( &process_heap->cs );
-     list_remove( &heap->entry );
--    RtlLeaveCriticalSection( &process_heap->cs );
-+    leave_critical_section( &process_heap->cs );
- 
-     heap->cs.DebugInfo->Spare[0] = 0;
-     RtlDeleteCriticalSection( &heap->cs );
-@@ -1968,7 +1968,7 @@ ULONG WINAPI RtlGetProcessHeaps( ULONG count, HANDLE *heaps )
-     ULONG total = 1;  /* main heap */
-     struct list *ptr;
- 
--    RtlEnterCriticalSection( &process_heap->cs );
-+    enter_critical_section( &process_heap->cs );
-     LIST_FOR_EACH( ptr, &process_heap->entry ) total++;
-     if (total <= count)
-     {
-@@ -1976,7 +1976,7 @@ ULONG WINAPI RtlGetProcessHeaps( ULONG count, HANDLE *heaps )
-         LIST_FOR_EACH( ptr, &process_heap->entry )
-             *heaps++ = LIST_ENTRY( ptr, struct heap, entry );
-     }
--    RtlLeaveCriticalSection( &process_heap->cs );
-+    leave_critical_section( &process_heap->cs );
-     return total;
- }
- 
--- 
-2.38.1
-

patches/ntdll-CriticalSection/0004-ntdll-Use-fast-CS-functions-for-threadpool-locking.patch

@@ -1,396 +0,0 @@
-From 6d5610f8950d0319dbec724ef4d1f0ed140a97ec Mon Sep 17 00:00:00 2001
-From: Sebastian Lackner <sebastian@fds-team.de>
-Date: Sat, 5 Aug 2017 03:39:37 +0200
-Subject: [PATCH] ntdll: Use fast CS functions for threadpool locking.
-
----
- dlls/ntdll/threadpool.c | 90 ++++++++++++++++++++---------------------
- 1 file changed, 45 insertions(+), 45 deletions(-)
-
-diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c
-index 99525f831e1..36d1351aedc 100644
---- a/dlls/ntdll/threadpool.c
-+++ b/dlls/ntdll/threadpool.c
-@@ -1063,7 +1063,7 @@ static void CALLBACK timerqueue_thread_proc( void *param )
-     TRACE( "starting timer queue thread\n" );
-     set_thread_name(L"wine_threadpool_timerqueue");
- 
--    RtlEnterCriticalSection( &timerqueue.cs );
-+    enter_critical_section( &timerqueue.cs );
-     for (;;)
-     {
-         NtQuerySystemTime( &now );
-@@ -1136,7 +1136,7 @@ static void CALLBACK timerqueue_thread_proc( void *param )
-     }
- 
-     timerqueue.thread_running = FALSE;
--    RtlLeaveCriticalSection( &timerqueue.cs );
-+    leave_critical_section( &timerqueue.cs );
- 
-     TRACE( "terminating timer queue thread\n" );
-     RtlExitUserThread( 0 );
-@@ -1181,7 +1181,7 @@ static NTSTATUS tp_timerqueue_lock( struct threadpool_object *timer )
-     timer->u.timer.period               = 0;
-     timer->u.timer.window_length        = 0;
- 
--    RtlEnterCriticalSection( &timerqueue.cs );
-+    enter_critical_section( &timerqueue.cs );
- 
-     /* Make sure that the timerqueue thread is running. */
-     if (!timerqueue.thread_running)
-@@ -1202,7 +1202,7 @@ static NTSTATUS tp_timerqueue_lock( struct threadpool_object *timer )
-         timerqueue.objcount++;
-     }
- 
--    RtlLeaveCriticalSection( &timerqueue.cs );
-+    leave_critical_section( &timerqueue.cs );
-     return status;
- }
- 
-@@ -1215,7 +1215,7 @@ static void tp_timerqueue_unlock( struct threadpool_object *timer )
- {
-     assert( timer->type == TP_OBJECT_TYPE_TIMER );
- 
--    RtlEnterCriticalSection( &timerqueue.cs );
-+    enter_critical_section( &timerqueue.cs );
-     if (timer->u.timer.timer_initialized)
-     {
-         /* If timer was pending, remove it. */
-@@ -1234,7 +1234,7 @@ static void tp_timerqueue_unlock( struct threadpool_object *timer )
- 
-         timer->u.timer.timer_initialized = FALSE;
-     }
--    RtlLeaveCriticalSection( &timerqueue.cs );
-+    leave_critical_section( &timerqueue.cs );
- }
- 
- /***********************************************************************
-@@ -1253,7 +1253,7 @@ static void CALLBACK waitqueue_thread_proc( void *param )
-     TRACE( "starting wait queue thread\n" );
-     set_thread_name(L"wine_threadpool_waitqueue");
- 
--    RtlEnterCriticalSection( &waitqueue.cs );
-+    enter_critical_section( &waitqueue.cs );
- 
-     for (;;)
-     {
-@@ -1302,10 +1302,10 @@ static void CALLBACK waitqueue_thread_proc( void *param )
-             /* All wait objects have been destroyed, if no new wait objects are created
-              * within some amount of time, then we can shutdown this thread. */
-             assert( num_handles == 0 );
--            RtlLeaveCriticalSection( &waitqueue.cs );
-+            leave_critical_section( &waitqueue.cs );
-             timeout.QuadPart = (ULONGLONG)THREADPOOL_WORKER_TIMEOUT * -10000;
-             status = NtWaitForMultipleObjects( 1, &bucket->update_event, TRUE, bucket->alertable, &timeout );
--            RtlEnterCriticalSection( &waitqueue.cs );
-+            enter_critical_section( &waitqueue.cs );
- 
-             if (status == STATUS_TIMEOUT && !bucket->objcount)
-                 break;
-@@ -1315,7 +1315,7 @@ static void CALLBACK waitqueue_thread_proc( void *param )
-             handles[num_handles] = bucket->update_event;
-             RtlLeaveCriticalSection( &waitqueue.cs );
-             status = NtWaitForMultipleObjects( num_handles + 1, handles, TRUE, bucket->alertable, &timeout );
--            RtlEnterCriticalSection( &waitqueue.cs );
-+            enter_critical_section( &waitqueue.cs );
- 
-             if (status >= STATUS_WAIT_0 && status < STATUS_WAIT_0 + num_handles)
-             {
-@@ -1399,7 +1399,7 @@ static void CALLBACK waitqueue_thread_proc( void *param )
-     if (!--waitqueue.num_buckets)
-         assert( list_empty( &waitqueue.buckets ) );
- 
--    RtlLeaveCriticalSection( &waitqueue.cs );
-+    leave_critical_section( &waitqueue.cs );
- 
-     TRACE( "terminating wait queue thread\n" );
- 
-@@ -1429,7 +1429,7 @@ static NTSTATUS tp_waitqueue_lock( struct threadpool_object *wait )
-     wait->u.wait.timeout        = 0;
-     wait->u.wait.handle         = INVALID_HANDLE_VALUE;
- 
--    RtlEnterCriticalSection( &waitqueue.cs );
-+    enter_critical_section( &waitqueue.cs );
- 
-     /* Try to assign to existing bucket if possible. */
-     LIST_FOR_EACH_ENTRY( bucket, &waitqueue.buckets, struct waitqueue_bucket, bucket_entry )
-@@ -1486,7 +1486,7 @@ static NTSTATUS tp_waitqueue_lock( struct threadpool_object *wait )
-     }
- 
- out:
--    RtlLeaveCriticalSection( &waitqueue.cs );
-+    leave_critical_section( &waitqueue.cs );
-     return status;
- }
- 
-@@ -1497,7 +1497,7 @@ static void tp_waitqueue_unlock( struct threadpool_object *wait )
- {
-     assert( wait->type == TP_OBJECT_TYPE_WAIT );
- 
--    RtlEnterCriticalSection( &waitqueue.cs );
-+    enter_critical_section( &waitqueue.cs );
-     if (wait->u.wait.bucket)
-     {
-         struct waitqueue_bucket *bucket = wait->u.wait.bucket;
-@@ -1509,7 +1509,7 @@ static void tp_waitqueue_unlock( struct threadpool_object *wait )
- 
-         NtSetEvent( bucket->update_event, NULL );
-     }
--    RtlLeaveCriticalSection( &waitqueue.cs );
-+    leave_critical_section( &waitqueue.cs );
- }
- 
- static void CALLBACK ioqueue_thread_proc( void *param )
-@@ -1787,7 +1787,7 @@ static NTSTATUS tp_threadpool_lock( struct threadpool **out, TP_CALLBACK_ENVIRON
-         pool = default_threadpool;
-     }
- 
--    RtlEnterCriticalSection( &pool->cs );
-+    enter_critical_section( &pool->cs );
- 
-     /* Make sure that the threadpool has at least one thread. */
-     if (!pool->num_workers)
-@@ -1801,7 +1801,7 @@ static NTSTATUS tp_threadpool_lock( struct threadpool **out, TP_CALLBACK_ENVIRON
-         pool->objcount++;
-     }
- 
--    RtlLeaveCriticalSection( &pool->cs );
-+    leave_critical_section( &pool->cs );
- 
-     if (status != STATUS_SUCCESS)
-         return status;
-@@ -1817,9 +1817,9 @@ static NTSTATUS tp_threadpool_lock( struct threadpool **out, TP_CALLBACK_ENVIRON
-  */
- static void tp_threadpool_unlock( struct threadpool *pool )
- {
--    RtlEnterCriticalSection( &pool->cs );
-+    enter_critical_section( &pool->cs );
-     pool->objcount--;
--    RtlLeaveCriticalSection( &pool->cs );
-+    leave_critical_section( &pool->cs );
-     tp_threadpool_release( pool );
- }
- 
-@@ -1957,10 +1957,10 @@ static void tp_object_initialize( struct threadpool_object *object, struct threa
-         struct threadpool_group *group = object->group;
-         InterlockedIncrement( &group->refcount );
- 
--        RtlEnterCriticalSection( &group->cs );
-+        enter_critical_section( &group->cs );
-         list_add_tail( &group->members, &object->group_entry );
-         object->is_group_member = TRUE;
--        RtlLeaveCriticalSection( &group->cs );
-+        leave_critical_section( &group->cs );
-     }
- 
-     if (is_simple_callback)
-@@ -1987,7 +1987,7 @@ static void tp_object_submit( struct threadpool_object *object, BOOL signaled )
-     assert( !object->shutdown );
-     assert( !pool->shutdown );
- 
--    RtlEnterCriticalSection( &pool->cs );
-+    enter_critical_section( &pool->cs );
- 
-     /* Start new worker threads if required. */
-     if (pool->num_busy_workers >= pool->num_workers &&
-@@ -2010,7 +2010,7 @@ static void tp_object_submit( struct threadpool_object *object, BOOL signaled )
-         RtlWakeConditionVariable( &pool->update_event );
-     }
- 
--    RtlLeaveCriticalSection( &pool->cs );
-+    leave_critical_section( &pool->cs );
- }
- 
- /***********************************************************************
-@@ -2023,7 +2023,7 @@ static void tp_object_cancel( struct threadpool_object *object )
-     struct threadpool *pool = object->pool;
-     LONG pending_callbacks = 0;
- 
--    RtlEnterCriticalSection( &pool->cs );
-+    enter_critical_section( &pool->cs );
-     if (object->num_pending_callbacks)
-     {
-         pending_callbacks = object->num_pending_callbacks;
-@@ -2038,7 +2038,7 @@ static void tp_object_cancel( struct threadpool_object *object )
-         object->u.io.skipped_count += object->u.io.pending_count;
-         object->u.io.pending_count = 0;
-     }
--    RtlLeaveCriticalSection( &pool->cs );
-+    leave_critical_section( &pool->cs );
- 
-     while (pending_callbacks--)
-         tp_object_release( object );
-@@ -2067,7 +2067,7 @@ static void tp_object_wait( struct threadpool_object *object, BOOL group_wait )
- {
-     struct threadpool *pool = object->pool;
- 
--    RtlEnterCriticalSection( &pool->cs );
-+    enter_critical_section( &pool->cs );
-     while (!object_is_finished( object, group_wait ))
-     {
-         if (group_wait)
-@@ -2075,7 +2075,7 @@ static void tp_object_wait( struct threadpool_object *object, BOOL group_wait )
-         else
-             RtlSleepConditionVariableCS( &object->finished_event, &pool->cs, NULL );
-     }
--    RtlLeaveCriticalSection( &pool->cs );
-+    leave_critical_section( &pool->cs );
- }
- 
- static void tp_ioqueue_unlock( struct threadpool_object *io )
-@@ -2129,13 +2129,13 @@ static BOOL tp_object_release( struct threadpool_object *object )
-     {
-         struct threadpool_group *group = object->group;
- 
--        RtlEnterCriticalSection( &group->cs );
-+        enter_critical_section( &group->cs );
-         if (object->is_group_member)
-         {
-             list_remove( &object->group_entry );
-             object->is_group_member = FALSE;
-         }
--        RtlLeaveCriticalSection( &group->cs );
-+        leave_critical_section( &group->cs );
- 
-         tp_group_release( group );
-     }
-@@ -2337,7 +2337,7 @@ static void CALLBACK threadpool_worker_proc( void *param )
-     TRACE( "starting worker thread for pool %p\n", pool );
-     set_thread_name(L"wine_threadpool_worker");
- 
--    RtlEnterCriticalSection( &pool->cs );
-+    enter_critical_section( &pool->cs );
-     for (;;)
-     {
-         while ((ptr = threadpool_get_next_item( pool )))
-@@ -2377,7 +2377,7 @@ static void CALLBACK threadpool_worker_proc( void *param )
-         }
-     }
-     pool->num_workers--;
--    RtlLeaveCriticalSection( &pool->cs );
-+    leave_critical_section( &pool->cs );
- 
-     TRACE( "terminating worker thread for pool %p\n", pool );
-     tp_threadpool_release( pool );
-@@ -2625,7 +2625,7 @@ NTSTATUS WINAPI TpCallbackMayRunLong( TP_CALLBACK_INSTANCE *instance )
-         return STATUS_SUCCESS;
- 
-     pool = object->pool;
--    RtlEnterCriticalSection( &pool->cs );
-+    enter_critical_section( &pool->cs );
- 
-     /* Start new worker threads if required. */
-     if (pool->num_busy_workers >= pool->num_workers)
-@@ -2640,7 +2640,7 @@ NTSTATUS WINAPI TpCallbackMayRunLong( TP_CALLBACK_INSTANCE *instance )
-         }
-     }
- 
--    RtlLeaveCriticalSection( &pool->cs );
-+    leave_critical_section( &pool->cs );
-     this->may_run_long = TRUE;
-     return status;
- }
-@@ -2721,13 +2721,13 @@ VOID WINAPI TpDisassociateCallback( TP_CALLBACK_INSTANCE *instance )
-         return;
- 
-     pool = object->pool;
--    RtlEnterCriticalSection( &pool->cs );
-+    enter_critical_section( &pool->cs );
- 
-     object->num_associated_callbacks--;
-     if (object_is_finished( object, FALSE ))
-         RtlWakeAllConditionVariable( &object->finished_event );
- 
--    RtlLeaveCriticalSection( &pool->cs );
-+    leave_critical_section( &pool->cs );
-     this->associated = FALSE;
- }
- 
-@@ -2779,7 +2779,7 @@ VOID WINAPI TpReleaseCleanupGroupMembers( TP_CLEANUP_GROUP *group, BOOL cancel_p
- 
-     TRACE( "%p %u %p\n", group, cancel_pending, userdata );
- 
--    RtlEnterCriticalSection( &this->cs );
-+    enter_critical_section( &this->cs );
- 
-     /* Unset group, increase references, and mark objects for shutdown */
-     LIST_FOR_EACH_ENTRY_SAFE( object, next, &this->members, struct threadpool_object, group_entry )
-@@ -2805,7 +2805,7 @@ VOID WINAPI TpReleaseCleanupGroupMembers( TP_CLEANUP_GROUP *group, BOOL cancel_p
-     list_init( &members );
-     list_move_tail( &members, &this->members );
- 
--    RtlLeaveCriticalSection( &this->cs );
-+    leave_critical_section( &this->cs );
- 
-     /* Cancel pending callbacks if requested */
-     if (cancel_pending)
-@@ -2928,10 +2928,10 @@ VOID WINAPI TpSetPoolMaxThreads( TP_POOL *pool, DWORD maximum )
- 
-     TRACE( "%p %lu\n", pool, maximum );
- 
--    RtlEnterCriticalSection( &this->cs );
-+    enter_critical_section( &this->cs );
-     this->max_workers = max( maximum, 1 );
-     this->min_workers = min( this->min_workers, this->max_workers );
--    RtlLeaveCriticalSection( &this->cs );
-+    leave_critical_section( &this->cs );
- }
- 
- /***********************************************************************
-@@ -2944,7 +2944,7 @@ BOOL WINAPI TpSetPoolMinThreads( TP_POOL *pool, DWORD minimum )
- 
-     TRACE( "%p %lu\n", pool, minimum );
- 
--    RtlEnterCriticalSection( &this->cs );
-+    enter_critical_section( &this->cs );
- 
-     while (this->num_workers < minimum)
-     {
-@@ -2959,7 +2959,7 @@ BOOL WINAPI TpSetPoolMinThreads( TP_POOL *pool, DWORD minimum )
-         this->max_workers = max( this->min_workers, this->max_workers );
-     }
- 
--    RtlLeaveCriticalSection( &this->cs );
-+    leave_critical_section( &this->cs );
-     return !status;
- }
- 
-@@ -2975,7 +2975,7 @@ VOID WINAPI TpSetTimer( TP_TIMER *timer, LARGE_INTEGER *timeout, LONG period, LO
- 
-     TRACE( "%p %p %lu %lu\n", timer, timeout, period, window_length );
- 
--    RtlEnterCriticalSection( &timerqueue.cs );
-+    enter_critical_section( &timerqueue.cs );
- 
-     assert( this->u.timer.timer_initialized );
-     this->u.timer.timer_set = timeout != NULL;
-@@ -3035,7 +3035,7 @@ VOID WINAPI TpSetTimer( TP_TIMER *timer, LARGE_INTEGER *timeout, LONG period, LO
-         this->u.timer.timer_pending = TRUE;
-     }
- 
--    RtlLeaveCriticalSection( &timerqueue.cs );
-+    leave_critical_section( &timerqueue.cs );
- 
-     if (submit_timer)
-        tp_object_submit( this, FALSE );
-@@ -3051,7 +3051,7 @@ VOID WINAPI TpSetWait( TP_WAIT *wait, HANDLE handle, LARGE_INTEGER *timeout )
- 
-     TRACE( "%p %p %p\n", wait, handle, timeout );
- 
--    RtlEnterCriticalSection( &waitqueue.cs );
-+    enter_critical_section( &waitqueue.cs );
- 
-     assert( this->u.wait.bucket );
-     this->u.wait.handle = handle;
-@@ -3090,7 +3090,7 @@ VOID WINAPI TpSetWait( TP_WAIT *wait, HANDLE handle, LARGE_INTEGER *timeout )
-         NtSetEvent( bucket->update_event, NULL );
-     }
- 
--    RtlLeaveCriticalSection( &waitqueue.cs );
-+    leave_critical_section( &waitqueue.cs );
- }
- 
- /***********************************************************************
--- 
-2.38.1
-

patches/ntdll-Junction_Points/0026-Return-correct-status-value-if-handle-is-not-a-repar.patch

@@ -0,0 +1,51 @@
+From 246a50e7cf09bd1d77d327e170c2d7432e0d5f5e Mon Sep 17 00:00:00 2001
+From: Lorenzo Ferrillo <lorenzofersteam@live.it>
+Date: Mon, 6 May 2024 23:46:44 +0200
+Subject: [PATCH] Return correct status value if handle is not a reparse point
+
+---
+ dlls/ntdll/unix/file.c | 19 ++++++++++++++-----
+ 1 file changed, 14 insertions(+), 5 deletions(-)
+
+diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c
+index 2bfb9b7d051..93732543ae4 100644
+--- a/dlls/ntdll/unix/file.c
++++ b/dlls/ntdll/unix/file.c
+@@ -3944,9 +3944,11 @@ NTSTATUS get_reparse_point_unix(const char *unix_name, REPARSE_DATA_BUFFER *buff
+     char *p;
+ 
+     ret = readlink( unix_name, link_path, sizeof(link_path) );
++
+     if (ret < 0)
+     {
+-        status = errno_to_status( errno );
++        if (errno == EINVAL) status = STATUS_NOT_A_REPARSE_POINT;
++        else status = errno_to_status( errno );
+         goto cleanup;
+     }
+     link_path_len = ret;
+@@ -7303,10 +7305,17 @@ NTSTATUS WINAPI NtFsControlFile( HANDLE handle, HANDLE event, PIO_APC_ROUTINE ap
+     }
+     case FSCTL_GET_REPARSE_POINT:
+     {
+-        REPARSE_DATA_BUFFER *buffer = (REPARSE_DATA_BUFFER *)out_buffer;
+-        ULONG size = out_size;
+-        status = get_reparse_point( handle, buffer, &size );
+-        io->Information = size;
++        io->Information = 0;
++        if (out_buffer){
++            REPARSE_DATA_BUFFER *buffer = (REPARSE_DATA_BUFFER *)out_buffer;
++            ULONG size = out_size;
++            status = get_reparse_point( handle, buffer, &size );
++            if (status == STATUS_SUCCESS)
++                io->Information = size;
++        }
++        else {
++            status = STATUS_INVALID_USER_BUFFER;
++        }
+         break;
+     }
+     case FSCTL_SET_REPARSE_POINT:
+-- 
+2.43.0
+