mirror of
https://gitlab.winehq.org/wine/vkd3d.git
synced 2025-04-13 05:43:18 -07:00
e91c07e1de
When a shader fails to compile for a range of versions, we want to validate that we are correctly implementing that behaviour. E.g. if a feature requires shader model 5.0, we should validate that it compiles correctly with 5.0 (which we do), but also that it *fails* to compile with 4.1 (which we do not). The obvious and simple solution is to simply run compile tests for each version. There are, however, at least 12 versions of HLSL up to and including 6.0, at least 10 of which are known to introduce new features. Shader compilation takes about 10-15% of the time that draw and dispatch does, both for native and (currently) vkd3d. Testing every version for every shader would add a noticeable amount of time to the tests. In practice, the interesting versions to test for most shaders are: * At least one from each range 1-3, 4-5, and 6. It's common enough for the semantics of the HLSL to differ between bytecode formats, or for features to be added or removed across those boundaries. * If the shader requires a given feature, we want to test both sides of the cusp to ensure we're requiring the same version for the feature. In practice this is 3 or 4 versions, which is measurably less than the 12 we'd otherwise be running. In order to achieve this goal of testing only the 3 or 4 interesting versions for a shader, we need to know what version is actually required for a feature. This is encoded in the shader itself using e.g. [pixel shader fail(sm<5)]. This patch therefore implements the first step towards this goal, namely, determining which versions succeed and fail, so we can figure out which ones are interesting. We could require the test writer to specify which versions are interesting ahead of time (e.g. "for version in 2.0 4.1 5.0 6.0") but this is both redundant (and there are a *lot* of tests that need some feature gate) and easy for a test writer to get wrong by missing interesting versions.