vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_mod().

This commit is contained in:
Zebediah Figura 2022-11-11 18:53:33 -06:00 committed by Alexandre Julliard
parent c8b7dbebe4
commit ad0ab664d2
Notes: Alexandre Julliard 2023-05-26 22:17:06 +02:00
Approved-by: Giovanni Mascellani (@giomasce)
Approved-by: Henri Verbeet (@hverbeet)
Approved-by: Alexandre Julliard (@julliard)
Merge-Request: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/210

View File

@ -362,44 +362,43 @@ static bool fold_div(struct hlsl_ctx *ctx, struct hlsl_constant_value *dst, cons
return true; return true;
} }
static bool fold_mod(struct hlsl_ctx *ctx, struct hlsl_ir_constant *dst, static bool fold_mod(struct hlsl_ctx *ctx, struct hlsl_constant_value *dst, const struct hlsl_type *dst_type,
struct hlsl_ir_constant *src1, struct hlsl_ir_constant *src2) const struct hlsl_ir_constant *src1, const struct hlsl_ir_constant *src2,
const struct vkd3d_shader_location *loc)
{ {
enum hlsl_base_type type = dst->node.data_type->base_type; enum hlsl_base_type type = dst_type->base_type;
unsigned int k; unsigned int k;
assert(type == src1->node.data_type->base_type); assert(type == src1->node.data_type->base_type);
assert(type == src2->node.data_type->base_type); assert(type == src2->node.data_type->base_type);
for (k = 0; k < dst->node.data_type->dimx; ++k) for (k = 0; k < dst_type->dimx; ++k)
{ {
switch (type) switch (type)
{ {
case HLSL_TYPE_INT: case HLSL_TYPE_INT:
if (src2->value.u[k].i == 0) if (src2->value.u[k].i == 0)
{ {
hlsl_error(ctx, &dst->node.loc, VKD3D_SHADER_ERROR_HLSL_DIVISION_BY_ZERO, hlsl_error(ctx, loc, VKD3D_SHADER_ERROR_HLSL_DIVISION_BY_ZERO, "Division by zero.");
"Division by zero.");
return false; return false;
} }
if (src1->value.u[k].i == INT_MIN && src2->value.u[k].i == -1) if (src1->value.u[k].i == INT_MIN && src2->value.u[k].i == -1)
dst->value.u[k].i = 0; dst->u[k].i = 0;
else else
dst->value.u[k].i = src1->value.u[k].i % src2->value.u[k].i; dst->u[k].i = src1->value.u[k].i % src2->value.u[k].i;
break; break;
case HLSL_TYPE_UINT: case HLSL_TYPE_UINT:
if (src2->value.u[k].u == 0) if (src2->value.u[k].u == 0)
{ {
hlsl_error(ctx, &dst->node.loc, VKD3D_SHADER_ERROR_HLSL_DIVISION_BY_ZERO, hlsl_error(ctx, loc, VKD3D_SHADER_ERROR_HLSL_DIVISION_BY_ZERO, "Division by zero.");
"Division by zero.");
return false; return false;
} }
dst->value.u[k].u = src1->value.u[k].u % src2->value.u[k].u; dst->u[k].u = src1->value.u[k].u % src2->value.u[k].u;
break; break;
default: default:
FIXME("Fold modulus for type %s.\n", debug_hlsl_type(ctx, dst->node.data_type)); FIXME("Fold modulus for type %s.\n", debug_hlsl_type(ctx, dst_type));
return false; return false;
} }
} }
@ -605,7 +604,7 @@ bool hlsl_fold_constant_exprs(struct hlsl_ctx *ctx, struct hlsl_ir_node *instr,
break; break;
case HLSL_OP2_MOD: case HLSL_OP2_MOD:
success = fold_mod(ctx, res, arg1, arg2); success = fold_mod(ctx, &res->value, instr->data_type, arg1, arg2, &instr->loc);
break; break;
case HLSL_OP2_MAX: case HLSL_OP2_MAX: