wine/vkd3d
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/vkd3d.git synced 2024-11-21 16:46:41 -08:00
Code Issues Packages Projects Releases Wiki Activity

tests: Mark a conditional rendering test as buggy on llvmpipe.

Browse Source 
Similarly to RADV, this is a kind of perverted situation: in
principle Vulkan doesn't allow vkCmdResolveImage() to be
executed conditionally (i.e., it is unaffected by conditional
execution), which means that vkd3d cannot implement conditional
rendering for ResolveSubresource(), hence the todo. However,
like RADV, llvmpipe apparently violates the specification and
still executes the image resolution command conditionally. So
that's a llvmpipe bug, even if one that helps us doing the right
thing.
This commit is contained in:
Giovanni Mascellani 2024-11-12 22:20:06 +01:00 committed by Henri Verbeet
parent 92fa68cb07
commit 4c9821e5d5
Notes: Henri Verbeet 2024-11-13 16:31:15 +01:00 
Approved-by: Giovanni Mascellani (@giomasce)
Approved-by: Henri Verbeet (@hverbeet)
Merge-Request: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1259
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/d3d12.c
View File

@ -35701,7 +35701,7 @@ static void test_conditional_rendering(void)
D3D12_RESOURCE_STATE_RESOLVE_DEST, D3D12_RESOURCE_STATE_COPY_SOURCE); D3D12_RESOURCE_STATE_RESOLVE_DEST, D3D12_RESOURCE_STATE_COPY_SOURCE);
get_resource_readback_with_command_list(texture_copy, 0, &rb, queue, command_list); get_resource_readback_with_command_list(texture_copy, 0, &rb, queue, command_list);
bug_if(is_radv_device(context.device)) bug_if(is_radv_device(context.device) || is_llvmpipe_device(context.device))
todo check_readback_data_uint(&rb.rb, NULL, r8g8b8a8_data[1], 0); todo check_readback_data_uint(&rb.rb, NULL, r8g8b8a8_data[1], 0);
release_resource_readback(&rb); release_resource_readback(&rb);