From 4c9821e5d53932d856d80237003c1b35ecef63ad Mon Sep 17 00:00:00 2001 From: Giovanni Mascellani Date: Tue, 12 Nov 2024 22:20:06 +0100 Subject: [PATCH] tests: Mark a conditional rendering test as buggy on llvmpipe. Similarly to RADV, this is a kind of perverted situation: in principle Vulkan doesn't allow vkCmdResolveImage() to be executed conditionally (i.e., it is unaffected by conditional execution), which means that vkd3d cannot implement conditional rendering for ResolveSubresource(), hence the todo. However, like RADV, llvmpipe apparently violates the specification and still executes the image resolution command conditionally. So that's a llvmpipe bug, even if one that helps us doing the right thing. --- tests/d3d12.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/d3d12.c b/tests/d3d12.c index e164dab6..54d1efa3 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -35701,7 +35701,7 @@ static void test_conditional_rendering(void) D3D12_RESOURCE_STATE_RESOLVE_DEST, D3D12_RESOURCE_STATE_COPY_SOURCE); get_resource_readback_with_command_list(texture_copy, 0, &rb, queue, command_list); - bug_if(is_radv_device(context.device)) + bug_if(is_radv_device(context.device) || is_llvmpipe_device(context.device)) todo check_readback_data_uint(&rb.rb, NULL, r8g8b8a8_data[1], 0); release_resource_readback(&rb);