wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity
96b58d1f07
gecko/layout/style
History
Brian Birtles 96b58d1f07 Bug 1048838 - Properly invalidate the style rule in nsTransitionManager::StyleContextChanged. r=dbaron 
This patch fixes a regression from
https://hg.mozilla.org/mozilla-central/rev/31695984cfe2 (bug 1025709). That
patch replaced the EnsureStyleRuleFor method on ElementTransitions and
ElementAnimations with a common method in CommonElementAnimationData.

ElementTransitions::EnsureStyleRuleFor would create a new style rule if
there was no style rule (mStyleRule == nullptr) or if the refresh time was
old (mStyleRuleRefreshTime != aRefreshTime).

ElementAnimations::EnsureStyleRuleFor, however, would create a new style rule
only if mStyleRuleRefreshTime was null or old since a null style rule may
still be valid for animations (unlike transitions). If we bail as soon as we
a null style rule we would never update mNeedsRefreshes when the animation
finishes.

The unified version of EnsureStyleRuleFor in CommonElementAnimationData
adopted the behavior from ElementAnimations checking for a null or old
mStyleRuleRefreshTime.

However, nsTransitionManager::StyleContextChanged sets mStyleRule to nullptr
to indicate that we need to generate a new style rule. This means that we
will fail to create a style rule for the transition in some cases.

This patch addresses this by making nsTransitionManager::StyleContextChanged
set mStyleRuleRefreshTime to a null timestamp. Setting mStyleRule to nullptr
is no longer necessary since EnsureStyleRuleFor will do this when necessary
and nsTransitionManager::mStyleRule is only used after calling
EnsureStyleRuleFor.
2014-08-12 16:57:21 +09:00
..
crashtests Bug 972199 followup - use crashtest manifest rather than setBoolPref so that all later crashtests aren't affected by the pref change. No review. 2014-08-06 22:58:43 -07:00
test Bug 975744 - remove font features pref and enable features by default. r=dbaron 2014-08-20 16:54:35 +09:00
xbl-marquee Bug 1050049 - Whitelist bindings that we actually expect to use in content. r=smaug 2014-08-11 20:06:55 -07:00
AnimationCommon.cpp Bug 1040543 part 10 - Move mIsLastNotification from AnimationPlayer to Animation; r=bz 2014-08-10 17:06:51 +10:00
AnimationCommon.h Bug 1055519 - Fix some more bad implicit constructors in layout and widget; r=roc 2014-08-20 00:58:22 -04:00
arrow.gif
arrowd.gif
contenteditable.css
CounterStyleManager.cpp Bug 1028512 - Remove {lower,upper}-{roman,alpha} from CSS keywords. r=jfkthame 2014-06-22 13:28:51 +01:00
CounterStyleManager.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
counterstyles.css Bug 985825 - Unprefix -moz-ethiopic-numeric. r=jfkthame 2014-06-13 17:37:00 +02:00
CSS.cpp
CSS.h
CSSCalc.h
CSSRuleList.cpp Bug 995901 - Rename nsICSSRuleList to mozilla::dom::CSSRuleList. r=bz 2014-06-09 22:11:00 -04:00
CSSRuleList.h Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
CSSStyleSheet.cpp Bug 1032118 - Remove the nsresult return value from nsMediaList::SetStyleSheet; r=dbaron 2014-07-02 12:53:41 +02:00
CSSStyleSheet.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
CSSValue.h Bug 985336: Remove unnecessary #includes from headers in layout/style. r=dbaron 2014-05-09 08:23:14 -07:00
CSSVariableDeclarations.cpp
CSSVariableDeclarations.h Bug 1026535 - Fix mismatched class/struct tags. r=ehsan 2014-06-18 17:57:51 -07:00
CSSVariableResolver.cpp Bug 1039151 - Replace space-wasting use of DebugOnly<> in CSSVariableResolver with #ifdef DEBUG. r=dbaron 2014-07-16 15:24:04 +10:00
CSSVariableResolver.h Bug 1039151 - Replace space-wasting use of DebugOnly<> in CSSVariableResolver with #ifdef DEBUG. r=dbaron 2014-07-16 15:24:04 +10:00
CSSVariableValues.cpp
CSSVariableValues.h Bug 985838 - Change custom property name prefix from "var-" to "--" and allow identifiers to begin with "--". r=dbaron 2014-04-02 14:32:16 +11:00
Declaration.cpp Bug 975744 - remove font features pref and enable features by default. r=dbaron 2014-08-20 16:54:35 +09:00
Declaration.h Bug 985838 - Change custom property name prefix from "var-" to "--" and allow identifiers to begin with "--". r=dbaron 2014-04-02 14:32:16 +11:00
designmode.css
ErrorReporter.cpp Backout revision 308e51eae10c for build bustage. 2014-06-20 13:00:08 +02:00
ErrorReporter.h Backout revision 308e51eae10c for build bustage. 2014-06-20 13:00:08 +02:00
forms.css Bug 1021913: Explicitly give the textfield in input[type="number"] a min-width of 0, so that "min-width:auto" won't block it from shrinking. r=jwatt 2014-06-11 15:35:18 -07:00
full-screen-override.css Bug 1050845 - Add will-change: auto to full-screen-override.css; r=dbaron 2014-08-08 20:25:21 -04:00
generate-stylestructlist.py
GroupRule.h Bug 591303 - Part 3: Set line and column number for all rules in nsCSSParser. r=bz 2014-07-14 15:57:54 -07:00
html.css
ImageDocument.css
ImageLoader.cpp
ImageLoader.h Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
ImportRule.h Bug 591303 - Part 3: Set line and column number for all rules in nsCSSParser. r=bz 2014-07-14 15:57:54 -07:00
jar.mn Bug 966166 - Part 4: Rewrite some builtin counter styles. r=dbaron 2014-06-11 21:12:00 -04:00
Loader.cpp Bug 1044181: style loader now annotates classified tracking nodes r=dbaron 2014-08-08 15:16:34 -07:00
Loader.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
Makefile.in
MediaQueryList.cpp Bug 991742 part 8. Remove the "aScope" argument of WebIDL/nsWrapperCache WrapObject() methods. r=bholley 2014-04-08 18:27:18 -04:00
MediaQueryList.h Bug 991742 part 8. Remove the "aScope" argument of WebIDL/nsWrapperCache WrapObject() methods. r=bholley 2014-04-08 18:27:18 -04:00
moz.build Backed out changeset 69551e5b1a5d (bug 946065) 2014-08-06 17:06:27 +01:00
NameSpaceRule.h Bug 591303 - Part 3: Set line and column number for all rules in nsCSSParser. r=bz 2014-07-14 15:57:54 -07:00
nsAnimationManager.cpp Bug 1040543 part 10 - Move mIsLastNotification from AnimationPlayer to Animation; r=bz 2014-08-10 17:06:51 +10:00
nsAnimationManager.h Bug 1055519 - Fix some more bad implicit constructors in layout and widget; r=roc 2014-08-20 00:58:22 -04:00
nsComputedDOMStyle.cpp Bug 1041951 - rework computed value of font-variant to support only 2.1 values. r=dbaron 2014-08-20 16:54:27 +09:00
nsComputedDOMStyle.h Bug 1041951 - rework computed value of font-variant to support only 2.1 values. r=dbaron 2014-08-20 16:54:27 +09:00
nsComputedDOMStylePropertyList.h Bug 975744 - remove font features pref and enable features by default. r=dbaron 2014-08-20 16:54:35 +09:00
nsCSSAnonBoxes.cpp
nsCSSAnonBoxes.h
nsCSSAnonBoxList.h Bug 1021952 - Generate anonymous boxes to preserve proper ruby structure r=bz 2014-07-22 19:08:08 -07:00
nsCSSCounterDescList.h Bug 966166 - Part 1: Parse @counter-style rule. r=dbaron, r=bz 2014-06-11 21:10:00 -04:00
nsCSSDataBlock.cpp
nsCSSDataBlock.h
nsCSSFontDescList.h Bug 975744 - remove font features pref and enable features by default. r=dbaron 2014-08-20 16:54:35 +09:00
nsCSSKeywordList.h Bug 1032922 part 2: Rename flex-basis's "auto" keyword to "main-size" (but retain "flex:auto" as shorthand for "1 1 main-size"). r=heycam 2014-08-07 22:11:48 -07:00
nsCSSKeywords.cpp
nsCSSKeywords.h
nsCSSParser.cpp Bug 1041951 followup: Fix broken comparison against NS_FONT_VARIANT_CAPS_SMALLCAPS, to use != instead of negation. r=dbaron 2014-08-20 11:07:26 -07:00
nsCSSParser.h Bug 1035106 - Add new APIs to DOMUtils: colorToRGBA, isValidCSSColor & cssPropertyIsValid r=bz 2014-07-17 15:08:07 +01:00
nsCSSPropAliasList.h Bug 975744 - remove font features pref and enable features by default. r=dbaron 2014-08-20 16:54:35 +09:00
nsCSSProperty.h Bug 966166 - Part 1: Parse @counter-style rule. r=dbaron, r=bz 2014-06-11 21:10:00 -04:00
nsCSSPropertySet.h
nsCSSPropList.h Bug 975744 - remove font features pref and enable features by default. r=dbaron 2014-08-20 16:54:35 +09:00
nsCSSProps.cpp Bug 975744 - remove font features pref and enable features by default. r=dbaron 2014-08-20 16:54:35 +09:00
nsCSSProps.h Bug 1032922 part 1: Give "flex-basis" its own keyword table, instead of having it co-opt kWidthKTable. r=heycam 2014-08-07 22:11:47 -07:00
nsCSSPseudoClasses.cpp
nsCSSPseudoClasses.h
nsCSSPseudoClassList.h
nsCSSPseudoElementList.h Bug 1000879 - Remove the ::-moz-math-stretchy pseudo-element. r=karl, roc 2014-04-24 21:30:00 +02:00
nsCSSPseudoElements.cpp
nsCSSPseudoElements.h
nsCSSRuleProcessor.cpp Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc. 2014-08-06 06:31:21 -07:00
nsCSSRuleProcessor.h Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
nsCSSRules.cpp Bug 1043181 - Copy mValues and mGeneration in the nsCSSCounterStyleRule copy constructor. r=dbaron 2014-07-25 11:50:24 +10:00
nsCSSRules.h Bug 975744 - remove font features pref and enable features by default. r=dbaron 2014-08-20 16:54:35 +09:00
nsCSSScanner.cpp Bug 751939 - make url( followed by EOF valid. r=dbaron 2014-07-23 00:14:16 +03:00
nsCSSScanner.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
nsCSSValue.cpp bug 1028136 - Remove dangerous public destructor of FontFamilyList. r=jdaggett 2014-07-30 09:15:00 +01:00
nsCSSValue.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
nsDOMCSSAttrDeclaration.cpp Bug 591303 - Part 3: Set line and column number for all rules in nsCSSParser. r=bz 2014-07-14 15:57:54 -07:00
nsDOMCSSAttrDeclaration.h Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
nsDOMCSSDeclaration.cpp Backout revision 308e51eae10c for build bustage. 2014-06-20 13:00:08 +02:00
nsDOMCSSDeclaration.h Bug 985336: Remove unnecessary #includes from headers in layout/style. r=dbaron 2014-05-09 08:23:14 -07:00
nsDOMCSSRect.cpp Bug 1001966 - Part 2: Change uses of numbered NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE macro to the variadic variant. r=smaug 2014-04-29 04:57:00 -04:00
nsDOMCSSRect.h Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
nsDOMCSSRGBColor.cpp Bug 1001966 - Part 2: Change uses of numbered NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE macro to the variadic variant. r=smaug 2014-04-29 04:57:00 -04:00
nsDOMCSSRGBColor.h Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
nsDOMCSSValueList.cpp Bug 1001966 - Part 2: Change uses of numbered NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE macro to the variadic variant. r=smaug 2014-04-29 04:57:00 -04:00
nsDOMCSSValueList.h Bug 1029139 - Make the destructor of nsDOMCSSValueList private. r=bz 2014-06-26 09:29:06 -07:00
nsFontFaceLoader.cpp Bug 1031206 - Part 2: Split out creation of font faces in nsUserFontSet. r=jdaggett 2014-07-23 15:05:50 +10:00
nsFontFaceLoader.h Bug 1031206 - Part 2: Split out creation of font faces in nsUserFontSet. r=jdaggett 2014-07-23 15:05:50 +10:00
nsHTMLCSSStyleSheet.cpp Bug 1016345 - Add memory reporting for nsHTMLCSSStyleSheet's nsDataHashtable's buffer and the buffers of its nsString keys. r=dbaron 2014-06-22 23:02:05 +01:00
nsHTMLCSSStyleSheet.h Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
nsHTMLStyleSheet.cpp Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc. 2014-08-06 06:31:21 -07:00
nsHTMLStyleSheet.h Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
nsICSSDeclaration.h Bug 985336: Remove unnecessary #includes from headers in layout/style. r=dbaron 2014-05-09 08:23:14 -07:00
nsICSSLoaderObserver.h Backout revision 308e51eae10c for build bustage. 2014-06-20 13:00:08 +02:00
nsICSSPseudoComparator.h
nsICSSStyleRuleDOMWrapper.h
nsIMediaList.h Bug 1032118 - Remove the nsresult return value from nsMediaList::SetStyleSheet; r=dbaron 2014-07-02 12:53:41 +02:00
nsIStyleRule.h
nsIStyleRuleProcessor.h Bug 989212 Rename nsEventStates to mozilla::EventStates r=smaug 2014-04-03 13:18:36 +09:00
nsIStyleSheet.h Backout revision 308e51eae10c for build bustage. 2014-06-20 13:00:08 +02:00
nsLayoutStylesheetCache.cpp Bug 1029869, part 3 - Convert nsLayoutStylesheetCache::gStyleCache to a StaticRefPtr. r=bz 2014-06-26 09:29:05 -07:00
nsLayoutStylesheetCache.h Bug 1029869, part 3 - Convert nsLayoutStylesheetCache::gStyleCache to a StaticRefPtr. r=bz 2014-06-26 09:29:05 -07:00
nsMediaFeatures.cpp Bug 1021309 - Add "mac-yosemite-theme" CSS system metric. r=mstange 2014-06-05 18:02:46 -04:00
nsMediaFeatures.h Bug 985336: Remove unnecessary #includes from headers in layout/style. r=dbaron 2014-05-09 08:23:14 -07:00
nsNthIndexCache.cpp Bug 737976: Remove nsINodeInfo. r=smaug 2014-06-19 19:01:40 -07:00
nsNthIndexCache.h Bug 1033442 - Remove non-pod calloc from MallocProvider and AllocPolicy; r=jonco 2014-08-05 14:06:35 -07:00
nsROCSSPrimitiveValue.cpp Bug 1029140 - Make the destructor of nsROCSSPrimitiveValue private. r=bz 2014-06-26 09:29:05 -07:00
nsROCSSPrimitiveValue.h Bug 1029140 - Make the destructor of nsROCSSPrimitiveValue private. r=bz 2014-06-26 09:29:05 -07:00
nsRuleData.cpp
nsRuleData.h
nsRuleNode.cpp Bug 1041951 - parse font-variant as a shorthand for font feature subproperties. r=dbaron 2014-08-20 16:54:25 +09:00
nsRuleNode.h Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc. 2014-08-06 06:31:21 -07:00
nsRuleProcessorData.h Bug 1025308 - Rename the variables associated with skipping style fixups for children element's based on parent display value. r=mats 2014-06-16 09:55:00 -04:00
nsRuleWalker.h
nsStyleConsts.h Bug 1041951 - parse font-variant as a shorthand for font feature subproperties. r=dbaron 2014-08-20 16:54:25 +09:00
nsStyleContext.cpp Bug 1021952 - Ensure that direct children of ruby elements are inline. r=bz 2014-07-22 19:08:13 -07:00
nsStyleContext.h Bug 1029180: Give nsStyleContext a private destructor & MOZ_FINAL, to make it less likely to be freed by anything other than refcounting. r=heycam 2014-06-24 11:00:57 -07:00
nsStyleCoord.cpp Bug 1026344 - Part 4: Make nsStyleCoord::Calc refcounted and introduce a non-refcounted nsStyleCoord::CalcValue. r=dbaron 2014-06-19 13:18:03 +10:00
nsStyleCoord.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
nsStyleSet.cpp Bug 1040543 part 2 - Rename ElementAnimationCollection to AnimationPlayerCollection; r=bz 2014-08-10 17:06:46 +10:00
nsStyleSet.h Bug 996796 patch 20 - Make restyling exact - Avoid rerunning selector matching on everything when the basis of rem units changes. r=heycam 2014-08-03 13:11:55 -07:00
nsStyleStruct.cpp Bug 1041951 - parse font-variant as a shorthand for font feature subproperties. r=dbaron 2014-08-20 16:54:25 +09:00
nsStyleStruct.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
nsStyleStructFwd.h
nsStyleStructInlines.h Bug 1053190 - Reduce unnecessary inclusion of nsINode.h in headers; r=ehsan 2014-08-18 17:44:50 +03:00
nsStyleTransformMatrix.cpp Bug 781701 - Interpolate rotate3d rotation angles numerically when we can instead of using matrix decompositon. r=dbaron 2014-08-19 15:58:17 +12:00
nsStyleTransformMatrix.h Bug 1010067 part 1 - Rename nsStyleAnimation::Value to mozilla::StyleAnimationValue; r=dbaron 2014-06-24 15:29:54 +09:00
nsStyleUtil.cpp Bug 1032922 part 2: Rename flex-basis's "auto" keyword to "main-size" (but retain "flex:auto" as shorthand for "1 1 main-size"). r=heycam 2014-08-07 22:11:48 -07:00
nsStyleUtil.h Bug 1032922 part 2: Rename flex-basis's "auto" keyword to "main-size" (but retain "flex:auto" as shorthand for "1 1 main-size"). r=heycam 2014-08-07 22:11:48 -07:00
nsTransitionManager.cpp Bug 1048838 - Properly invalidate the style rule in nsTransitionManager::StyleContextChanged. r=dbaron 2014-08-12 16:57:21 +09:00
nsTransitionManager.h Bug 1040543 part 11 - Make ElementPropertyTransition inherit from Animation instead of AnimationPlayer; r=bz 2014-08-10 17:06:52 +10:00
number-control.css
plaintext.css
quirk.css
Rule.h Bug 591303 - Part 3: Set line and column number for all rules in nsCSSParser. r=bz 2014-07-14 15:57:54 -07:00
StyleAnimationValue.cpp Bug 781701 - Interpolate rotate3d rotation angles numerically when we can instead of using matrix decompositon. r=dbaron 2014-08-19 15:58:17 +12:00
StyleAnimationValue.h Bug 1010067 part 2 - Rename nsStyleAnimation.{h,cpp} to StyleAnimationValue.{h,cpp}; r=dbaron 2014-06-24 15:29:54 +09:00
StyleRule.cpp Bug 1037519 - Allow matching pseudo-elements in inIDOMUtils.selectorMatchesElement. r=bz 2014-07-18 14:30:00 -04:00
StyleRule.h Bug 1055519 - Fix some more bad implicit constructors in layout and widget; r=roc 2014-08-20 00:58:22 -04:00
TopLevelImageDocument.css
TopLevelVideoDocument.css
ua.css Bug 1054889 - Update images for touch caret and selection carets. r=roc, f=mtseng, ui-r=chuang 2014-08-19 01:34:00 -04:00
viewsource.css