gecko/layout
Brian Birtles 96b58d1f07 Bug 1048838 - Properly invalidate the style rule in nsTransitionManager::StyleContextChanged. r=dbaron
This patch fixes a regression from
https://hg.mozilla.org/mozilla-central/rev/31695984cfe2 (bug 1025709). That
patch replaced the EnsureStyleRuleFor method on ElementTransitions and
ElementAnimations with a common method in CommonElementAnimationData.

ElementTransitions::EnsureStyleRuleFor would create a new style rule if
there was no style rule (mStyleRule == nullptr) or if the refresh time was
old (mStyleRuleRefreshTime != aRefreshTime).

ElementAnimations::EnsureStyleRuleFor, however, would create a new style rule
only if mStyleRuleRefreshTime was null or old since a null style rule may
still be valid for animations (unlike transitions). If we bail as soon as we
a null style rule we would never update mNeedsRefreshes when the animation
finishes.

The unified version of EnsureStyleRuleFor in CommonElementAnimationData
adopted the behavior from ElementAnimations checking for a null or old
mStyleRuleRefreshTime.

However, nsTransitionManager::StyleContextChanged sets mStyleRule to nullptr
to indicate that we need to generate a new style rule. This means that we
will fail to create a style rule for the transition in some cases.

This patch addresses this by making nsTransitionManager::StyleContextChanged
set mStyleRuleRefreshTime to a null timestamp. Setting mStyleRule to nullptr
is no longer necessary since EnsureStyleRuleFor will do this when necessary
and nsTransitionManager::mStyleRule is only used after calling
EnsureStyleRuleFor.
2014-08-12 16:57:21 +09:00
..
analysis
base Bug 1055585 - Add nsITheme::NeedToClearBackgroundBehindWidget and create nsDisplayClearBackground if the theme needs it for a widget. r=roc 2014-08-20 17:26:11 +02:00
build Bug 1055286 - Flatten editor/libeditor/text to editor/libeditor; r=poiru 2014-08-18 20:59:37 -04:00
doc
forms Bug 1053013 - Collapse test-only moz.build files under layout/ into ancestor moz.build files. r=glandium 2014-08-20 10:27:18 -07:00
generic Merge mozilla-central and b2g-inbound 2014-08-20 15:19:45 +01:00
inspector Bug 1053013 - Collapse test-only moz.build files under layout/ into ancestor moz.build files. r=glandium 2014-08-20 10:27:18 -07:00
ipc Bug 1048752. Part 10: Remove FrameLayerBuilder.h from nsDisplayList.h. r=tn 2014-08-06 17:19:25 +12:00
mathml Bug 1053013 - Collapse test-only moz.build files under layout/ into ancestor moz.build files. r=glandium 2014-08-20 10:27:18 -07:00
media Bug 1051592 - Clip DrawTargetCairo's context to the surface bound to prevent massive mask allocations within cairo. r=jrmuizel 2014-08-15 14:23:22 +12:00
printing Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
reftests Bug 1053035: Don't give <body> its own scroll frame, when it's styled as 'flex' or 'grid' and we've propagated its scrollability to the viewport. r=mats 2014-08-20 08:01:32 -07:00
style Bug 1048838 - Properly invalidate the style rule in nsTransitionManager::StyleContextChanged. r=dbaron 2014-08-12 16:57:21 +09:00
svg Bug 1055519 - Fix some more bad implicit constructors in layout and widget; r=roc 2014-08-20 00:58:22 -04:00
tables Bug 35168 - Backout 4 changesets (e15a7a0c8f70, 852b5ce53278, f36adee1958f, 479ff28f783f) for B2G bustage and reftest failures ON A CLOSED TREE 2014-08-19 20:37:14 -07:00
tools Bug 1053013 - Collapse test-only moz.build files under layout/ into ancestor moz.build files. r=glandium 2014-08-20 10:27:18 -07:00
xul Bug 1053013 - Collapse test-only moz.build files under layout/ into ancestor moz.build files. r=glandium 2014-08-20 10:27:18 -07:00
moz.build Bug 1043820 - Remove PARALLEL_DIRS. r=gps 2014-07-29 08:57:59 +09:00