mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
3.5 KiB
3.5 KiB
Overview
- Changes should follow the design guidelines, as well as the coding style guide
- All changes must be accompanied by tests
- In order to land, changes must have been reviewed by one of the Jetpack reviewers
- Changes should have additional API review when needed
- Changes should have additional review from a Mozilla platform domain-expert when needed
If you have questions, ask in #jetpack on IRC or on the Jetpack mailing list.
How to Make Code Contributions
If you'd like to contribute the Jetpack project, follow these steps:
- Look for your issue in the list of bugs already filed. If you want to contribute, but don't already know what you want to do, we keep a list of good first bugs.
- If no bug exists, submit one.
- Get the code: get a GitHub account, fork the Add-on SDK repo, and clone it to your machine.
- Make your changes. Changes should follow the design guidelines as well as the coding style guide.
- Write tests: unit testing introduction, unit testing API.
- Submit a pull request with the changes and a title in the form of
Bug XXX - description. - Make sure that Travis CI tests are passing for your branch.
- Copy the pull request link from GitHub and paste it in as an attachment to the bug.
- Each pull request should ideally contain only one commit, so squash the commits if necessary.
- Flag the attachment for code review from one of the Jetpack reviewers listed below. This step is optional, but could speed things up.
- Address any issues mentioned in the review.
Finally, once review is approved, a team member will do the merging
Good First Bugs
There is a list of good first bugs here.
Reviewers
All changes must be reviewed by someone on the Jetpack review crew:
For review of Mozilla platform usage and best practices, ask [@autonome], [@0c0w3], or @mossop to find the domain expert.
For API and developer ergonomics review, ask @gozala.