Commit Graph

12 Commits

Author SHA1 Message Date
Ehsan Akhgari
bdc5c5427c Bug 659828 - Part 1: Apply table margins to the outer table frame instead of the inner table frame (also fixes bug 87277); r=dbaron
Outer table frames act as CSS2.1 table wrapper boxes.  We used to lay them out
without taking their margins into the account, which meant that their width was
always equal to the available width.  This breaks horizontal positioning of
absolutely positioned kids of a table frame.

The main purpose of this patch is to apply the margins of tables to their outer
frame, instead of the inner frame.  This means that the inner table frame will
always have a zero margin, which means that a lot of the stuff which used to
rely on the fact that table margins are applied to the inner frame need to
change.

In particular, in order to get the computed margins of a table, we used to query
the inner table frame, and this patch corrects that.  Also, when shrink wrapping
tables, we used to not take the margins of the inner table frame into account,
which is fixed by this patch too.  nsBlockReflowState::
ComputeReplacedBlockOffsetsForFloats also needed to be changed to read the
margin values from the outer frame too.

Also, as part of this patch, we start to respect the CSS2.1 margin model for
captions on all sides.  This means that in particular, the top/bottom margins on
the top-outside and bottom-outside captions will not be collapsed with the
top/bottom margins of the table, and that the margins of the caption element
contribute to the width and height of the outer table frame.  The
427129-table-caption reftest has been modified to match this new behavior.

Another side effect of this bug is fixing bug 87277, and the reftests for that
bug are marked as passing in this patch.
2011-05-31 19:02:56 -04:00
Benoit Girard
95f511b8f5 Bug 676831 - Mark Android OpenGL Reftest failures for regression testing. r=joe
--HG--
extra : rebase_source : b5458fa13fc6277560eb0ebc3e4e31f6c04b4e6c
2011-09-19 13:05:15 -07:00
Jonathan Kew
93c7072af0 Bug 661471. Part 5: Fix reftests. r=roc 2011-06-03 16:31:08 +12:00
Daniel.S
1b17d6610d Bug 477462 - margin-collapsing test suite, wave 4: dynamic horizontal, block, table, caption sibling margins. r=dbaron
--HG--
extra : rebase_source : 2768fbfd11770d9f72edd70d7828b4f4f5ac9ae0
2011-05-21 22:05:43 +02:00
Jesse Ruderman
980554b795 Add reftest for bug 467321 2009-10-15 12:18:37 -07:00
Jonathan Kew
1b4863c480 Bug 518357, make reftests less sensitive to default font size settings. r=roc
--HG--
extra : rebase_source : 1914dd5f2998a2f45e10ccf3574d854ba9240f52
2009-09-23 15:55:55 +01:00
Daniel.S
84b2d5578d Bug 477462: Create tests for margin collapsing, phase 3. r=dbaron 2009-08-14 14:59:45 -07:00
Bernd
5c0c166ec7 adopt caption vertical margins to latest CSS2.1 revision, bug 478614, r/sr=dbaron 2009-06-28 15:51:46 +02:00
Daniel.S
a2d9a2f6e3 Bug 477462 - Add margin-collapsing tests (part 2): horizontal margins, tables, captions, fieldsets and some suggested tests. r+sr=dbaron 2009-05-26 20:24:25 +02:00
Robert O'Callahan
66e61f0bec Fix bustage #3 2009-04-25 21:38:35 +12:00
Daniel.S
87d3306c75 Bug 477462. Add many margin-collapsing reftests. r+sr=dbaron
--HG--
extra : rebase_source : 7ae1e9d247225b11cf6468bd0334ccd80f86db8c
2009-04-25 20:50:57 +12:00
Daniel.S
ff6b23bdc7 Bug 477462 - create an extensive reftest suite for margin(-collapsing); create basic infrastructure, for checkin; r=dbaron 2009-02-16 16:27:11 +01:00