The previous annotations only checked if the re-entrancy happened via DecrementVisibleCount.
The check in RebuildApproximateFrameVisibility is not needed because we add a check in DoUpdateApproximateFrameVisibility.
The check in ClearApproximatelyVisibleFramesList is not needed because we add checks in DoUpdateApproximateFrameVisibility and Destroy. The other caller, ClearApproximateFrameVisibilityVisited, is covered because it is only called from DoUpdateApproximateFrameVisibility.
MozReview-Commit-ID: 5UaOQ4l50wP
The problem with this test is that loadPageAndGetHud() resolves once the console
message about the request is rendered. However, the message is logged immediately
when enough info has been received instead of waiting for all updates, such as
headers, body and timings, to be received.
By the time the test calls waitForFinishedRequest(PAGE_REQUEST_PREDICATE), the
initial request is still pending and the resulting promise resolves once
the initial GET request finishes instead of the POST request triggered by
the form submission causing the test failures.
MozReview-Commit-ID: HkDdKTmzJfM
If test timings shift in the future, the unexpected requests could occur
during any test. Since there are many tests that use waitForFinishedRequest(),
any of them could start to fail intermittently at any point.
These changes fix other usages of wwaitForFinishedRequest() to include a
predicate that ignores the requests that are unexpected during the test.
MozReview-Commit-ID: Er0xyt3YBj6
The problem here is that the test expects to receive a request for the
|test-network-request.html| but the waitForFinishedRequest() accepts any
request that happens to occur at the same time. In this particular bug,
a GMP update is triggered during the test and the waitForFinishedRequest()
promise resolves with that particular request which obviously isn't the
one the test was expecting.
These changes add an optional predicate function parameter to
waitForFinishedRequest() which will be called for each completed request
and the returned promise only resolves when the predicate returns true for
a request.
Also, browser_console_netlogging.js begins to use the aforementioned
functionality by passing a predicate that only accepts the request for
|test-network-request.html| effectively fixing the intermittent failure.
MozReview-Commit-ID: AWhMRjrqP8i
Allow passing version and build_number via buildbot properties. This will allow
us add buildbot builders without hardcoded parameters depending on release
configs.
MozReview-Commit-ID: 3zGiCJ5z36X
WebRTC code requires VP9E_SET_NOISE_SENSITIVITY from vpx/vp8cx.h
which was added in 1.4. We could feature test, but gating on
the minimum version seems better given the m4 code is to be
replaced by python.
We also depend on VPX_MAX_LAYERS wich is part of the 1.5.0 release.
This dependency was added with an SVC support patch in May 2015,
bug 1237023.
Optional --enable-spatial-svc is handled by the work-around
in bug 1248335.
MozReview-Commit-ID: 79kg9JSFtJM
