Commit Graph

16322 Commits

Author SHA1 Message Date
Brian Hackett
c61a469092 Sync state on all exit paths in CALLPROP PICs when allowing getter stubs, bug 688478. r=dvander 2011-09-24 14:15:38 -07:00
Matheus Kerschbaum
e1d3c86e9c Bug 669829 - Remove check for atlbase.h and oleacc.idl from configure. r=ted 2011-09-24 12:53:07 +02:00
Ed Morley
f5a2b818d7 Backout 3bfef7f630dc and all ancestors until cba5d081f15d inclusive (bug 683802, bug 684327 & bug 652571); a=use-try-before-crapping-23-changesets-on-the-tree-thank-you-please 2011-09-24 03:33:31 +01:00
Ed Morley
d06542a2e2 Backout changeset 737c2fdb9148 (bug 683802), since bustage fix not relevant now that the whole bug is being backed out 2011-09-24 03:29:48 +01:00
Andrew McCreight
bac8bd20e7 Bug 683802 - remove trailing ; to fix Maemo bustage. r=bholley 2011-09-23 17:26:19 -07:00
Bobby Holley
43108c0900 Bug 683802 - Pass useAllocator=false only for wrappedjs dipper params. Everything else can allocate. r=mrbkap
We only have one good reason for the useAllocator distinction: when C++ calls JS with a dipper parameter (ie, a string), the caller has already created the relevant nsAString or nsCString, so we shouldn't allocate another one. All other uses are superfluous or irrelevant, so we can get rid of them.
2011-09-23 14:50:29 -07:00
Bobby Holley
2f66a40072 Bug 683802 - Force allocation for sized PWSTRINGs in XPCWrappedNative argument conversion. r=mrbkap
This is the last remaining place where we might pass a non-dipper with useAllocator==false to XPCConvert *and, as a consequence*, do something different within XPCConvert. This paves the way for the elimination of useAllocator for non-dipper types.
2011-09-23 14:50:29 -07:00
Bobby Holley
4170b80aaf Bug 683802 - Remove XPC_JSArgumentFormatter and friends. r=mrbkap
XPC_JSArgumentFormatter adds 3 special format string tokens to spidermonkey: %ip, %iv, and %is. These were unused outside of testing according to a free-text MXR search, and don't appear to be well-documented anywhere either. They also happen to be quite dangerous and easy to use improperly: we pass untyped variadic parameters to XPCConvert::JSData2Native with useAllocator==false. This causes JSData2Native to blindly cast the values to concrete class pointers (like nsAString*) and call methods on them.
2011-09-23 14:50:28 -07:00
Bobby Holley
0d7e07547c Bug 683802 - Eliminate questionable support for [shared] parameters. r=mrbkap
AFAICT we'd crash if we hit these cases anyway. bsmedberg and khuey requested that I assert against this case within XPConnect, and file a bug to make XPIDL enforce that [shared] parameters exist only in [noscript] methods. Filed bug 685281 for this.
2011-09-23 14:50:28 -07:00
Bobby Holley
364f0f80e5 Bug 683802 - Coalesce type-specific cleanup indicators. r=mrbkap 2011-09-23 14:50:28 -07:00
Bobby Holley
7386fc9507 Bug 683802 - Add jsval to the XPTCMiniVariant union for type safety. r=mrbkap 2011-09-23 14:50:28 -07:00
Bobby Holley
c0aa2b6439 Bug 683802 - Use an explicit indicator for direct vs indirect calling semantics. r=mrbkap 2011-09-23 14:50:28 -07:00
Bobby Holley
21981b746e Bug 683802 - Define and restrict the semantics of PTR_IS_DATA. r=mrbkap 2011-09-23 14:50:28 -07:00
Bobby Holley
bb7989ef1e Bug 683802 - Always store jsvals directly within the val union (fixes bug 655878). r=mrbkap 2011-09-23 14:50:28 -07:00
Bobby Holley
b39a7f2504 Bug 683802 - Factor dipper handling out into a helper method. r=mrbkap 2011-09-23 14:50:28 -07:00
Bobby Holley
757407104f Bug 683802 - Separate reindentation from previous patch for easier review. No other changes. r=mrbkap 2011-09-23 14:50:27 -07:00
Bobby Holley
b88cd46009 Bug 683802 - Move the loop contents of ConvertIndependentParams into a separate method (without re-indentation). r=mrbkap 2011-09-23 14:50:27 -07:00
Bobby Holley
b6cbc3e44d Bug 683802 - Remove mAutoString micro-optimization. r=mrbkap 2011-09-23 14:50:27 -07:00
Bobby Holley
61ec2b2260 Bug 684327 - Package the typelib along with the components so that it's accessible from the test harness. r=khuey 2011-09-23 14:50:27 -07:00
Bobby Holley
9ee149cc53 Bug 684327 - Test parameter passing. r=khuey 2011-09-23 14:50:27 -07:00
Bobby Holley
608c7d4d5f Bug 684327 - Generalize test_readwriteattributes.js into test_attributes.js. r=khuey
--HG--
rename : js/src/xpconnect/tests/unit/test_readwriteattributes.js => js/src/xpconnect/tests/unit/test_attributes.js
2011-09-23 14:50:27 -07:00
Bobby Holley
4525104bc9 Bug 684327 - Add an xpcshell test that exercises both the native and js components. r=khuey 2011-09-23 14:50:27 -07:00
Bobby Holley
3c889d66dd Bug 684327 - Introduce js-implemented test component. r=khuey 2011-09-23 14:50:27 -07:00
Bobby Holley
6f02e9f167 Bug 684327 - Move the C++ implementation of the test component into its own subdirectory. r=khuey
--HG--
rename : js/src/xpconnect/tests/components/Makefile.in => js/src/xpconnect/tests/components/native/Makefile.in
rename : js/src/xpconnect/tests/components/xpctest.manifest => js/src/xpconnect/tests/components/native/xpctest.manifest
rename : js/src/xpconnect/tests/components/xpctest_attributes.cpp => js/src/xpconnect/tests/components/native/xpctest_attributes.cpp
rename : js/src/xpconnect/tests/components/xpctest_module.cpp => js/src/xpconnect/tests/components/native/xpctest_module.cpp
rename : js/src/xpconnect/tests/components/xpctest_private.h => js/src/xpconnect/tests/components/native/xpctest_private.h
2011-09-23 14:50:27 -07:00
Bobby Holley
91964a9e10 Bug 684327 - Misc fixes to xpctest_attributes. r=khuey
This patch is best reviewed while listening to http://www.youtube.com/watch?v=MK6TXMsvgQg

NB - The code here would make a great "find the bugs in this code" interview screen question.
2011-09-23 14:50:27 -07:00
Bobby Holley
4252ab2c8a Bug 684327 - Start building a small subset of the xpconnect test component again, kill the rest. r=khuey
Thanks to Mook for the initial patch!
2011-09-23 14:50:27 -07:00
Bobby Holley
93d027b403 Bug 684327 - Remove TestXPC.cpp, which currently printfs that it's failing various things and then segfaults. r=khuey 2011-09-23 14:50:26 -07:00
Luke Wagner
97b8d5795c Bug 688769 - rm resource.h and t/ from js/src (r=dmandelin)
--HG--
extra : rebase_source : ac5bb528ab1c25c649cab1e6c5c63f778e2594eb
2011-09-23 09:07:33 -07:00
Luke Wagner
f4a84db75a Bug 688769 - Remove dead args from StackFrame::functionEpilogue (r=bhackett)
--HG--
extra : rebase_source : ebb55d46c774a4e1dad6eacf59d55e5da496948c
2011-09-23 08:59:19 -07:00
Tom Schuster
6348ebba8c Bug 685150 - Generate native code for Math.min/Math.max in the methodjit. r=bhackett 2011-09-09 14:53:28 +02:00
Brian Hackett
8034f0a1a6 Fix bogus assert, bug 687399. r=dvander 2011-09-23 07:12:36 -07:00
Brian Hackett
fd136b659e Only inline scripts which have already been analyzed, bug 687125. r=dvander 2011-09-23 07:02:28 -07:00
Brian Hackett
baeabd8f01 Don't drop contents of copied dead slots at branches, bug 687768. r=dvander 2011-09-23 06:33:20 -07:00
Mike Hommey
8a2b143076 Bug 653056 - Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile. r=jimb 2011-09-23 14:27:21 +02:00
Mike Hommey
cf96279041 Bug 671423 - Manually inline DOUBLE_TO_JSVAL to avoid Xcode 3.1.4 miscompilation. r=jimb 2011-09-23 14:25:16 +02:00
Boris Zbarsky
085b188f8c Bug 684671. Allow the onreadystatechange getter/setter on Document.prototype to not throw even if its |this| is bogus. r=peterv,sicking 2011-09-23 01:03:50 -04:00
Andreas Gal
195f6fccb6 Bug 660233 part 2. Move nodePrincipal, baseURIObject, and documentURIObject from classinfo to XrayWrapper and to DOM prototypes in chrome documents. r=mrbkap 2011-09-21 21:30:27 -04:00
Boris Zbarsky
18cca0613a Bug 688685. Propcached property adds that just write to a slot are not sound when the class has an addProperty hook. r=bhackett 2011-09-23 01:03:49 -04:00
Jeff Walden
37632bfcb5 Bug 687621 - Convert getProperty to take a PropertyName*, and make getGeneric the only way to get a property for a jsid. r=luke 2011-09-15 11:44:10 -07:00
Jeff Walden
ddb8886dc3 Bug 687621 - Introduce js::SpecialId, encapsulating the non-index, non-string bizarro property names. r=luke 2011-09-20 14:34:11 -07:00
Jeff Walden
9d85b7ddf3 Add PropertyName to the string-types tree in vm/String.h, and beef up the comment by PropertyName itself to better explain its utility. rs=luke 2011-09-21 15:37:43 -07:00
Jeff Walden
229554194a Bug 687621 - Further split ObjectOps to add a third property type (and temporarily a fourth to use for a property of indeterminate type), to encapsulate object-valued jsids and properties that don't fit in the property name/element distinction. r=luke
--HG--
extra : rebase_source : 4cfd216dcbff77750cb54ea48b546e83bd555513
2011-08-12 14:26:48 -04:00
Jeff Walden
00521e3dfd Bug 687642 - Rename JSFlatString::isElement to JSFlatString::isIndex. This better comports with other terminology being thrown around, and it makes it simpler to distinguish between the value used as the property name (the index, potentially) and the value the property contains (the element). r=dvander
--HG--
extra : rebase_source : e66315100fc331a4bd961a2cd281c36ed23ce471
2011-09-19 13:57:33 -07:00
Paul Biggar
d8fd60d75c Change in-tree users of Array.prototype.splice to not rely on non-standard behavior of deleting all elements from |k| onward for |arr.splice(k)|. r=jwalden
--HG--
extra : rebase_source : b2f041ab27c500636598fe6213481c1a5f0989e8
2011-09-22 15:43:11 -07:00
Bill McCloskey
e5701ded7e Bug 677431 - Clean up MarkAndSweep code in GC (r=igor) 2011-08-05 10:25:51 -07:00
Igor Bukanov
abe648ab25 bug 688551 - specialize ~Anchor for Value only outside GCC. r=luke 2011-09-22 21:01:49 +02:00
Bill McCloskey
ee58d4bd06 Bug 674776 - Replace giganto test with code to generate it (rs=jorendorff) 2011-09-21 16:37:30 -07:00
Terrence Cole
59f4dc6032 Bug 685315 - Remove the GETGLOBAL opcode; r=dvander
This was a nice and simple way to get a perf boost in the
interpreter and JM, but JSOP_GETGNAME has the same
information and more. TI doesn't need it, JM technically
doesn't, and IM won't either. We can just do a normal
property lookup during compilation.
2011-09-22 17:35:25 +01:00
Brian Hackett
e29e34dc29 Try to release native call stubs on GC, bug 688292. r=dvander 2011-09-22 07:26:14 -07:00
Sean Stangl
94e87deaa3 Correct typo in NumberDiv. (Bug 686323, r=dvander) 2011-09-21 20:51:18 -07:00