Commit Graph

849 Commits

Author SHA1 Message Date
Bobby Holley
bad3903f40 Bug 902718 - Fold EnsureScriptEnvironment into GetCompilationGlobal. r=bz 2013-08-09 09:25:15 -07:00
Bobby Holley
c3b6213d2c Bug 902718 - Stop using nsIScriptContext for XBL compilation. r=bz,mccr8 2013-08-09 09:25:14 -07:00
Bobby Holley
d8e09dd669 Bug 902718 - Remove nsIScriptGlobalObjectOwner from XBL. r=bz 2013-08-09 09:25:14 -07:00
Bobby Holley
2fd804060b Bug 902718 - Stop using nsIScriptGlobalObjectOwner to grab the compilation global. r=bz 2013-08-09 09:25:14 -07:00
Bobby Holley
c63baf2891 Bug 902718 - Use the SafeJSContext for prototype member compilation. r=bz 2013-08-09 09:25:14 -07:00
Bobby Holley
89498daf86 Bug 902718 - Use the SafeJSContext for XBL serialization and deserialization. r=bz 2013-08-09 09:25:13 -07:00
Bobby Holley
e1eb45e3e1 Bug 902718 - Fix up nsXBLDocGlobalObject::GetGlobalJSObject() to force lazy global creation. r=bz
Currently we always pull the global off the nsIScriptContext, and trigger
a call to EnsureScriptEnvironment in the GetContext() call. So as we move away
from nsIScriptContext, let's make sure that GetGlobalJSObject continues to work
correctly.
2013-08-09 09:25:13 -07:00
Bobby Holley
0c75150387 Bug 902718 - Rip out nsIScriptContext from the lion's share of XBL code. r=bz
This kind of has to be done all at once. The primary correctness concern here is
making sure that we continue to operate in the correct compartment. So the basic
strategy here is as follows.

For most anything that previously took a script context, we remove the parameter
entirely and assert that the stack-top cx is in the compartment of the
compilation scope. We then bubble this up through all the callers until we hit
a caller that finds the scx via some means other than its parameter list. At
these points, we push the scx, making it stack-top.

This puts us in a good position to switch wholesale to the SafeJSContext in
subsequent patches.
2013-08-09 09:25:13 -07:00
Bobby Holley
dec22ba18c Bug 902718 - Stop taking an nsIScriptContext in XBL serialization routines. r=bz 2013-08-09 09:25:13 -07:00
Bobby Holley
cde56ff019 Bug 902718 - Add a mechanism to assert that the stack-top cx is an XBL compilation scope. r=bz 2013-08-09 09:25:12 -07:00
Bobby Holley
3f88a39464 Bug 902718 - Defer XPCOM release from the XBL compilation scope finalizer. r=mccr8
Apparently the current setup is incidentally safe, but far from kosher.
2013-08-09 09:25:12 -07:00
Nicholas Nethercote
b756f6b258 Bug 898914 (part 1) - Remove JSBool.
--HG--
extra : rebase_source : 2d202e0e5005a7f54724b1540481c15cde3ad52e
2013-08-08 15:53:04 -07:00
Nicholas Nethercote
25d70fdd97 Bug 902332 - Replace JS_{FALSE,TRUE} with {false,true} almost everywhere. r=luke,bz.
--HG--
extra : rebase_source : 25f4de1bfae830b0af6407d260a70b787ab1dc9b
2013-08-06 23:59:54 -07:00
Blake Kaplan
f3dfffe24b Bug 898926 - xbl:children elements are insertion points if they're inactive. r=sicking 2013-08-06 17:31:30 -07:00
Nicholas Nethercote
ba723f1034 Bug 901750 - Change return type of |JSNative| from |JSBool| to |bool|. code=nnethercote,jandem. r=luke,bz.
--HG--
extra : rebase_source : 5b3d7cc339af6d93bde078322e25c6e740d1b617
2013-08-02 00:41:57 -07:00
Jon Coppeard
694e4a5be0 Bug 900979 - Change JS_DeleteProperty APIs to use a boolean out param rather than a value r=waldo r=bz 2013-08-05 14:01:53 +01:00
Jon Coppeard
93c50cb189 Bug 899973 - GC: Convert the rest of the JS property API to use MutableHandleValue for out params - browser changes r=bz 2013-08-02 13:15:39 +01:00
Robert O'Callahan
82b71516c9 Bug 880854. When attaching XBL bindings to elements in a static document, sync-load the bindings document so that delayed changes to the shadow DOM don't mess up, for example, printing. r=mrbkap
--HG--
extra : rebase_source : 283ce66e7659b8ac9d8c5dc08d52b0f5a79452fb
2013-08-02 21:26:21 +12:00
Bobby Holley
f7c06c0933 Bug 897322 - Allow callers to manually fire OnNewGlobalObject when bootstrapping is complete. r=luke 2013-08-01 18:38:47 -07:00
Bobby Holley
3b5f7c3277 Bug 885388 - Make compilation scopes invisible to the debugger. r=mrbkap 2013-08-01 18:38:46 -07:00
Mike Hommey
d01b5df996 Bug 881323 - Re-implement CycleCollectorParticipant with actual vtables, with constexpr to avoid static initializers. r=mccr8 2013-08-02 10:29:05 +09:00
Tom Schuster
0b021a6fa2 Bug 884410 - Handlify JS_GetPrototype. r=terrence 2013-07-31 12:20:33 -04:00
Bobby Holley
51bb849f7a Bug 898811 - Use the system error reporter for XBL compilation. r=mrbkap
The current XBL error reporter logs things to the console service, but not to
stderr. And in certain situations (especially if there's a parse error in
frontend XBL that leaves the browser in a half-baked state), it can be very
difficult to get to the error console.

So we should log to stderr too, which is exactly what the system error reporter
does.
2013-07-30 17:58:46 -07:00
Bobby Holley
9dbd7cffb9 Bug 899245 - Rename JS_SetGlobalObject and move it into jsfriendapi. r=luke 2013-07-29 16:45:26 -07:00
Jon Coppeard
8278efd42a Bug 897484 - GC: Convert JS_GetProperty APIs to take MutableHandleValue r=terrence r=bholley r=smaug 2013-07-26 10:00:38 +01:00
Carsten "Tomcat" Book
8c89deb65b Backed out changeset ae8d72538dee (bug 897484) for b2g bustage 2013-07-26 12:34:25 +02:00
Jon Coppeard
fc9b509d4f Bug 897484 - GC: Convert JS_GetProperty APIs to take MutableHandleValue r=terrence r=bholley r=smaug 2013-07-26 10:00:38 +01:00
Jon Coppeard
1463e7df5b Bug 896949 - JS_SetProperty APIs should take an immutable parameter r=waldo r=bz 2013-07-26 10:00:38 +01:00
William Chen
0d79ba91bc Bug 895805 - Ensure nsBindingManager hashtable is initialized before use. r=mrbkap 2013-07-25 22:58:39 -07:00
Jon Coppeard
477e4df5c5 Bug 896540 - GC: Convert JS_SetProperty* to take MutableHandleValue - browser changes r=bz 2013-07-25 13:57:00 +01:00
Ms2ger
88a17639b3 Bug 896385 - Use nsInterfaceHashtable for nsXBLPrototypeBinding::mInterfaceTable; r=mrbkap 2013-07-24 09:39:56 +02:00
Jon Coppeard
3155328d9e Bug 891966 - 2 - Comment calls to Handle::fromMarkedLocation r=bz 2013-07-23 10:58:28 +01:00
Jon Coppeard
da4b383f2b Bug 891966 - 1 - Don't allow construction of Handle<T> from Heap<T> r=bz 2013-07-23 10:58:27 +01:00
Blake Kaplan
ee626e75ca Bug 895129 - Fix a typo in the original patch: we should be ignoring xul:observes. r=sicking 2013-07-17 16:20:37 -07:00
Bobby Holley
c045da868b Bug 887334 - Enter a compartment between manual calls to JS_{Save,Restore}FrameChain. r=luke
The stuff in nsXBLProtoImplMethod is doing the same thing, so let's just have
it call into nsJSUtils.
2013-07-17 11:53:52 -07:00
William Chen
9e883ad8f5 Bug 796061 - Part 2: Remove mInsertionParentTable from nsBindingManager. r=mrbkap 2013-07-17 09:05:06 -07:00
William Chen
ca763cf5e3 Bug 796061 - Part 1: Remove mBindingTable from nsBindingManager. r=mrbkap 2013-07-17 09:05:03 -07:00
Blake Kaplan
c55ad9cb94 Bug 888787 - Restore old XBL behavior when a child of the bound element didn't match any of the <children/> in the binding. r=sicking 2013-07-11 17:05:54 -04:00
Mike Hommey
ffd522d5c2 Bug 892904 - Remove useless includes of config.mk. r=gps 2013-07-15 18:48:40 +09:00
Trevor Saunders
82e5558b37 bug 887483 - remove a bunch of useless assignments to FORCE_STATIC_LIB implied by LIBXUL_LIBRARY=1 r=mshal 2013-07-11 11:06:34 -04:00
Boris Zbarsky
60d5133416 Bug 890193. Make the XML prettyprinter actually drop its binding when it unhooks, and remove the now-dead concept of "style binding" in the process. r=mrbkap 2013-07-11 11:58:28 -04:00
J. Ryan Stinnett
8dd81455a4 Bug 282097 - Part 9: Ensure editor commands are enabled. r=enndeakin 2013-07-10 09:13:53 -05:00
J. Ryan Stinnett
a9d3b48bc1 Bug 282097 - Part 5: Remove platform bindings for Cocoa. r=neil 2013-07-10 09:10:18 -05:00
Tim Taubert
65cc5f15e6 Bug 891806 - part 2 - replace 'yield;' with 'yield undefined;' in content/; r=smaug 2013-07-10 23:52:14 +02:00
Ryan VanderMeulen
aaee3cf638 Merge m-c to inbound. 2013-07-10 09:45:16 -04:00
Ms2ger
db26bfced0 Bug 213324 - Remove getter_AddRefs(T*); r=ehsan 2013-07-10 11:56:21 +02:00
Blake Kaplan
ea4da60962 Bug 891088 - Rename nsXBLChildrenElement -> mozilla::dom::XBLChildrenElement. r=peterv
--HG--
rename : content/xbl/src/nsXBLChildrenElement.cpp => content/xbl/src/XBLChildrenElement.cpp
rename : content/xbl/src/nsXBLChildrenElement.h => content/xbl/src/XBLChildrenElement.h
2013-07-01 15:09:37 -07:00
Kyle Huey
22ba9194a9 Bug 891088: Fix whitespace. r=me 2013-07-09 07:29:25 -07:00
Kyle Huey
49b422d01c Bug 885866: Separate deferred finalization from XPConnect so we can use it off the main thread. r=mccr8, peterv, bsmedberg, jorendorff 2013-07-09 07:28:15 -07:00
Bobby Holley
4ed4784c75 Bug 880917 - Remove AutoVersionChecker. r=luke
Looks like cdleary added this back in bug 595691, as an equivalence to some
even-older-and-more-overly-cautious XBL code that was saving and restoring
the version across XBL calls. It doesn't seem like this should be an issue
anymore, and it's just a debugging aid to boot. Let's kill it.
2013-06-29 09:11:18 -06:00