Commit Graph

199626 Commits

Author SHA1 Message Date
Robert O'Callahan
b796347bb8 Bug 1048752. Part 15: Fix some comments. r=tn
--HG--
extra : rebase_source : c21e494622615b306e796afedf6c0a424d6f1046
2014-08-06 17:19:26 +12:00
Robert O'Callahan
922821fdc8 Bug 1048752. Part 14: Split GetGeometry into a static and a non-static version. r=tn
GetGeometry is used in two different ways. Sometimes it's used to get
information about a particular caret. Sometimes it's used to get
information about a particular selection that's not associated with
a caret. Splitting GetGeometry into a non-static version for the former
and a static version for the latter makes this more clear. Also it saves
code since for the latter version we don't have to get an nsCaret first.

--HG--
extra : rebase_source : b7730dac56b308a82b79b175749234c9a92b6f59
2014-08-06 17:19:26 +12:00
Robert O'Callahan
534e15cb7d Bug 1048752. Part 13: Remove GetGeometry's aBidiIndicatorSize. r=tn
Callers always pass null.

--HG--
extra : rebase_source : 169f9fe4f4236cffe2c0f760305ebf8093300c69
2014-08-06 17:19:26 +12:00
Robert O'Callahan
857db778d8 Bug 1048752. Part 12: Replace mBlinkRate with mIsBlinking. r=tn
We don't need to store the blink rate. Instead we can just fetch it whenever
we need it. However we do need a flag to handle the case where
nsCaret::DrawAtPosition disables blinking.

--HG--
extra : rebase_source : 4f36825a8e22edd3a2e37edb1fae5675c85adadd
2014-08-06 17:19:26 +12:00
Robert O'Callahan
52ce18f581 Bug 1048752. Part 11: Remove nsLayoutUtils.h from nsDisplayList.h. r=tn
--HG--
extra : rebase_source : 02251076442a5c4251e8d9484cb428a4c07f3a13
2014-08-06 17:19:25 +12:00
Robert O'Callahan
912c1e35de Bug 1048752. Part 10: Remove FrameLayerBuilder.h from nsDisplayList.h. r=tn
I was inspired by the previous patch to remove FrameLayerBuilder.h from
nsDisplayList.h too.

--HG--
extra : rebase_source : b34a01bea5865da4737817e2396b98d54cc6d1bf
2014-08-06 17:19:25 +12:00
Robert O'Callahan
7ea822125b Bug 1048752. Part 9: Remove nsCaret.h from nsDisplayList.h. r=tn
I got tired of slow build turnarounds every time I modified nsCaret.h.

--HG--
extra : rebase_source : 0c4598c4881ab8de0a636b08c70fb801bb912247
2014-08-06 17:19:25 +12:00
Robert O'Callahan
22a250e9db Bug 1048752. Part 8: Remove mCaretAspectRatio. r=tn
mCaretAspectRatio doesn't need to be stored. We can recompute it
whenever we need it.

--HG--
extra : rebase_source : 065a6996e920800edf5cbcc7f072f0439ef84553
2014-08-06 17:19:25 +12:00
Robert O'Callahan
9501a2c9ee Bug 1048752. Part 7: Remove mCaretWidthCSSPx. r=tn
mCaretWidthCSSPx doesn't need to be stored. We can just recompute it
whenever we need it.

--HG--
extra : rebase_source : 850b556651afade0da543e281e5fa54235969ab4
2014-08-06 17:19:25 +12:00
Robert O'Callahan
8932f6dda1 Bug 1048752. Part 6: Remove 'virtual' declarations. r=tn
These used to be needed for linking with non-libxul builds, but are no
longer needed. The obsolete comment is fixed in a later patch.

--HG--
extra : rebase_source : 034f69b647bd64d4353e51a15e166094b7b2e638
2014-08-06 17:19:24 +12:00
Robert O'Callahan
069d4c4180 Bug 1048752. Part 5: Reorder API declarations. r=tn
To make it more clear what's going on, make CaretBlinkCallback protected
and reorder the public methods to put the state-changing "API" methods first.

--HG--
extra : rebase_source : fddf0ea4b9269b2d431d0b75c40f99a9140138a1
2014-08-06 17:19:24 +12:00
Robert O'Callahan
8c19042ffb Bug 1048752. Part 4: Make EViewCoordinates (unused). r=tn
--HG--
extra : rebase_source : 571ba155fb5741fdd26d0391ef4a029a7383b34a
2014-08-06 17:19:24 +12:00
Robert O'Callahan
311f843a5a Bug 1048752. Part 3: Make GetCaretFrameForNodeOffset static. r=tn
GetCaretFrameForNodeOffset only uses the nsFrameSelection and mBidiUI
from its nsCaret. For mBidiUI we can just get the pref directly whenever
we need it. By modifying GetCaretFrameForNodeOffset to take nsFrameSelection
as a parameter, we can make it static to make it clear it isn't really
related to the state of the nsCaret.

This may also fix a bug in Selection::GetPrimaryFrameForFocusNode where
things would go unexpectedly wrong if mCaret is temporarily observing
a different selection to the Selection.

--HG--
extra : rebase_source : cdd59f6e20cd1060bc5d2325cb3adb5e5c4a1d2c
2014-08-06 17:19:24 +12:00
Robert O'Callahan
2aa74c872a Bug 1048752. Part 2: Remove InvalidateOutsideCaret and MaybeInvalidateCaretPosition. r=tn
I'm quite sure DLBI means we don't need these anymore.

--HG--
extra : rebase_source : 6cb6cd7c160a46688793c6ab1cdded333aecdd61
2014-08-06 17:19:23 +12:00
Robert O'Callahan
8a36ee38de Bug 1048752. Part 1: Remove GetCaretReadOnly (unused). r=tn
--HG--
extra : rebase_source : 86c27ad506440199fe623a083a2b4cb7eca98e47
2014-08-06 17:19:23 +12:00
Daniel Holbert
36ec299778 Bug 1054563: Remove unnecessary nsresult return value from BuildScrollFrame, and de-indent it. r=tn 2014-08-15 20:22:09 -07:00
Ryan VanderMeulen
2fb70c0009 Backed out changeset 3ad9f60f1972 (bug 1032055) for B2G ICS bustage. 2014-08-15 23:14:30 -04:00
Trevor Saunders
71b489032f bug 1032055 - fix ordering of static xul component constants with LTO r=glandium 2014-08-15 21:55:24 -04:00
Jeff Gilbert
691712da17 Bug 1049957 - Fixes from reviews. - r=kamidphish 2014-08-15 17:38:09 -07:00
Jeff Gilbert
794ccee7a4 Bug 1049957 - Use custom std::queue wrapper instead of std::queue<UniquePtr<T>>. - r=kamidphish 2014-08-15 17:38:08 -07:00
Jeff Gilbert
7e8c7b365e Bug 1049957 - Fix compilation errors. - r=kamidphish 2014-08-15 17:38:08 -07:00
Jeff Gilbert
2cf705f5f5 Bug 1049957 - Use UniquePtr for SharedSurface, SurfaceFactory. - r=kamidphish 2014-08-15 17:38:08 -07:00
Jeff Gilbert
16a3efd798 Bug 1049957 - Use RefPtr for SurfaceStream. - r=kamidphish 2014-08-15 17:38:07 -07:00
Jeff Gilbert
163982a614 Bug 1049957 - Use UniquePtr for GLScreenBuffer. - r=kamidphish 2014-08-15 17:38:07 -07:00
Jeff Gilbert
6d76c9667b Bug 1049957 - Increase MakeUnique max params to 8. - r=waldo 2014-08-15 17:38:06 -07:00
Bill McCloskey
163cfc3cc8 Bug 950745 - Back out assertions that are triggering too often 2014-08-15 16:16:42 -07:00
Bill McCloskey
847e144f39 Bug 1046964 - Remove some dead code (r=Waldo) 2014-08-15 16:14:50 -07:00
James Graham
f8790c7e21 Bug 1023371 - Refactor mozcrash to seperate out the IO from the stack inspection, r=ted.mielczarek
This makes it compatible with structured logging.
2014-08-15 23:19:34 +01:00
Ehsan Akhgari
846cc77ddd Bug 1053792 - Fix some bad implicit constructors in the mtransport code; r=jesup 2014-08-15 17:41:29 -04:00
Catalin Badea
e92b05a6af Bug 853995 - Move plugin parameters array from nsPluginInstanceOwner to content. r=johns,jst 2014-08-15 14:24:40 -07:00
Ryan VanderMeulen
b364e001aa Backed out changeset 926c83cd24f0 (bug 1052751) for B2G reftest failures. 2014-08-15 17:15:26 -04:00
Terrence Cole
374265c0dd Bug 1033442 - Remove non-pod malloc from MallocProvider and AllocPolicy; r=jonco 2014-08-08 13:22:39 -07:00
Ryan VanderMeulen
d4dde7eee6 Merge m-c to inbound. a=merge 2014-08-15 17:04:03 -04:00
Ryan VanderMeulen
24a88dd7d4 Merge b2g-inbound to m-c. a=merge 2014-08-15 17:03:00 -04:00
Andrew McCreight
79ad34b9a6 Bug 1023585 - Remove suppression for AllocateArrayBufferContents now that the leak is fixed. r=khuey 2014-08-15 14:00:53 -07:00
Alexander Surkov
ef0231619d Bug 1053765 - Putting role=log on a table tag breaks row and cell accessibles, r=tbsaunde 2014-08-15 16:49:02 -04:00
Ryan VanderMeulen
89a7f707c8 Merge fx-team to m-c. a=merge 2014-08-15 16:22:55 -04:00
Ryan VanderMeulen
f623af92a3 Merge inbound to m-c. a=merge 2014-08-15 16:10:19 -04:00
Ryan VanderMeulen
752707192e Backed out 11 changesets (bug 1010740, bug 1054264, bug 1010739, bug 1042804, bug 1019035, bug 1010741, bug 1053884, bug 1054268) for frequent robocop failures.
Backed out changeset 31d4832196f6 (bug 1054268)
Backed out changeset 9e0e63359e77 (bug 1054264)
Backed out changeset 5083e681191a (bug 1054264)
Backed out changeset 7844cf23c521 (bug 1053884)
Backed out changeset dd1a8ebbfae3 (bug 1042804)
Backed out changeset e56bbc8b5bd0 (bug 1019035)
Backed out changeset 6908f8780c29 (bug 1010740)
Backed out changeset aaa50f34df6d (bug 1010740)
Backed out changeset 8474627f88d5 (bug 1010739)
Backed out changeset cbb72f0aa532 (bug 1010741)
Backed out changeset 54179c9a121a (bug 1010741)
2014-08-15 15:12:45 -04:00
Andrei Oprea
47856d7740 Bug 990678 - Add ability to make audio only calls in Loop standalone and desktop. r=Standard8 2014-08-15 19:45:31 +01:00
B2G Bumper Bot
88f1f148ae Bumping manifests a=b2g-bump 2014-08-15 11:41:18 -07:00
B2G Bumper Bot
81f65d4255 Bumping gaia.json for 4 gaia revision(s) a=gaia-bump
========

https://hg.mozilla.org/integration/gaia-central/rev/0cf972fdd11e
Author: Fernando Jiménez Moreno <ferjmoreno@gmail.com>
Desc: Merge pull request #22881 from ferjm/bug1049340.mobileiderroroverlay

Bug 1049340 - [Loop] Mobile Identity windows in background. r=alive

========

https://hg.mozilla.org/integration/gaia-central/rev/0fdda7e05d2a
Author: Fernando Jiménez <ferjmoreno@gmail.com>
Desc: Bug 1049340 - [Loop] Mobile Identity windows in background. r=alive

========

https://hg.mozilla.org/integration/gaia-central/rev/e64db1140d6f
Author: James Burke <jrburke@gmail.com>
Desc: Merge pull request #22908 from jrburke/bug1001629-email-notification-close-blank

Bug 1001629: email notification clear triggers failure in startup r=asuth

========

https://hg.mozilla.org/integration/gaia-central/rev/d45cc778051b
Author: jrburke <jrburke@gmail.com>
Desc: Bug 1001629: email notification clear triggers failure in startup
2014-08-15 11:35:31 -07:00
Ryan VanderMeulen
be4bea7d04 Bug 1026805 - Disable frequently-hanging mozapps tests on OSX. a=me 2014-08-15 14:32:11 -04:00
Ralph Giles
fcb6f98d56 Bug 1047486 - Don't crash on null VideoData. r=cpearce
Avoid crashing when we can't create a VideoData object for
the decoded data MacOS X returns.
2014-08-15 11:24:00 -07:00
Alexander Surkov
552d26a301 Bug 1053998 - add few bits for doclifecycle logging, r=tbsaunde 2014-08-15 16:24:22 -04:00
Jeff Muizelaar
b896779c48 Bug 1054474. Change FPSCounter to not use ToSecondsSigDigits(). r=BenWa
ToSecondsSigDigits is slower and broken on Windows and doesn't
really provide any value in this case.

--HG--
extra : rebase_source : 889657d9bd1e7a2bc4bd2f8b2da16fac63ece822
2014-08-15 15:54:05 -04:00
B2G Bumper Bot
539d6aefd5 Bumping manifests a=b2g-bump 2014-08-15 11:16:38 -07:00
B2G Bumper Bot
2dd793d018 Bumping gaia.json for 1 gaia revision(s) a=gaia-bump
========

https://hg.mozilla.org/integration/gaia-central/rev/5ba6f889689b
Author: Fernando Campo <fernando.campo@telefonica.com>
Desc: Bug 1016813 - [FTU] Update to use gaia-header (r=fcampo)
2014-08-15 11:05:34 -07:00
Wes Johnston
eed933d432 Bug 1050403 - Update widget style. r=margaret 2014-08-15 11:04:36 -07:00
Lucas Rocha
cb83f28fbf Bug 1054268 - Show search icon in about:home (r=margaret) 2014-08-15 18:23:20 +01:00