Commit Graph

542 Commits

Author SHA1 Message Date
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
9805cdce23 Merged 2008-06-13 16:22:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
835100b96d Fixed some minor bugs -- the name of the incoming shared folder is parsed correctly, and xmppClient now catches bounce errors that were previously parsed as messages. 2008-06-13 16:20:43 -07:00
Atul Varma
92583fc5ff Fixed an 'outstanding callbacks' warning and simplified the code a tiny bit. 2008-06-13 15:39:06 -07:00
Myk Melez
b12f3d03db use nsIXMLHttpRequest::mozBackgroundRequest instead of DummyAuthProvider to suppress authentication dialogs and ensure XMLHttpRequests succeed even when the window that originated the request goes away 2008-06-13 13:08:36 -07:00
Dan Mills
589f3222eb To avoid some async.js warnings: Turn some 'yield' calls into 'return' ones, and don't call 'self.cb' twice in a row when constructing event listeners for XHRs. 2008-06-13 15:49:18 +09:00
Dan Mills
9812ba557e Make some 'debug' log calls into 'trace' ones. Use the frame formatter, which will remove long paths to extension dirs from the output. Don't warn about outstanding callbacks if we caught an exception from the generator. 2008-06-13 15:47:41 +09:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5c8481de3d Merged 2008-06-12 17:35:57 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
c548d4b940 Made the initialization of the xmppClient an asynchronous call. This included modifying xmppClient.js so that connect() can be passed a callback function that will get called once the connection has succeeded or failed. For most of our purposes this is probably a better API than what we had before where you call waitForConnection() and it busy-waits until the connection has succeeded or failed. 2008-06-12 17:35:44 -07:00
Myk Melez
b4967c8831 work around XmlHttpRequest bug 317600 by pausing for a 0ms timeout before trying to log in 2008-06-12 16:23:59 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b462aad4a5 Merged changes. 2008-06-12 14:30:46 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
2b055a3b87 Fixed the server URL for xmpp connections. 2008-06-12 14:30:39 -07:00
Myk Melez
18d8e8fcd7 bug 410550: stop running scheduled sync when the user is not logged into weave 2008-06-12 12:36:58 -07:00
Atul Varma
9d32240087 Changed some of the debug() logging statements I added a few commits ago into trace() statemetns b/c they were drowning the log. 2008-06-12 12:00:19 -07:00
Myk Melez
f47209b9d2 only retrieve score once per engine when doing a scheduled sync, since retrieving the score can be a non-negligible cost for trackers that calculate the score on-demand (like the tab tracker) 2008-06-11 20:07:35 -07:00
Myk Melez
669e57136f Automated merge with ssh://hg.mozilla.org/labs/weave/ 2008-06-11 20:00:59 -07:00
Myk Melez
5d50fffd37 don't sync tab entry IDs, which change with every session, to avoid generating edit commands for every tab on restart even when the tabs haven't actually changed 2008-06-11 20:00:48 -07:00
Atul Varma
4864f07ae2 async.js now keeps track of how many outstanding callbacks it has and uses this information to log warnings about coroutines that may have yielded without an outstanding callback, and coroutines that may have finished while a callback is still outstanding. These are merely 'warnings' rather than certainties because this code assumes that there is a 1:1 correspondence between accesses to self.cb and yields, and also that self.cb's are actually passed to asynchronous functions. It'd be really cool if we could actually keep track of whether a callback got garbage collected before it was called or something, though I don't know how much it'd help in the end. 2008-06-11 19:19:16 -07:00
Atul Varma
7d98a5dbeb Added a few log messages to hopefully make the debugging of generators easier. Also added an id component to generators, which is part of their name, to help distinguish between concurrent instances of the same generator function. The following debug output represents the new logging infomation:
--
Async.Generator	DEBUG	 runTestGenerator-0: self.cb generated at test_async_missing_yield.js:28
Async.Generator	DEBUG	 secondGen-1: self.cb generated at test_async_missing_yield.js:20
Async.Generator	DEBUG	 secondGen-1: done() called.
Async.Generator	DEBUG	 runTestGenerator-0: self.cb() called, resuming coroutine.
Async.Generator	DEBUG	 runTestGenerator-0: done() called.
Async.Generator	DEBUG	 secondGen-1: self.cb() called, resuming coroutine.
Async.Generator	DEBUG	 secondGen-1: done() called.
Async.Generator	ERROR	 Async method 'secondGen-1' is missing a 'yield' call (or called done() after being finalized)
--

As you can see, I've added log messages whenever the Generator's 'cb' property is accessed--this is almost guaranteed to be very close to a 'yield' statement, and therefore provides us with a decently accurate idea of where the generator 'stopped'.  We also log a message when the generator continues, and by doing so we get an idea of how the coroutines interleave.

Another idea I had was to actually match calls to self.cb with calls to 'yield' to automatically detect e.g. two yields in a row (which will ordinarily result in a generator 'hanging'), a generator exiting while a self.cb still hasn't been called, but I'm not sure what kinds of reprecussions it may have.
2008-06-11 18:58:30 -07:00
Myk Melez
a850ec7b70 numChanged should be the number of shared items whose data is different, not the same 2008-06-11 18:47:56 -07:00
Atul Varma
28a0971380 Merged changes. 2008-06-11 18:03:11 -07:00
Atul Varma
78c2bba04d Added test_async_missing_yield. It's very messy right now and duplicates code from other tests, but I've got some ideas about how to write better tests for async ops that I'll commit soon. 2008-06-11 18:02:46 -07:00
Maria Emerson
7da4259fee bug 438033: implement a better first-run wizard process; r=myk 2008-06-11 17:56:02 -07:00
Myk Melez
f9ef596828 Automated merge with ssh://hg.mozilla.org/labs/weave/ 2008-06-11 17:45:54 -07:00
Myk Melez
0a15090c8c bug 437529: yield after starting to put the status file to the server so we don't finalize the sync until the PUT request completes 2008-06-11 17:44:08 -07:00
Atul Varma
d32ba01952 Modified test_async_exceptions to use a fake nsiTimer. 2008-06-11 17:10:39 -07:00
Atul Varma
561d94aa66 Added a unit test for async exceptions. 2008-06-11 16:38:22 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
97f788bb51 Fixed Utils.prefs.getStringPref (should be getCharPref) 2008-06-11 15:43:12 -07:00
Myk Melez
8182b10abf resetting the score is not an asynchronous operation, so Service::_syncEngine shouldn't yield after calling it 2008-06-11 15:23:54 -07:00
Myk Melez
633afe0864 clarify wording in scheduled sync threshold debug statements 2008-06-11 14:16:03 -07:00
Myk Melez
555b8a7be4 fix typo in recent checkin that broke appending deltas to the deltas file on the server 2008-06-11 14:14:04 -07:00
Myk Melez
2b2192aca5 once sync thresholds reach 1 (the lowest possible value), leave them there until something changes and we sync 2008-06-11 13:50:47 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5459e1733a Resolved merging conflicts to service.js. 2008-06-11 11:54:44 -07:00
jonathandicarlo@localhost
4bb05d10b5 Created preferences for xmpp connection info (server url, realm, username, password), and a preference to turn xmpp messaging on or off, and made BookmarkEngine._init() call startXmppClient when this preference is true. 2008-06-11 11:13:35 -07:00
jonathandicarlo@localhost
918cc51c7f Expanded bookmarkEngine.share and added some more todos for the next round of functions to implement 2008-06-11 11:01:45 -07:00
Myk Melez
932871d1bd merge 2008-06-11 10:41:57 -07:00
Myk Melez
4a8808e790 bug 430363: ignore remove commands when generating deltas for history so the deltas file on the server doesn't grow too large; r=thunder 2008-06-11 10:40:24 -07:00
Myk Melez
482d745360 bug 434816: use a decreasing threshold algorithm for the periodic scheduled sync to make sure we eventually sync even small changes to data; r=thunder 2008-06-11 10:38:25 -07:00
Dan Mills
5ca3a1eb7f merge upstream changes 2008-06-11 23:31:28 +09:00
Myk Melez
0f8b279e6e give Engine a public getter for its snapshot that TabTracker can access when generating a sync urgency score 2008-06-11 00:03:28 -07:00
Dan Mills
de1d1acb26 Various changes:
Engine/RemoteStore:
* Move code to make the engine remote directory into RemoteStore.
* Fix initSession call in Engine to properly use callback / call yield.
* Do not check '_getServerData' return status in _sync, we will use exceptions from RemoteStore instead.
* Move code to push a new delta into RemoteStore (appendDelta()).  Currently comments out code that forces a re-upload in cases where the server (engine) format version was different.  We may add this back later into RemoteStore (?).
* Note that this patch also removes the 'this._encryptionChanged' conditional, which I believe is currently useless (we never set it).
Service:
* When wiping the server (due to a server version mismatch), skip .htaccess files, since they are usually not user-modifiable.
2008-06-11 11:12:04 +09:00
Anant Narayanan
9cb5d2c8cc Make sync service check score before syncing: bug #434816 (r=thunder) 2008-06-10 13:45:37 -07:00
Atul Varma
9c1413e024 Factored out all the logging+async setup code from test_sharing.js into a new global function, makeAsyncTestRunner(), which turns an async.js-style generator into a unit test. 2008-06-09 20:51:23 -07:00
Atul Varma
9cc4da48c1 Refactoring: made a new function, Utils.makeTimerForCall(), which is used by test suites and async.js. 2008-06-09 19:30:11 -07:00
Atul Varma
98a85cbd23 Refactorings to test_sharing.js to make it use the async do_test_pending()/do_test_finished() calls. 2008-06-09 19:18:14 -07:00
Atul Varma
2905492e20 Added modules/sharing.js, which provides access to the RESTful sharing API, and a unit test suite. The unit test suite is pretty heinous right now and should get a bit of refactoring. 2008-06-09 18:55:26 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
dece7fdbd2 Merged 2008-06-09 18:44:21 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b22dd7428c Fixed a couple of minor bugs that were preventing bookmark share from starting (like, i was skipping enabled engines instead of disabled engines... duhh) 2008-06-09 18:44:13 -07:00
Atul Varma
6fc267b942 Fixed a bug that was causing failing unit tests using async.js to not properly report error conditions. 2008-06-09 18:40:30 -07:00
Atul Varma
813c1abb3f Added a POST method to dav.js. 2008-06-09 17:36:54 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
dc2d1940dd Moved the writing of the outgoing-share annotation on the bookmark folder to BookmarkEngine._share, where it makes a lot more sense than it does in the share.js dialog-box code where it used to be. 2008-06-09 16:49:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
7ca2dae349 Fixed a couple minor bugs that were preventing bookmark engine from starting up properly 2008-06-09 16:19:58 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a1c5da3eeb Renamed bookmarkeEngine methods so they make more sense with the new sharing model, e.g. updateAllIncomingShares instead of syncMounts. 2008-06-09 15:27:09 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6ad669df96 Merged 2008-06-09 12:13:03 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
dfdff82d82 The folder annotation for outgoing shared folders is now a string containing the username of the person the folder is being shared with. Also moved to using const strings in bookmark-menu-overlay.js. 2008-06-09 12:12:51 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
8573f956e3 Merged 2008-06-09 11:49:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b6a2028a3c Fixed my code so that BookmarkEngine._sync() now works correctly to call Engine._sync() and BookmarkEngine.syncMounts(), asynchronously. Added in some TODO comments about what's going to happen in the next round of refactoring. 2008-06-09 11:48:52 -07:00
Atul Varma
53f7206dec Just added a few semicolons that js2-mode warned me about. 2008-06-09 09:45:55 -07:00
Atul Varma
3bb8a88ccf Added more tests to test_async.js and documented them a bit. 2008-06-07 00:34:33 -07:00
Atul Varma
ce74084744 Fixed an inaccuracy in the async.js test suite. 2008-06-07 00:22:57 -07:00
Atul Varma
394167a10a Added a unit test suite for modules/async.js. 2008-06-06 21:40:30 -07:00
jonathandicarlo@localhost
f26ddc5f76 Added license block and explanatory comments to bookmarks.js 2008-06-06 19:28:01 -07:00
jonathandicarlo@localhost
98d1bf05f4 Made BookmarkEngine.sync() responsible for calling BookmarkEngine.syncMounts (to get the incoming shared bookmark folder contents), eliminating the FIXME that previously had this being called from special-case code in WeaveSvc.sync(). 2008-06-06 19:22:23 -07:00
chris@h-194.office.mozilla.org
30795b78b9 merging branches 2008-06-06 17:58:02 -07:00
chris@h-194.office.mozilla.org
062c813474 - Adding temporary button to load account creation form for sm-labs01 while work continues on the first run process.
- Minor reorganization of preferences, namely, moving the advanced debugging tools into a sub-dialog and ensure each have a descriptive confirmation prompt.
2008-06-06 17:57:16 -07:00
Atul Varma
29434b62a4 Merged changes. 2008-06-06 17:46:46 -07:00
Atul Varma
49ad148d83 In async.js, renamed 'object' to 'thisArg', which makes the code clearer and easier to understand. 2008-06-06 17:46:34 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
473352178e Resolved conflicts with Chris's changes (to use the username, unhashed, as the name of the server-side sharing directory) 2008-06-06 17:43:15 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
3db8dcb84c Moved _createShare and _share() from engines.js to BookmarkEngine class in engines/bookmarks.js. The identity of the folder to be shared is now passed from the share dialog box (share.xul) into BookmarkEngine._share(). 2008-06-06 17:33:44 -07:00
chris@h-194.office.mozilla.org
a800ba8d31 - turning in the bookmarks sharing UI, although it's still not fully functional. 2008-06-06 14:40:35 -07:00
chris@h-194.office.mozilla.org
d7c750f0f9 - this check in will break everyone temporarily, as it involves the changes necessary to shift us from sha1(email) to usernames, and to enable sharing on the server.
- we are also changing the default preferences on the trunk to point to the new staging server at https://sm-labs01.mozilla.org:81 that has been modified to support usernames
- everyone will need to create a new account and this will be streamlined within the startup function, which will now kick off on first run (we'll check in the updated setup wizard shortly)
- this checkin also cleans up a number of strings
2008-06-06 14:18:50 -07:00
Anant Narayanan
4298abcb95 Fix linux builds (bug 433922, r=thunder) 2008-06-05 17:21:53 -07:00
Myk Melez
f096ecbbf4 bug 437523: fix NS_ERROR_FAILURE on nsIJSON.decode in JsonFilter_afterGET 2008-06-05 16:25:55 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
12ae1f3d1c Re-disabled test_xmpp_simple.js; it shouldn't be run without a local jabber server (and it wasn't, until I accidentally comitted my local change enabling the test. 2008-06-05 12:18:16 -07:00
Dan Mills
b32b7d3549 merge upstream changes 2008-06-05 23:11:20 +09:00
Dan Mills
c2081e7fb9 create objects for the various server resources (these will later abstract away the actual resources); fix a bug where we were reversing the order of resource filters on every GET request 2008-06-05 16:17:32 +09:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a8012cad1d Merged 2008-06-04 20:30:56 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
e578f11c10 The menu icon of a bookmark folder now changes when that folder is being shared out with others. 2008-06-04 20:30:37 -07:00
Dietrich Ayala
406a97aee2 imported patch xmpp-transport-fault-tolerance-and-test 2008-06-04 18:34:37 -07:00
Dietrich Ayala
ecbfb93933 xmpp-stream-error-handling 2008-06-04 17:36:37 -07:00
Dietrich Ayala
3d3869c8a5 [mq]: xmpp-reconnect 2008-06-04 17:00:02 -07:00
Dietrich Ayala
3e4256b313 [mq]: xmpp-disconnect 2008-06-04 14:02:47 -07:00
Myk Melez
b3bf939ec2 bug 436696: make sure we pass a valid URI to nsITaggingService::getTagsForURI when the bookmark record doesn't include a URI so the method doesn't throw and hork bookmarks sync 2008-06-04 13:40:53 -07:00
Dietrich Ayala
6805970f17 [mq]: xmpp-cleanup 2008-06-04 12:14:28 -07:00
Dan Mills
f7003493a7 Bug 436303: Fix misspelling 2008-06-04 23:07:07 +09:00
Atul Varma
d3d41cc696 Added a basic testing suite for engines/passwords.js. It currently only tests _hashLoginInfo() and PasswordSyncCore._itemExists(). 2008-06-03 18:37:36 -07:00
Atul Varma
3a9ddcad85 In passwords.js, turned _hashLoginInfo() into a module-level function. 2008-06-03 16:56:58 -07:00
Atul Varma
d8420aaf50 Minor js2-mode warning fixes. 2008-06-03 15:14:27 -07:00
Atul Varma
e5bb509e17 Removed unused code from cookies.js, fixed a few js2-mode warnings. 2008-06-03 14:49:22 -07:00
Atul Varma
b74958a214 Moved all tab-syncing code to modules/engines/tabsjs. 2008-06-03 14:45:53 -07:00
Atul Varma
daf3be7564 Moved all form-syncing code into modules/engines/forms.js. 2008-06-03 14:20:51 -07:00
Atul Varma
1e0a1d1e06 Moved all password-syncing code into modules/engines/passwords.js. 2008-06-03 14:08:53 -07:00
Atul Varma
e2ce660c53 Moved all history-related functionality into modules/engines/history.js. 2008-06-03 13:56:16 -07:00
Atul Varma
f365f924cf Re-removed cookie-related changes that were accidentally re-added by c1a58b24679c and/or 5a49daf87c94.
Also moved all bookmark syncing logic into modules/engines/bookmarks.js.
2008-06-03 12:38:48 -07:00
Myk Melez
d635f80fdc remove unused _json property from TabSyncCore 2008-06-03 11:50:08 -07:00
Myk Melez
690e2b800c merge 2008-06-03 11:43:07 -07:00
Myk Melez
07ba8ea83e bug 434817: sync tabs 2008-06-03 11:32:59 -07:00
Atul Varma
ada0204cac Moved all code related to the syncing of cookies--e.g. CookieStore, CookieTracker, CookieEngine, CookieSyncCore--into their own file at modules/engines/cookies.js. I'll be doing the same to the other engines shortly.
This helps with code organization--all the logic for dealing with a particular data type is now in one place--and should also make it easier to write unit/regression tests.
2008-06-03 11:11:44 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
c3c783a630 Merged changes 2008-06-02 20:14:00 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
8dd60a75cb Bookmark share now leaves an annotation ('weave/share/sahred_outgoing' = true or false) on a bookmark folder to note whether it's being shared or not; when a folder is being shared, the menu item in the folder submenu changes to 'Stop sharing this folder'. 2008-06-02 20:13:46 -07:00
Myk Melez
2d0bcb7a9b minor typo fixes 2008-06-02 15:24:52 -07:00
Dan Mills
d526a56d57 log stack traces from sync exceptions 2008-06-02 13:02:04 +09:00
Dan Mills
5eac28e81c change remote store to keep track of identity names/aliases and fetch the objects from the id manager 2008-06-02 11:10:11 +09:00
Dan Mills
2daecc268e move json and crypto into remote resource 'filters', so the engine doesn't have to explicitly encode/decode anything. note--known regression: filters will not use the encryption algorithm in the status file 2008-05-30 20:43:55 -07:00
Dan Mills
5ac797d47a branch merge 2008-05-30 18:54:57 -07:00
Dan Mills
f36b66b136 only require the .rc file on windows 2008-05-30 18:53:07 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
f9c2868a77 Merged changes. 2008-05-30 18:20:02 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5ed074f466 Made the bookmark-share dialog box display the name of the folder you selected; also, the 'Share This Folder' menu text is now pulled from share.properties for easier i18n. 2008-05-30 18:19:47 -07:00
Dan Mills
0640f244d6 format exception correctly when an engine throws during sync 2008-05-30 17:40:08 -07:00
Dan Mills
edff2a32aa make some async generator errors clearer 2008-05-30 17:38:27 -07:00
Atul Varma
2271e34077 Added a simple test to test_fault_tolerance.js that wasn't working before, but now is, and I don't know why... 2008-05-30 17:02:25 -07:00
Atul Varma
b9a3944d7e Added a trivial appender to faultTolerance.js. 2008-05-30 16:32:06 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
7ded706053 Fixed broken unit test test_cookie_store.js 2008-05-30 13:52:39 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
e9a097b252 Merged changes 2008-05-30 11:11:02 -07:00
Atul Varma
243f1bce21 Refactored logging system so that clients don't need to call factory functions to create specific instances of formatters and appenders. 2008-05-29 18:15:50 -07:00
Atul Varma
8b2854d7e6 Added a testing suite for log4moz, along w/ a few refactorings necessary to perform the tests. 2008-05-29 17:56:52 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4343b5c692 Merged 2008-05-29 11:18:16 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6031b5a316 Moved the Share Bookmarks item out of the Weave popup menu into the Bookmarks menu, folder submenu. 2008-05-29 11:17:54 -07:00
Dan Mills
88bafd3245 Add and start using an object to represent a remote resource (file), and a server object to hold them. Resources will attempt to retry network operations if they fail. 2008-05-28 20:11:39 -07:00
Atul Varma
c00c81efab Added a trivial fault tolerance JS module with a trivial test suite. 2008-05-28 11:25:28 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
c8b1c91b51 Created a cookie tracker in trackers.js, and a test for it in tests/unit/test_cookie_store.js. 2008-05-27 09:44:26 -07:00
Dan Mills
ecd321f34b bump version constant 2008-05-24 18:56:42 -07:00
Dan Mills
c682a760f9 remove some debugging output, fix some remaining array detection code 2008-05-24 17:30:22 -07:00
Dan Mills
fd0eac8eb3 continue sync of other engines even after one of them throws an exception; use constructor name instead of instanceof to check for array object in modules 2008-05-23 23:58:53 -07:00
Dan Mills
fe48398743 don't attempt to get a symkey if encryption is set to 'none' 2008-05-23 19:57:38 -07:00
Dan Mills
cb84d724f5 regenerate the engine id when the engine's pbe id changes 2008-05-23 19:47:25 -07:00
Dan Mills
29fc114d14 branch merge 2008-05-23 17:58:08 -07:00
Dan Mills
289a78e226 merge 2008-05-23 17:52:10 -07:00
Dan Mills
8dbb0f835c whitespace police 2008-05-23 17:50:54 -07:00
Dan Mills
1cfce7d1d1 don't require same index for folder 'likeness' 2008-05-23 17:50:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
42f471fcd3 Added unit test file for CookieStore. It has a test to make sure that only persistent cookies are wrapped, not session cookies. 2008-05-23 17:49:58 -07:00
Atul Varma
04c6dda2c2 Fixed bug 427113: https://bugzilla.mozilla.org/show_bug.cgi?id=427113
I should note that I think that there's a more idiomatic way of doing what I did, but I don't yet fully understand how Weave does things asynchronously.  As such, this commit can probably be refactored to be more in the style of the surrounding code.
2008-05-23 12:22:08 -07:00
Atul Varma
0b8c18a3c7 Fixed bug 435103 (https://bugzilla.mozilla.org/show_bug.cgi?id=435103) 2008-05-23 12:08:03 -07:00
Atul Varma
7376e01e44 Routine merge of double branches. 2008-05-23 11:06:45 -07:00
Atul Varma
ba3e131c29 Fixed a variety of style issues and minor warnings raised by js2-mode. 2008-05-23 11:05:42 -07:00
Anant Narayanan
85746789b0 Correct more syntax errors (super) in trackers.js 2008-05-23 11:01:32 -07:00
Anant Narayanan
e94def6b15 Correct syntax error in trackers.js 2008-05-23 10:28:43 -07:00
Anant Narayanan
7d0ca60e94 Fix indentation 2008-05-23 09:59:35 -07:00
Anant Narayanan
45c306c019 Add tracking support to FormsEngine. Bug #435319, r=thunder 2008-05-23 09:29:26 -07:00
Dan Mills
ef799c5a38 fix build regression in windows from linux fixes 2008-05-22 18:52:52 -07:00
Anant Narayanan
226ed028e3 Tracking support for HistoryEngine. Bug #435321, r=thunder 2008-05-22 18:37:24 -07:00
Anant Narayanan
1743ffc42e Correct typo in BookmarksTracker 2008-05-22 18:06:47 -07:00
chris@h-124.office.mozilla.org
68401ecb36 resolving merge conflicts 2008-05-22 16:52:51 -07:00
chris@h-124.office.mozilla.org
348ed6d732 replacing minefield logo with weave logo 2008-05-22 16:04:56 -07:00
Anant Narayanan
53d8c30531 Add support for engine 'scores'. Bug #434812, r=thunder 2008-05-22 15:58:29 -07:00
Anant Narayanan
36482f8bef Sync form data: bug #434818, r=thunder 2008-05-22 15:36:44 -07:00
chris@h-124.office.mozilla.org
7ca2d67bc7 cleaning up strings in sync prefs 2008-05-22 14:15:35 -07:00
Atul Varma
30327e66a7 Changeset c5a909fd128d (r336 on hg.mozilla.org) seems to have broken the OS X build, because there is no xpcom_core library on OS X, so I've modified the Makefile so that the library is only included if we're on Linux. I'm not sure what this will do for Windows builds, though, so it may break the build on Windows. 2008-05-22 11:44:51 -07:00
Dietrich Ayala
26b658a127 Bug 419121 - Weave chokes on microsummaries (r=thunder) 2008-05-22 11:41:05 -07:00
Justin Dolske
8df51016ac Bug 433762 – Sync stored passwords. r=thunder 2008-05-21 18:09:19 -07:00
Justin Dolske
1fb1cf3fa3 Cleanup some trivial nits with cookie (whitespace and function name). 2008-05-21 17:53:35 -07:00
Anant Narayanan
d0ee5b17d4 Allow login & sync when encryption is off 2008-05-21 16:28:23 -07:00
Anant Narayanan
ba0fa55299 Typo in log message 2008-05-21 11:16:39 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a020c7c1bc Merged my changes with Anant's changes 2008-05-20 18:24:49 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
9340b3c431 Added TODO that expired cookies should be thrown out, in the unlikely event that we get one from a createCommand or editCommand. 2008-05-20 18:24:28 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
aea75cbd20 Made cookie-sync sync only persistent cookies, drop single-session cookies. (Needs testing.) 2008-05-20 18:14:18 -07:00
Anant Narayanan
203ee08ca3 Patching to support building component on Linux. 2008-05-20 16:53:14 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
7793fe3db1 Created some documentation of how to add synchronization functionality for a new user data type to Weave. Created a new directory called docs to put this into. 2008-05-19 19:40:45 -07:00
Dan Mills
2c39623eab DAV: separate the root url of the DAV repository from the default prefix for all operations (i.e., the user's subdirectory) 2008-05-15 18:08:13 -07:00
Dan Mills
9535362dc5 more windows (msvc) build fixes 2008-05-14 17:15:55 -07:00
Dan Mills
779a934ce3 windows build fixes for crypto component 2008-05-13 18:37:07 -07:00
Dan Mills
adb0b31cb6 temporarily disable xmpp unit test 2008-05-12 10:18:20 -07:00
Dan Mills
2aa793313d merge with jono's changes 2008-05-12 10:14:15 -07:00
Dan Mills
e5e1d00a3f sync bookmark descriptions 2008-05-12 10:11:07 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
11d82ab309 Created a readme for using the XMPP client module. 2008-05-08 18:50:12 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
7bd1d2d781 Expanded test_xmpp -- currently failing tests but it's got the setup now for timing out and failing if the expected message is not received. 2008-05-07 15:29:42 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b604dfc445 Made a very simple unit test for xmppClient; it's passing, but currently it connects to the hard-coded URL of a jabber server running on localhost; I'll need to change this if other people are going to be able to run this test. 2008-05-06 13:13:26 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
c2d09e5829 renamed testSynchronizer.js to just synchronizer.js, because otherwise the test framework tries to run it as a test itself. 2008-05-06 12:04:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
90053f0c73 Oops, I miscapitalized XmppClient in the export statement -- fixed. 2008-04-30 17:08:39 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
2fec756b19 Made xmppClient, transportLayer, and authenticationLayer into proper modules using Components.Utils. Also renamed the JabberClient class to XMPPClient, which is more accurate (as it implements XMPP which is a newer protocol than Jabber.) 2008-04-30 16:55:34 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
e8b52e9413 Gave sasl.js a more descriptive name -- authentication is what it does.
--HG--
rename : services/sync/modules/xmpp/sasl.js => services/sync/modules/xmpp/authenticationLayer.js
2008-04-30 16:29:03 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
8fda2ee763 Merged my changes with the main repository. 2008-04-30 16:27:52 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
0251715f68 First commit of my XMPP client, as demonstrated at the meeting today, to weave/modules. This does not include the test-synchronization stuff. xmppClient.js is the main client class; transportLayer.js and sasl.js (which does authentication) are the helper classes. 2008-04-30 16:27:32 -07:00
Dan Mills
d205f55def add a simple unit test harness based on xpcshell; add two tests for PBE and to load all the modules; add some hacks to the component's makefile to make tests work correctly 2008-04-30 13:01:17 -07:00
Dan Mills
2689bfa5b9 add a c++ crypto component, ported from bug 400742; with a specialized makefile to build in the extension (with the gecko sdk) 2008-04-25 18:28:31 -07:00
Dan Mills
63af6c5dbd service: remove accidental 'resetServer' call in sync (\!); dav: lock a file called 'lock', instead of the entire collection (workaround for bug 421610) 2008-04-16 14:46:57 -07:00
Dan Mills
6670eb2948 engines now get the pbe identity directly from the identity manager; engines now know their 'enabled' status (pref); main service syncs *all* registered (enabled) engines 2008-04-15 17:21:34 -07:00
Dan Mills
5a2d0451db add engine registration service; use global id service in service.js 2008-04-14 18:53:35 -07:00
Dan Mills
83fd7d6261 Various improvements:
* async generators: much better stack traces
* dav: use global identity system rather than login/logout to manage
  usernames and passwords.
* dav: there is a checkLogin() instead of login() which can be used to
  verify auth at any time.
* dav: make it so that we can (only internally atm) hold multiple
  locks for different URLs.
* identity: add an identity manager singleton service to keep
  identities globally, referenced by a name, with aliasing support (so
  e.g., dav can ask for the 'dav' identity, while something else can
  alias 'dav' to another identity).
* service: keep track of logged in status here, rather than in the dav
  service.  Use the global id manager.
2008-04-10 21:38:15 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
62da55a446 Implemented cookieStore.editCommand(). 2008-04-07 11:53:55 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
055836a4ee Semicolon was missing in cookieStore.wrap() 2008-04-04 12:09:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
de75398691 Prettied up my code by using block comments and making my indents 2 spaces. 2008-04-04 12:08:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
02171a4c9b Merged changes from Dan 2008-04-04 10:50:21 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
185294a6e6 Removed comment from load-weave.js that I put in while debugging and committed by accident. 2008-04-04 10:49:41 -07:00
Dan Mills
99f4ac9084 rethrow exception when applyCommands fails; merge changes from jono 2008-04-03 17:18:38 -07:00
Dan Mills
edd4329c4a rethrow exception when applyCommands fails 2008-04-03 17:16:22 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
acbff936ba Discovered that trying to use duck-typing in passing an object into cookieExists() will hard-crash Firefox, and figured out why; added comment to syncCores.js explaining this. 2008-04-03 14:30:34 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
27c6454920 Fixed bugs in cookieSyncCore.itemExists and cookieStore.addCommand. The problem in addCommand was just a missing argument, but in itemExists I had to change the implementation to use cookieManager.enumerator rather than cookieManager.findMatchingCookie -- the latter function apparently does not exist in the nsICookieManager2 interface despite what MDC says about it. 2008-04-03 14:26:06 -07:00
Dan Mills
d1bd5e5aaa don't fail on invalid server deltas which don't apply to the local snapshot; wipe the local snapshot instead 2008-04-02 00:00:24 -07:00
Dan Mills
8df3c78b61 bump version 2008-04-01 23:44:39 -07:00
Dan Mills
a4b0ed4a6e make login more robust, specially work around first-login oddities with services.m.c 2008-04-01 23:43:14 -07:00
jono@jono-gibbon-laptop
f6dd9c5d7f Updated the comment in CookieStore.editCommand. 2008-04-01 19:16:27 -07:00
jono@jono-gibbon-laptop
0640b8474c Removed some lines that were only in there for debugging purposes. 2008-04-01 19:12:03 -07:00
jono@jono-gibbon-laptop
4ad1b9c94f Fixed some minor errors in cookieStore / cookieSyncCore (still getting used to the getter idiom in javascript -- had too many underscores). Syncing cookies now works in as much as it can upload all cookies to the server without raising any exceptions; now to see if it can download and merge cookies on the other side... 2008-04-01 17:51:10 -07:00
jono@jono-gibbon-laptop
b405d397ce Fixed a couple of missing symbol exports that were stopping CookieEngine from being able to be instantiated. 2008-04-01 17:32:14 -07:00
jono@jono-gibbon-laptop
609b043699 Fixed a couple of syntax errors that were preventing weave from starting 2008-04-01 16:36:08 -07:00
jono@jono-gibbon-laptop
640267d614 Merged changes and resolved conflicts between my cookie stuff and r282. 2008-04-01 14:46:29 -07:00
Dan Mills
b8cca5d3a9 bump version 2008-03-31 17:46:29 -07:00
Dan Mills
e4254ee7bd fix tag sync 2008-03-31 17:07:40 -07:00
Dan Mills
27580b967a hide share bookmarks menu item; clean up ui init code 2008-03-31 16:55:54 -07:00
Dan Mills
1cbfe5b3e3 add warnings to reset client/server data buttons in the prefs 2008-03-31 16:24:43 -07:00