wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

To avoid some async.js warnings: Turn some 'yield' calls into 'return' ones, and don't call 'self.cb' twice in a row when constructing event listeners for XHRs.

Browse Source
This commit is contained in:
Dan Mills 2008-06-13 15:49:18 +09:00
parent 9812ba557e
commit 589f3222eb
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
services/sync/modules/dav.js
View File

@ -127,8 +127,9 @@ DAVCollection.prototype = {
let request = Cc["@mozilla.org/xmlextras/xmlhttprequest;1"].createInstance();
request = request.QueryInterface(Ci.nsIDOMEventTarget);
request.addEventListener("load", new Utils.EventListener(self.cb, "load"), false);
request.addEventListener("error", new Utils.EventListener(self.cb, "error"), false);
let cb = self.cb;
request.addEventListener("load", new Utils.EventListener(cb, "load"), false);
request.addEventListener("error", new Utils.EventListener(cb, "error"), false);
request = request.QueryInterface(Ci.nsIXMLHttpRequest);
request.open(op, this._baseURL + path, true);
@ -318,7 +319,7 @@ DAVCollection.prototype = {
if (this._authProvider._authFailed ||
resp.status < 200 || resp.status >= 300) {
self.done(false);
yield;
return;
}
self.done(true);
@ -364,7 +365,7 @@ DAVCollection.prototype = {
if (DAVLocks['default']) {
this._log.debug("Lock called, but we already hold a token");
self.done(DAVLocks['default']);
yield;
return;
}
this.LOCK("lock",
@ -376,10 +377,8 @@ DAVCollection.prototype = {
let resp = yield;
if (this._authProvider._authFailed ||
resp.status < 200 || resp.status >= 300) {
self.done();
yield;
}
resp.status < 200 || resp.status >= 300)
return;
let tokens = Utils.xpath(resp.responseXML, '//D:locktoken/D:href');
let token = tokens.iterateNext();