Commit Graph

124788 Commits

Author SHA1 Message Date
Bobby Holley
3d757075f3 Bug 658909 - Remove GWNOJO from XPCVariant. r=mrbkap
The old code seems to be deciding whether we have a double-wrapped object by
checking _either_ the rv of GWNOJO _or_ the potential slim wrapper. This is
nonsensical, because double-wrapped objects are never slim wrappers.
Furthermore, that variable here is named 'proto', which further suggests
that this code is nonsensical. So let's just check for WNs.

Also, it seems pretty wack to be innerizing here before storing the jsval,
but I'm going to leave that for now.
2013-03-16 22:58:16 -07:00
Bobby Holley
8e8f39d378 Bug 658909 - Remove GWNOJO from XPCJSID. r=mrbkap 2013-03-16 22:58:15 -07:00
Bobby Holley
a8c785d855 Bug 658909 - Remove GWNOJO from JSValToXPCException. r=mrbkap 2013-03-16 22:58:15 -07:00
Bobby Holley
e2dd3437b4 Bug 658909 - Remove GWNOJO from JSObject2NativeInterface. r=mrbkap 2013-03-16 22:58:15 -07:00
Bobby Holley
5d5d5bcfac Bug 658909 - Remove GWNOJO for helper stubs. r=mrbkap 2013-03-16 22:58:15 -07:00
Bobby Holley
acebe495da Bug 658909 - Remove GWNOJO from MarkWrappedNative. r=mrbkap 2013-03-16 22:58:15 -07:00
Bobby Holley
d09761116c Bug 658909 - Add a new, much simpler API for getting WNs from JS objects. r=mrbkap 2013-03-16 22:58:15 -07:00
Bobby Holley
d18489beb3 Bug 658909 - Stop doing all the crazy stuff in GetWrappedNativeOfJSObject. r=mrbkap 2013-03-16 22:58:14 -07:00
Bobby Holley
0517579b24 Bug 658909 - Add a hack to support calling nohelper XPCWN methods without the proper |this|. r=mrbkap 2013-03-16 22:58:14 -07:00
Bobby Holley
35d97256a4 Bug 658909 - Use JS_{,Strict}PropertyOp instead of null when defining value props in nsDOMClassInfo. r=mrbkap
Using JSPropertyOp means a null shape getter, whereas null means that the shape
uses the class getter. This means that stuff like window.top, which is defined
as a non-configurable |own| property in nsDOMClassInfo, was getting set up with
XPC_WN_Helper_GetProperty as its get operation. But this confused
SandboxProxyHandler, which explicitly avoids rebinding class getters/setters,
which in turn meant that our sandboxPrototype feature was relying on the crazy
prototype-climbing behavior of GetWrappedNativeOfJSObject to make stuff like
|this.top| work. We're removing this behavior, so we need to fix nsDOMClassInfo
here.

Here are some DefineProperty cases that I left with null getters/setters:
* nsDOMClassInfo::ResolveConstructor
* The child window stuff at the bottom of nsWindowSH::NewResolve
* Named item resolution in nsNamedArraySH::NewResolve
* document.all stuff (scary!)
* nsHTMLDocumentSH::NewResolve
* nsHTMLFormElementSH::NewResolve
* nsStorage2SH::NewResolve
2013-03-16 22:58:14 -07:00
Bobby Holley
6db2f10d4c Bug 658909 - Implement carefully-checked unwrapping in XPCCallContext. r=mrbkap 2013-03-16 22:58:14 -07:00
Bobby Holley
0ac4a08fc8 Bug 658909 - Set args at XPCCallContext construct time in XPC_WN_GetterSetter. r=mrbkap
It's not clear to me why it's done this way, but it confuses our ability to
determine during wrapper lookup whether we're doing a set or a get. This aligns
the behavior with XPC_WN_CallMethod, including passing JSID_VOID for the name
(which is safe because XPCCallContext explicitly special-cases JSID_VOID and
doesn't call SetName in that case).
2013-03-16 22:58:13 -07:00
Bobby Holley
3e05c5d01b Bug 658909 - Initialize the same fields in both XPCCallContext constructors. r=mrbkap
This is a huge footgun. XPCCallContext is hot, but it's not too hot to be safe
here. Garbage XPCWN and JSObject pointers are bad.
2013-03-16 22:58:13 -07:00
Bobby Holley
7d252db9d9 Bug 658909 - Remove unnecessary ccx param. r=mrbkap 2013-03-16 22:58:13 -07:00
Bobby Holley
98ec54a6bc Bug 658909 - Make isSafeToUnwrap pseudo-dynamic for SOWs. r=mrbkap
This can go away as soon as XBL scopes are no longer behind a pref.
2013-03-16 22:58:13 -07:00
Bobby Holley
b2282e03e7 Bug 658909 - Force |this| computation in SandboxCallableProxyHandler::call when using Xrays. r=bz
Comment says it all.
2013-03-16 22:58:12 -07:00
Daniel Holbert
fbb0c25aed Bug 848159: In jsopcode.cpp, cast formalIndex to be unsigned when comparing it against another unsigned value, since we've already asserted it's nonnegative. r=jandem 2013-03-16 21:38:06 -07:00
Bill McCloskey
bfa3037d1f Bug 759585 - Zones (r=jonco,bhackett,njn,dvander,luke,bz,mccr8,bholley) 2013-03-16 20:36:37 -07:00
Phil Ringnalda
835396f6b3 Back out 9bfca2900825 (bug 694254) for incompetent review 2013-03-16 20:35:53 -07:00
Nicolas B. Pierron
6af702a0f4 Bug 849014 - Check type inference before optimizing regexp calls. r=sstangl 2013-03-16 20:05:46 -07:00
Trevor Saunders
063ecdc9fb bug 694254 - disable test_focus_browserui.xul on win 7/8 to see if it fixes the leak rs=philor 2013-03-16 22:10:32 -04:00
Brian R. Bondy
65b9cefed5 Bug 849342 - Remember passwords preference does not take effect immediately. r=mbrubeck. 2013-03-16 22:12:09 -04:00
Chris Lord
15c14b3e12 Bug 850789 - Pin the dynamic toolbar on screen when the tabs tray is open. r=kats 2013-03-17 01:53:41 +00:00
Chris Lord
c59a4feed2 Bug 850154 - Fix alignment of find-in-page bar after bug 716403. r=sriram
Use the RelativeLayout.LayoutParams instead of LinearLayout.LayoutParams to
make sure the find-in-page bar is aligned to the bottom of the page.
2013-03-17 01:53:40 +00:00
Chris Lord
2ea639cdcb Bug 850724 - Don't hide toolbar on load, or pin while loading. r=kats
UX decisions have been made to not hide the toolbar after the page has finished
loading, and not to pin the toolbar during page loading. These decisions fix
this bug.
2013-03-17 01:53:40 +00:00
Gene Lian
51915dc1d0 Bug 847756 - B2G MMS: provide nsIDOMMobileMessageManager.markMessageRead(). r=vicamo sr=sicking a=leo+ 2013-03-11 12:14:15 +08:00
Phil Ringnalda
3774920f8e Back out 85f522534c5a (bug 829456) for apparently causing frequent failures in test_bug607464.html
CLOSED TREE
2013-03-16 18:28:48 -07:00
Phil Ringnalda
802b512b12 Back out f408dd29944c:db5c280d1907 (bug 827486) for probably having needed a clobber
CLOSED TREE
2013-03-16 18:16:37 -07:00
Gene Lian
110f31bc94 Bug 847736 - B2G MMS: provide nsIDOMMobileMessageManager.delete(). r=vicamo sr=sicking a=leo+ 2013-03-08 12:06:06 +08:00
Gene Lian
dcf1f7e4a0 Bug 847738 - B2G MMS: provide nsIDOMMobileMessageManager.getMessage(). r=vicamo sr=sicking a=leo+ 2013-03-08 11:46:16 +08:00
Norbert Lindenberg
10c5a08bbb Bug 837957 - Implement ICU dependent functions of Intl.Collator, Intl.NumberFormat, Intl.DateTimeFormat (part 4). r=jwalden
--HG--
extra : rebase_source : 0c6aaf4093c0c1f6bb6eb073d506378adf0c65ab
2013-03-16 16:39:58 -07:00
Jose Cortes
d8b4437a53 Bug 842186 - Replace use of jsval with JS::Value in cpp and h files in the content/events directory. r=jwalden
--HG--
extra : rebase_source : b1436faef9ffb4c9396d97d956c1a8ede7a2ad20
2013-03-16 16:39:51 -07:00
Jose Cortes
219e54a946 Bug 842186 - Replace jsvals with JS::Values in .cpp and .h files inside the ipc, security, tools, caps, xpfe and startupcache directories. r=jwalden
--HG--
extra : rebase_source : 17f26bc48a8ce01b7349adc178a4e62f7d4b3a5e
2013-03-15 22:22:01 -07:00
Jeff Walden
486c408fcc Bug 851673 - Assertion failure: v.isUndefined(), at jsarray.cpp. r=bholley
--HG--
extra : rebase_source : c898284ed6ec99afe15f4ea60af54282c544a3ac
2013-03-15 19:39:38 -07:00
Andrew McCreight
24600b1f22 Bug 827486, part 7 - add basic code gen test. r=bz 2013-03-16 16:22:23 -07:00
Andrew McCreight
4e041452ff Bug 827486, part 6 - generate headers and code for JS implemented WebIDL classes. r=bz 2013-03-16 16:22:23 -07:00
Andrew McCreight
0167b065ab Bug 827486, part 5: add the main JS impl code gen. r=bz 2013-03-16 16:22:22 -07:00
Andrew McCreight
94d24f2371 Bug 827486, part 4: copy parts of example generator to JS impl generator. r=bz 2013-03-16 16:22:22 -07:00
Andrew McCreight
0ea8eb9b20 Bug 827486, part 3 - add dependencies for CGBindingImplClass. r=bz 2013-03-16 16:22:22 -07:00
Andrew McCreight
7fa5dc2a56 Bug 827486, part 2 - Refactor example class codegen into common base class. r=bz 2013-03-16 16:22:22 -07:00
Andrew McCreight
5170ac7f5b Bug 827486, part 1: add JSImplementation extended attribute. r=bz 2013-03-16 16:22:22 -07:00
Patrick McManus
2ce9a088b7 bug 819044 - better spdy stream cleanup when handling goaway r=honzab
--HG--
extra : rebase_source : c3c1bebdbd75029630b7ab6030c945b2998cc653
2012-12-20 13:27:15 -05:00
Bill McCloskey
a36ab50676 Bug 792304 - Disable test_contextmenu.html on 10.8 2013-03-16 16:04:19 -07:00
Bill McCloskey
9a80036b52 Bug 802504 - Disable test_fullscreen-api.html on 10.8 2013-03-14 16:49:25 -07:00
Bill McCloskey
251d14b8b7 Bug 846150 - Disable 'Window has gone away' assertion (r=bsmith) 2013-03-13 15:32:27 -07:00
Brian Hackett
cd22e5de54 Bug 836968 - Cache shapes for JSON objects and assign types to constructed JSON objects and arrays, r=waldo,jandem. 2013-03-16 16:52:45 -06:00
Jonathan Watt
744dc354f2 Bug 851090 - Make <input type=range> fire change/input events as appropriate. r=mounir. 2013-03-16 05:49:41 +00:00
Drew Willcoxon
f56c3ad53d Bug 829456 - Update browser-fullZoom.js to use nsIContentPrefService2. r=mak 2013-03-16 15:12:31 -07:00
Phil Ringnalda
be75725f52 Merge inbound and m-c 2013-03-16 15:09:36 -07:00
Brian Hackett
1bef51ca40 Backout 04695ce03bb6 (bug 836968) for topcrashing on a CLOSED TREE 2013-03-16 15:57:39 -06:00