Other 3-dot menu button locations to follow.
I tested that the colors are correct in the various states (e.g. private
browsing).
This patch additionally:
* Restructured the menu button (which allowed the removal of a setVisibility
call
* Removed the now unused tablet assets.
And replace the older assets.
These are the 36dp icons from Google's material design page:
https://www.google.com/design/icons/#ic_more_vert
Then we trim off the whitespace with image magick:
convert icon.png -trim out.png
And compress with ImageOptim.
On Gingerbread devices (Android API 9 or 10) the ViewHelper.setTranslationY code
doesn't work to move the SurfaceView. In order to acheive that effect I turned
LayerView into a ScrollView with a dummy element at the top, and allow it to
scroll. This allows the SurfaceView to move as desired. A few places in the code
were assuming that the LayerView and SurfaceView were always at the same screen
location (which was true before but not any more) and so those sites needed
some updating as well.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
The annotated methods were using @JNITarget, which would do the same thing.
However, @ReflectionTarget is clearer (like a good variable name).
proguard.cfg states a class with an annotated member will be kept so we
shouldn't need to worry about not being able to retrieve the class via
reflection.
This doesn't appear in Fennec builds and I don't know which web apps "quit"
could appear in so I didn't test this in a web app. I can confirm no issues
with a typical Fennec build, however.
This also removes code to set an icon from an addon, which is unused because,
afaik, addons' icons are also hidden. iirc, there was a bug open on whether we
want addons to be able to show icons (e.g. could be used to show status), but
we can reimplement this if that bug is ever decided.
I was not able to test this with an addon that sets an icon but I did test that
the application did not crash with no addons installed.
On GB devices, ic_menu_new_*tab is in the base menu, unlike the other
configurations, so it stayed on GB.
More complex removals to follow.
I tested this by clicking on all of the base menu items on a Lollipop phone,
KitKat large tablet, and a GB phone.
