wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1155331 - Annotate MediaPlayerManager with @ReflectionTarget. r=nalexander

Browse Source 
The annotated methods were using @JNITarget, which would do the same thing.
However, @ReflectionTarget is clearer (like a good variable name).

proguard.cfg states a class with an annotated member will be kept so we
shouldn't need to worry about not being able to retrieve the class via
reflection.
This commit is contained in:
Michael Comella 2015-04-15 11:46:20 -07:00
parent 75d941f9f4
commit 62b76c48ef
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mobile/android/base/MediaPlayerManager.java
View File

@ -17,6 +17,7 @@ import com.google.android.gms.cast.CastMediaControlIntent;
import org.json.JSONObject;
import org.mozilla.gecko.annotation.JNITarget;
import org.mozilla.gecko.annotation.ReflectionTarget;
import org.mozilla.gecko.AppConstants.Versions;
import org.mozilla.gecko.util.EventCallback;
import org.mozilla.gecko.util.NativeEventListener;
@ -34,7 +35,7 @@ public class MediaPlayerManager extends Fragment implements NativeEventListener
* Create a new instance of DetailsFragment, initialized to
* show the text at 'index'.
*/
@JNITarget
@ReflectionTarget
public static MediaPlayerManager newInstance() {
if (Versions.feature17Plus) {
return new PresentationMediaPlayerManager();
@ -45,7 +46,7 @@ public class MediaPlayerManager extends Fragment implements NativeEventListener
private static final String LOGTAG = "GeckoMediaPlayerManager";
@JNITarget
@ReflectionTarget
public static final String MEDIA_PLAYER_TAG = "MPManagerFragment";
private static final boolean SHOW_DEBUG = false;