Commit Graph

125523 Commits

Author SHA1 Message Date
Bobby Holley
2bf214ff20 Bug 658909 - Force |this| computation in SandboxCallableProxyHandler::call when using Xrays. r=bz
Comment says it all.
2013-03-21 08:20:41 -07:00
Bobby Holley
3cebc24c68 Bug 853283 - Grab the window directly from the navigator in nsNavigatorSH::NewResolve. r=mrbkap 2013-03-21 08:20:41 -07:00
Ryan VanderMeulen
59aa9e54e3 Backed out changeset 55d19e574b86 (bug 853283) for Windows debug bustage on a CLOSED TREE. 2013-03-21 15:25:14 -04:00
Ryan VanderMeulen
75a33a8191 Backed out 22 changesets (bug 658909) for Windows debug bustage. 2013-03-21 15:24:54 -04:00
Ryan VanderMeulen
9bfb899cee Backed out 3 changesets (bug 851895) for Windows debug bustage. 2013-03-21 15:24:04 -04:00
Ryan VanderMeulen
f2110c1812 Backed out changesets 775abfe4876f and 1b75fab8561b (bug 844783) under suspicion of breaking Windows debug builds on a CLOSED TREE. 2013-03-21 14:15:31 -04:00
Wes Johnston
9c73b08d1c Bug 844895 - Avoid using the same db connection for a spawned task. r=lucasr 2013-03-21 10:50:32 -07:00
Mike Shal
c2a9341a2e Bug 852534 - Remove GRE_MODULE from Makefile.in; r=gps 2013-03-21 08:41:00 -07:00
David Zbarsky
d0a0745332 Bug 847120: Convert SVGFEOffsetElement to WebIDL r=Ms2ger 2013-03-21 13:38:28 -04:00
David Zbarsky
12efc3c8f1 Bug 847120: Move SVGFEOffsetElement to its own file r=Ms2ger
--HG--
rename : content/svg/content/src/nsSVGFilters.cpp => content/svg/content/src/SVGFEOffsetElement.cpp
rename : content/svg/content/src/nsSVGFilters.cpp => content/svg/content/src/SVGFEOffsetElement.h
2013-03-21 13:38:28 -04:00
Ryan VanderMeulen
db24aa6bf1 Bug 853273 - Annotate 456219-1a/1b.html as well. 2013-03-21 13:23:27 -04:00
Bobby Holley
8e815082ae Bug 848939 - De-field videocontrols.xml. r=dao 2013-03-21 09:34:37 -07:00
Bobby Holley
669422b39d Bug 848939 - De-field scale.xml. r=jaws 2013-03-21 09:34:36 -07:00
Bobby Holley
4bd2744634 Bug 844783 - Tests. r=bz 2013-03-21 09:33:35 -07:00
Bobby Holley
b9ca3f72f3 Bug 844783 - Disable XBL scopes for XUL-whitelisted domains. r=bz 2013-03-21 09:33:34 -07:00
Bobby Holley
e83099fd69 Bug 851895 - Tests. r=mrbkap 2013-03-21 08:20:46 -07:00
Bobby Holley
756ba16356 Bug 851895 - Expand the this-fixup hack to include Cu. r=mrbkap 2013-03-21 08:20:46 -07:00
Bobby Holley
a34d52b79e Bug 851895 - Don't assert against a failure in CanCallNow. r=mrbkap
This can definitely happen now if the |this| object is wrong. It's possible
that we should be checking this earlier, but as the code stands this assertion
is incorrect.
2013-03-21 08:20:46 -07:00
Bobby Holley
f09db0c385 Bug 658909 - Tests. r=mrbkap 2013-03-21 08:20:45 -07:00
Bobby Holley
6e76c314c6 Bug 658909 - Port tearoff-handling guts of GWNOJO to XPCCallContext and remove GWNOJO. r=mrbkap 2013-03-21 08:20:45 -07:00
Bobby Holley
02780e6be7 Bug 658909 - Remove GWNOJO from PreserveWrapper. r=mrbkap 2013-03-21 08:20:45 -07:00
Bobby Holley
b396544c53 Bug 658909 - Remove GWNOJO from nsDOMClassInfo. r=mrbkap 2013-03-21 08:20:45 -07:00
Bobby Holley
5dd8152ac6 Bug 658909 - Remove GWNOJO from AccessCheck. r=mrbkap 2013-03-21 08:20:45 -07:00
Bobby Holley
7b7ed3edeb Bug 658909 - Remove GWNOJO from nsXPConnect. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
92e5a036c5 Bug 658909 - Remove GWNOJO from XPCVariant. r=mrbkap
The old code seems to be deciding whether we have a double-wrapped object by
checking _either_ the rv of GWNOJO _or_ the potential slim wrapper. This is
nonsensical, because double-wrapped objects are never slim wrappers.
Furthermore, that variable here is named 'proto', which further suggests
that this code is nonsensical. So let's just check for WNs.

Also, it seems pretty wack to be innerizing here before storing the jsval,
but I'm going to leave that for now.
2013-03-21 08:20:44 -07:00
Bobby Holley
59e03695ec Bug 658909 - Remove GWNOJO from XPCJSID. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
ed16fdf0fe Bug 658909 - Remove GWNOJO from JSValToXPCException. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
1bb0fe7c95 Bug 658909 - Remove GWNOJO from JSObject2NativeInterface. r=mrbkap 2013-03-21 08:20:44 -07:00
Bobby Holley
c5dc21550e Bug 658909 - Remove GWNOJO for helper stubs. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
1af3565955 Bug 658909 - Remove GWNOJO from MarkWrappedNative. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
b18fe7a48a Bug 658909 - Add a new, much simpler API for getting WNs from JS objects. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
60293a6469 Bug 658909 - Stop doing all the crazy stuff in GetWrappedNativeOfJSObject. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
a7f73d651b Bug 658909 - Add a hack to support calling nohelper XPCWN methods without the proper |this|. r=mrbkap 2013-03-21 08:20:43 -07:00
Bobby Holley
c34eb7f9f1 Bug 658909 - Use JS_{,Strict}PropertyOp instead of null when defining value props in nsDOMClassInfo. r=mrbkap
Using JSPropertyOp means a null shape getter, whereas null means that the shape
uses the class getter. This means that stuff like window.top, which is defined
as a non-configurable |own| property in nsDOMClassInfo, was getting set up with
XPC_WN_Helper_GetProperty as its get operation. But this confused
SandboxProxyHandler, which explicitly avoids rebinding class getters/setters,
which in turn meant that our sandboxPrototype feature was relying on the crazy
prototype-climbing behavior of GetWrappedNativeOfJSObject to make stuff like
|this.top| work. We're removing this behavior, so we need to fix nsDOMClassInfo
here.

Here are some DefineProperty cases that I left with null getters/setters:
* nsDOMClassInfo::ResolveConstructor
* The child window stuff at the bottom of nsWindowSH::NewResolve
* Named item resolution in nsNamedArraySH::NewResolve
* document.all stuff (scary!)
* nsHTMLDocumentSH::NewResolve
* nsHTMLFormElementSH::NewResolve
* nsStorage2SH::NewResolve
2013-03-21 08:20:42 -07:00
Bobby Holley
867314402d Bug 658909 - Implement carefully-checked unwrapping in XPCCallContext. r=mrbkap 2013-03-21 08:20:42 -07:00
Bobby Holley
f7e0eaeb81 Bug 658909 - Set args at XPCCallContext construct time in XPC_WN_GetterSetter. r=mrbkap
It's not clear to me why it's done this way, but it confuses our ability to
determine during wrapper lookup whether we're doing a set or a get. This aligns
the behavior with XPC_WN_CallMethod, including passing JSID_VOID for the name
(which is safe because XPCCallContext explicitly special-cases JSID_VOID and
doesn't call SetName in that case).
2013-03-21 08:20:42 -07:00
Bobby Holley
a426c37549 Bug 658909 - Initialize the same fields in both XPCCallContext constructors. r=mrbkap
This is a huge footgun. XPCCallContext is hot, but it's not too hot to be safe
here. Garbage XPCWN and JSObject pointers are bad.
2013-03-21 08:20:42 -07:00
Bobby Holley
09e256a90d Bug 658909 - Remove unnecessary ccx param. r=mrbkap 2013-03-21 08:20:42 -07:00
Bobby Holley
d6a9021608 Bug 658909 - Make isSafeToUnwrap pseudo-dynamic for SOWs. r=mrbkap
This can go away as soon as XBL scopes are no longer behind a pref.
2013-03-21 08:20:41 -07:00
Bobby Holley
0ead2198ad Bug 658909 - Force |this| computation in SandboxCallableProxyHandler::call when using Xrays. r=bz
Comment says it all.
2013-03-21 08:20:41 -07:00
Bobby Holley
b3f7f775a5 Bug 853283 - Grab the window directly from the navigator in nsNavigatorSH::NewResolve. r=mrbkap 2013-03-21 08:20:41 -07:00
Kartikaya Gupta
a22beba1b2 Bug 847839 - Remove some remnants of XUL fennec from the android widget codebase. r=cpeterson 2013-03-21 16:19:49 +01:00
Aryeh Gregor
b5a262279a Bug 849661 - Remove support for Node.hasAttributes(); r=bz 2013-03-21 14:48:32 +02:00
Ioana Budnar
7cbefe3e49 Bug 633691 - Add automated test. r=jaws 2013-03-21 16:36:09 +02:00
Ryan VanderMeulen
d278f7a463 Backed out changeset 46519785800d (bug 847809) for B2G bustage. 2013-03-21 10:41:07 -04:00
Ekanan Ketunuti
6440fd9eef Bug 853428 - Use spaces instead of tabs for indentation in search.xml. r=jAwS 2013-03-21 21:11:40 +07:00
Jim Mathies
f709c951bd Bug 795630 - Remove CapturePicker and related files. r=mbrubeck 2013-03-21 09:23:13 -05:00
Jim Mathies
bc04b36cfd Bug 852967 - Simplify marker selection changes for text inputs. r=mbrubeck 2013-03-21 08:55:16 -05:00
Jim Mathies
0edb5a6f53 Bug 852619 - Tap off form input to clear caret selection should clear focus. r=ally 2013-03-21 08:55:16 -05:00
Jim Mathies
6c0f4c7142 Bug 852088 - Add drag caret to select text support. r-fryn 2013-03-21 08:55:16 -05:00