Commit Graph

27773 Commits

Author SHA1 Message Date
Jeff Walden
5e2dbd029b Bug 891177 - Remove Vector.h's js/TemplateLib.h dependency by introducing mfbt/TemplateLib.h with the necessary bits. r=terrence
--HG--
extra : rebase_source : e84231171d6bd6c1e2de8201b8c9563375723d01
2013-07-08 12:42:13 -07:00
Jeff Walden
4196fa2e0f Bug 891177 - Remove Vector.h's js/Utility.h dependency. r=terrence
--HG--
extra : rebase_source : d9be649a097b3b9b92cd62685d0fadfa8c0e2bc4
2013-07-03 16:07:43 -07:00
Jeff Walden
f52f37cddc Bug 891177 - Move leading/trailing-zero-bit counting functions, ceiling/floor log2 functions, and round-up-pow2 functions into MathAlgorithms.h. r=terrence
--HG--
extra : rebase_source : 8cfbd68b8cd4a0e21185dd864c7e827ccfa6b751
2013-07-03 15:46:51 -07:00
Benjamin Bouvier
2cf4360796 Bug 894781 - Set implicit truncate for MAbs only for int32 in asm.js mode; r=luke
--HG--
extra : rebase_source : e3bb8353d3e65181e35577f732482a961e88a061
2013-07-17 14:12:43 -07:00
Wes Kocher
cc90ec9c73 Backout 95a4b87a0583 (bug 894948) for causing an octane-crypto regression on a CLOSED TREE 2013-07-17 19:01:03 -07:00
Bobby Holley
09e84333e6 Bug 887334 - Enter a compartment in b2g-only unloading code. r=me CLOSED TREE 2013-07-17 14:28:54 -07:00
Ryan VanderMeulen
7ecd1a4b17 Backed out changeset 76e7ef98a9d1 (bug 867856) for jit-test failures.
CLOSED TREE
2013-07-17 15:54:44 -04:00
Bobby Holley
e96cffb55d Bug 887334 - Reorder some bookkeeping and assert in setCompartment that both the old and new compartments are marked as entered. r=luke 2013-07-17 11:53:55 -07:00
Bobby Holley
1571ff2ce4 Bug 887334 - Require cx->compartment() to be null when destroying a context. r=luke
If it's non-null, that means we've got a JSAutoCompartment on the stack, which
is going to run into trouble when it tries to restore the old compartment on
the now-dead cx.
2013-07-17 11:53:54 -07:00
Bobby Holley
8e0afa92a2 Bug 887334 - Stop setting the compartment to defaultCompartmentObject_->compartment(). r=luke
With this change, defaultCompartmentObject_ is just an opaque (though traced)
piece of embedder state on the cx.
2013-07-17 11:53:54 -07:00
Bobby Holley
9883f9fcf9 Bug 887334 - Fix JSAPI test harness to not fail when the initial compartment is null. r=luke
I don't know why it's done this way, but it sure needs to change.
2013-07-17 11:53:53 -07:00
Bobby Holley
5420505253 Bug 887334 - Miscellaneous JSAutoCompartments. r=luke 2013-07-17 11:53:53 -07:00
Bobby Holley
a93493b71d Bug 887334 - Add a JSAutoCompartment to AutoCxPusher. r=luke,gabor
This should hopefully take care of any cases where consumers expect to be in
the default compartment.
2013-07-17 11:53:52 -07:00
Bobby Holley
e90537d5c6 Bug 887334 - Use the new AutoCompartment overload for the atoms compartment and remove AutoEnterAtomsCompartment. r=bhackett
We have to do some temporary hackiness to deal with some of the new PJS work.
This patch stays as true to the old world as possible, so that we can more
easily backport it.
2013-07-17 11:53:52 -07:00
Bobby Holley
0c5572cc76 Bug 887334 - Don't rethrow in quickstubs if there's already an exception pending. r=luke 2013-07-17 11:53:52 -07:00
Bobby Holley
c8c93ab150 Bug 887334 - Add a JSCompartment* to AutoCompartment and use it in JS_NewGlobalObject. r=luke
This gets rid of the wonky setCompartment usage in that function.
2013-07-17 11:53:52 -07:00
Bobby Holley
aee282ccae Bug 887334 - Move faulty JSAutoRequest in initSelfHosting. r=luke
The call to JS_SetGlobalObject causes cx->compartment_ to be set to the self-
hosting global, which means that the JSAutoCompartment picks up that compartment
as the 'previous' compartment. So despite the attempt to restore things with
JS_SetGlobalObject at the end of the function, the JSAutoCompartment destructor
actually ends up leaving cx in the self-hosting global's compartment at the end
of this function. Moving the JSAutoCompartment construction above the call to
JS_SetGlobalObject fixes the problem.
2013-07-17 11:53:51 -07:00
Bobby Holley
36f005e12f Bug 887334 - Null-check compartment() in JS_GetGlobalForScopeChain(). r=luke
cx->global() assumes a non-null compartment(). When we fix up various bugs
related to being in a compartment when we shouldn't be, we start to crash here.
Fix it.
2013-07-17 11:53:51 -07:00
Bobby Holley
a5bbbb322d Bug 887334 - Rejigger the string manipulation in OnJSContextNew to avoid depending on being in a compartment. r=luke
The current code makes calls that assume (implicitly, via assertions) that |cx|
is in a compartment, which isn't a valid assumption going forward.
2013-07-17 11:53:51 -07:00
Bobby Holley
089d93ca1d Bug 887334 - Remove AutoSwitchCompartment. r=luke
This thing is...yikes.
2013-07-17 11:53:50 -07:00
Nicolas B. Pierron
54c6ec750c Bug 867856 - Fix intermittent timeout of bug743094.js test case. r=h4writer 2013-07-17 11:51:19 -07:00
Nicolas B. Pierron
fbded8c6a4 Bug 892426 - Add an additional temp-Register to SetElementIC. r=jandem 2013-07-17 11:51:19 -07:00
Till Schneidereit
f564136588 Bug 894948 - Remove effectively-dead analysis-related code from interpreter. r=jandem
--HG--
extra : rebase_source : 037764b4c11746ee52d5347c76e2a5242b35afab
2013-07-17 19:21:10 +02:00
Luke Wagner
e4d0a480fa Bug 882008 - OdinMonkey: fix subtraction to take doublish, rm Use (r=bbouvier)
--HG--
extra : rebase_source : 819570ab142518328aa41a1c6b81ffa0a5d7b96f
2013-07-02 11:38:43 -07:00
Luke Wagner
d03c8ecb55 Bug 880538 - LifoAlloc::release after parsing every function (r=bbouvier)
--HG--
extra : rebase_source : 9ead29e3dc5110f2b1f30c5218c41cbbc26555e5
2013-06-21 16:20:47 -07:00
Luke Wagner
de23e334eb Bug 880538 - move 'hasDestructuringArgs' flag into the FunctionBox (r=bhackett)
--HG--
extra : rebase_source : d65025cd591c7faf9e64f4768da0b2b8352ee393
2013-06-28 10:29:58 -07:00
Luke Wagner
be562454f2 Bug 880538 - store a pointer from ParseContext to it's PNK_FUNCTION ParseNode (r=bhackett)
--HG--
extra : rebase_source : acb4b0e5d94d0c1777173a4b0f378c46591805b3
2013-06-28 10:29:58 -07:00
Luke Wagner
e5cfdc10f1 Bug 880538 - set pn->pn_funbox immediately (r=bhackett)
--HG--
extra : rebase_source : 11b265e64f8355989632bd2556ed119a397cb10a
2013-06-21 16:07:25 -07:00
Luke Wagner
1974b8aa53 Bug 880538 - OdinMonkey: don't create an IonContext in MacroAssembler (r=sstangl)
--HG--
extra : rebase_source : c949b8337141681eb983ca4792849a726a059e18
2013-06-28 10:29:57 -07:00
Luke Wagner
f50432075d Bug 880538 - OdinMonkey: make a single pass over the parse tree (r=bbouvier)
--HG--
extra : rebase_source : c5aafde69f44906750d1d62d6878bfbab9e048ee
2013-06-13 11:48:47 -07:00
Ryan VanderMeulen
97083e557a Backed out 4 changesets (bug 893858, bug 868859, bug 886903) for Linux debug mochitest-other crashes on a CLOSED TREE.
Backed out changeset 0ded4854067b (bug 886903)
Backed out changeset ca8afb897e13 (bug 893858)
Backed out changeset c15f503a96cc (bug 868859)
Backed out changeset 6a788f399a7f (bug 868859)
2013-07-17 12:43:59 -04:00
Ed Morley
8887f367e6 Backed out changeset ad74eb485a87 (bug 891695) for startup crashes on a CLOSED TREE 2013-07-17 17:18:11 +01:00
Dan Gohman
75373a534a Bug 891739 - IonMonkey: Make or_ and xor_ range analysis even more precise, and avoid calling js_bitscan_clz32 with a zero operand. r=nbp,waldo 2013-07-17 08:16:05 -07:00
Dan Gohman
4a52fe74a1 Bug 891695 - IonMonkey: Avoid passing pointers by const reference. r=rpearl 2013-07-17 07:32:48 -07:00
Jan de Mooij
7b0eb9b451 Bug 894447 - Avoid unnecessary monitor instructions and bailouts with JSOP_SETELEM accessing named properties and backout bug 894463. r=bhackett 2013-07-17 16:21:22 +02:00
Tom Schuster
78d54d5af2 Bug 893858 - More testing for CPOWs and two small bug fixes. r=dvander 2013-07-17 09:27:49 -04:00
Shu-yu Guo
0af2e2f204 Bug 894782 - Fix callsite cloning interaction with inline dispatch in Ion. (r=jandem) 2013-07-17 06:11:18 -07:00
Brian Hackett
86d8fe99e8 Bug 894669 - Add analysis for finding variables unnecessarily entrained by inner functions, r=luke. 2013-07-16 18:54:47 -06:00
Ryan VanderMeulen
5739ad1b00 Backed out changeset 56423bbe9a13 (bug 891695) because it didn't un-bust itself automagically. 2013-07-17 08:54:01 -04:00
Carsten "Tomcat" Book
d98e2cd471 Relanding after backout Bug 891695 - IonMonkey: Avoid passing pointers by const reference. r=rpearl 2013-07-17 14:16:17 +02:00
Carsten "Tomcat" Book
4fa20cfa2f Backed out changeset 5939320824b1 (bug 894242) "CLOSED TREE" 2013-07-17 10:36:12 +02:00
Mike Hommey
31df024bde Bug 894242 - Make C++0x/C++11 mode of gcc/clang mandatory. r=ted 2013-07-17 16:19:25 +09:00
Mike Hommey
4df35f912c Backout changeset cd67ffb5ca47 (bug 883381), effectively restoring bug 877937 2013-07-17 16:18:46 +09:00
Mike Hommey
521e88720d Bug 894240 - Fix pointer dereference in js::cli::OptionParser::extractValue. r=Waldo 2013-07-17 16:16:55 +09:00
Wes Kocher
85273bb749 Backout 1372b813d76f (bug 891695) for suspicion of causing bustage on a CLOSED TREE
--HG--
extra : amend_source : 9e9d1d7792df7060a2d61d5e8721b67602e14451
2013-07-16 20:47:17 -07:00
Bobby Holley
26926302d8 Bug 889911 - Switch xpcshell to SystemErrorReporter with a little bit of special magic. r=mrbkap
XPCShell currently overrides all the JSContexts whose creation it observes with
its own custom error reporter. This reporter does all sorts of funny things which
we try to clean up for the most part. But there are a few very intricate
considerations at play.

First, the old xpcshell error reporter does some mumbo jumbo with the
XPCCallContext stack to try to guess whether some other code might catch the
exception. This is total garbage on a number of fronts, particularly because
the XPCCallContext stack has no concept of saved frame chains, nested event
loops, sandbox boundaries, origin boundaries, or any of the myriad of
complicating factors that determine whether or not an exception will propagate.

So we get rid of it. But this causes some crazy debugger tests to fail, because
they rely on an exception from uriloader/exthandler/nsHandlerService.js getting
squelched, and can't handle anybody reporting errors to the console service at
the particular moment of contortionism when the exception is raised. So we need
to introduce an explicit mechanism to disable the error reporter here to keep
things running.

Second, we have to be very careful about tracking the return status of the
xpcshell binary. The old code would simply flag an error code if the error
handler was invoked, and we can mostly continue to do that. But there are some
complications. See the comments.

Finally, we don't anything analogous in XPCShellEnvironment, because I have
patches in bug 889714 to remove its state-dependence on the error reporter.
I'll switch it to SystemErrorReporter in that bug.
2013-07-16 20:38:44 -07:00
Bobby Holley
b755828946 Bug 889911 - Replace mozJSLoaderErrorReporter with SystemErrorReporter and remove the former. r=mrbkap 2013-07-16 20:38:44 -07:00
Bobby Holley
a2deff3242 Bug 889911 - Introduce xpc::SystemErrorReporter, roughly based on mozJSComponentLoader's error reporter. r=mrbkap 2013-07-16 20:38:44 -07:00
Benoit Girard
82435a9c18 Bug 838803 - Remove HAVE_STDCALL to work around clang bug. r=glandium
--HG--
extra : rebase_source : e1cdb524a4f7f0742f2051e5915e5e21db4c0423
2013-07-16 22:01:50 -04:00
Wes Kocher
f1fea88196 Backout 399362c3e135 (bug 894669) for bustage 2013-07-16 18:41:52 -07:00
Ryan VanderMeulen
5333a265b8 Backed out 10 changesets (bug 889911, bug 889714) due to merge conflicts on a CLOSED TREE.
Backed out changeset 1a1a536121da (bug 889714)
Backed out changeset 2cd88ef9eea5 (bug 889714)
Backed out changeset 489723887eca (bug 889714)
Backed out changeset 2b38ce22cf97 (bug 889714)
Backed out changeset 87b0a59a5d51 (bug 889714)
Backed out changeset 13229bab2ba4 (bug 889714)
Backed out changeset 234bd6d1fbed (bug 889714)
Backed out changeset 4f5f62284917 (bug 889714)
Backed out changeset 18537c4436c7 (bug 889911)
Backed out changeset ca7060ab1588 (bug 889911)
2013-07-16 21:16:31 -04:00
Bobby Holley
b6f705b27a Bug 889911 - Switch xpcshell to SystemErrorReporter with a little bit of special magic. r=mrbkap
XPCShell currently overrides all the JSContexts whose creation it observes with
its own custom error reporter. This reporter does all sorts of funny things which
we try to clean up for the most part. But there are a few very intricate
considerations at play.

First, the old xpcshell error reporter does some mumbo jumbo with the
XPCCallContext stack to try to guess whether some other code might catch the
exception. This is total garbage on a number of fronts, particularly because
the XPCCallContext stack has no concept of saved frame chains, nested event
loops, sandbox boundaries, origin boundaries, or any of the myriad of
complicating factors that determine whether or not an exception will propagate.

So we get rid of it. But this causes some crazy debugger tests to fail, because
they rely on an exception from uriloader/exthandler/nsHandlerService.js getting
squelched, and can't handle anybody reporting errors to the console service at
the particular moment of contortionism when the exception is raised. So we need
to introduce an explicit mechanism to disable the error reporter here to keep
things running.

Second, we have to be very careful about tracking the return status of the
xpcshell binary. The old code would simply flag an error code if the error
handler was invoked, and we can mostly continue to do that. But there are some
complications. See the comments.

Finally, we don't anything analogous in XPCShellEnvironment, because I have
patches in bug 889714 to remove its state-dependence on the error reporter.
I'll switch it to SystemErrorReporter in that bug.
2013-07-16 18:04:49 -07:00
Bobby Holley
269151d7fe Bug 889911 - Introduce xpc::SystemErrorReporter, roughly based on mozJSComponentLoader's error reporter. r=mrbkap 2013-07-16 18:04:48 -07:00
Dan Gohman
1d9d94c40e Bug 891695 - IonMonkey: Avoid passing pointers by const reference. r=rpearl 2013-07-16 16:00:03 -07:00
Brian Hackett
0bb18aa410 Bug 894669 - Add analysis for finding variables unnecessarily entrained by inner functions, r=luke. 2013-07-16 18:54:47 -06:00
Jan de Mooij
0f3720ceef Bug 852421 - Remove MarkTypeObjectUnknownProperties call from Object.create. r=bhackett
--HG--
extra : rebase_source : efbc9855ea3b548838b7c2b74feac3db987814e5
2013-07-16 21:34:02 +02:00
Till Schneidereit
72188a392a Bug 827396 - rm TypeObject::CONTRIBUTION_LIMIT and TypeObject::contribution. r=bhackett
--HG--
extra : rebase_source : c564216435bafeea58c0bfb32bdae07a3587fa72
2013-07-16 20:42:44 +02:00
Norbert Lindenberg
7cedad89fd Bug 853706 - Fixed a test case that depended on incorrect number of significant digits for 0. r=jwalden
--HG--
extra : rebase_source : a0789030f25b4541d7c3262200f840bda8f10e52
2013-07-16 11:22:57 -07:00
Jeff Walden
6d1aa84530 Bug 853706 - Fix nits noted in review of a new test. r=me 2013-07-16 11:09:56 -07:00
Norbert Lindenberg
6743e38dc0 Bug 853706 - Added new test case for formatting 0 with significant digits. r=jwalden
--HG--
extra : rebase_source : 359a1afdbe2132ebf135809e3d1c121457c5b595
2013-07-16 10:40:33 -07:00
Norbert Lindenberg
fcfda47ad9 Bug 853706 - Enable previously failing conformance test. r=jwalden
--HG--
extra : rebase_source : f855b031368b37a10d819a3913003f8520228a12
2013-07-16 10:40:21 -07:00
Jeff Walden
54c2c4cbfe Bug 894181 - Convert a bunch of SHAPE_* macros to inline functions to eliminate warnings, enhance debuggability. r=terrence
--HG--
extra : rebase_source : 2b8a5ba43a3303470b99788b7637488c38050764
2013-07-16 08:14:57 -07:00
Jeff Walden
b5d72d1f65 Bug 894172 - Eliminate DO_NEXT_OP(len) in favor of an unadorned goto the label in question. This eliminates tautological |len == len| compares that clang+ccache warns about, and it eliminates the previous apparent possibility that any value could be passed to DO_NEXT_OP, when in fact only |len| (or a value equal to it) could be passed. r=terrence
--HG--
extra : rebase_source : 0e1561a7bcabc6811fea6b167251046c2871224d
2013-07-16 08:14:57 -07:00
Boris Zbarsky
6491b478e3 Bug 894463. Go back to deoptimizing vanilla objects and arrays more eagerly to unregress ss-tagcloud. r=bhackett 2013-07-16 13:42:03 -04:00
Jan de Mooij
4dec24de90 Bug 870356 - Fix IonMonkey Math.round bug on x86/x64 hardware without SSE 4.1. r=sstangl 2013-07-16 17:55:29 +02:00
Jeff Walden
2e37cdb786 Convert SN_MAKE_TERMINATOR and SN_IS_TERMINATOR to inline functions to avoid clang+ccache warnings about over-parenthesized equality expressions. No bug, rs=terrence
--HG--
extra : rebase_source : 50b8f70501a481a4dda715284ccd9a21bbfa0eb6
2013-07-15 15:26:04 -07:00
Jeff Walden
f424972f65 Bug 891437 - Implement mozilla/Array.h, a class suitable for use where a C array would be used, with additional debug bounds-checking. r=Ms2ger
--HG--
extra : rebase_source : 314232d817e67d9a26dfa215b5c897e0dd0be353
2013-02-07 15:32:20 -08:00
Ryan VanderMeulen
f01bee06e9 Backed out changeset 302fb81f0729 (bug 858940) for frequent Android test crashes. 2013-07-16 11:05:11 -04:00
Brian O'Keefe
f98dd45a72 Bug 883502 - Part 1: Move 'chromium_config.mk' includes after rules.mk. r=gps 2013-07-04 08:28:43 -04:00
Ryan VanderMeulen
7eb28cd59d Backed out 2 changesets (bug 893362) for check-sync-dir bustage.
Backed out changeset cb79166bb8fa (bug 893362)
Backed out changeset 9db461b687fd (bug 893362)
2013-07-16 09:57:12 -04:00
Ryan VanderMeulen
280d212e0c Bug 893362 - Fix check-sync-dirs bustage. 2013-07-16 09:47:16 -04:00
ISHIKAWA, Chiaki
7420bbd44f Bug 893362 - Align the target name for the START and FINISH in the build log. r=gps 2013-07-16 09:33:22 -04:00
Gabor Krizsanits
c9c9a69587 Bug 874158 - Crash in GetNativeForGlobal. r=bholley 2013-07-16 15:04:28 +02:00
Jan de Mooij
58d85ac337 Bug 867082 - Use JSPROP_SHARED for the customNative global property in the JS shell. r=jwalden
--HG--
extra : rebase_source : 8d275654d7242d000416ce30f3116b85657ed26a
2013-07-16 15:05:02 +02:00
Jan Beich
086b5462ff Bug 893508 - Don't hide ios/ostream symbols to fix build with some C++ runtimes. r=glandium 2013-07-16 14:09:24 +02:00
Boris Zbarsky
3bee6e23e2 Bug 893897. Don't deoptimize typeobjects in TypeScript::MonitorAssign if they only have a few properties. r=bhackett 2013-07-16 01:32:18 -04:00
Boris Zbarsky
4e13ee3c6a Bug 838146 part 10. Turn on WebIDL bindings for Navigator. r=smaug 2013-07-12 10:37:23 -04:00
Luke Wagner
0331d292e4 Bug 880538 - Generalize strict-mode reparsing (r=jorendorff)
--HG--
extra : rebase_source : 423ae5c1f922efa523f07ade811e78a1b243c057
2013-06-25 10:28:04 -07:00
Wes Kocher
eb7a34534f Backout 476a4bbbfdb2 (bug 890722) on a CLOSED TREE for breaking debug mochitests 2013-07-15 19:56:08 -07:00
Shu-yu Guo
4533a63a6e Bug 893679 - Followup: Make sure rvalType is MIRType_Value when barrier is true to fix bustage on a CLOSED TREE. (r=bhackett) 2013-07-16 01:49:54 +02:00
Luke Wagner
1dc4b13c6d Bug 888469 - rm startOffset argument (r=bhackett) 2013-06-27 18:27:58 -07:00
Luke Wagner
f7667f947f Bug 888469 - rm funName argument (r=bhackett) 2013-06-25 00:20:51 -07:00
Luke Wagner
274729d4b6 Bug 888469 - rm dead assignment to 'body' (r=bhackett) 2013-06-25 00:02:49 -07:00
Luke Wagner
fa615f8de8 Bug 888469 - rm 'strict' argument in some places (r=bhackett) 2013-06-24 23:16:33 -07:00
Luke Wagner
681c0bbc8a Bug 888469 - rm PND_BLOCKCHILD (r=bhackett) 2013-06-24 18:15:43 -07:00
Hannes Verschore
2fddd19753 Bug 890722 - IonMonkey: implement JSOP_SETRVAL and JSOP_RETRVAL, r=jandem 2013-07-15 14:48:47 -07:00
Benjamin Bouvier
3125f96778 Bug 893368: in asm.js, correctly compute range for truncated Math.abs calls; r=nbp 2013-07-15 14:46:03 -07:00
Benjamin Bouvier
a7927e5e2d Bug 893364: in asm.js mode, correctly compute ranges for add and sub; 2013-07-15 14:41:36 -07:00
Daniel Holbert
d0dd527066 Bug 893904 - Remove 2 unused variables from MIR.cpp. r=bhackett 2013-07-15 17:29:18 -04:00
Wei Wu
1db4da9c50 Bug 893348 - Update the default value of 'GVN' option in jsshell's usage. r=nbp 2013-07-15 17:29:01 -04:00
Shu-yu Guo
5d0beb7a16 Bug 893679 - Insert type barrier for ParallelGetPropertyIC if the observed set doesn't contain undefined. (r=bhackett) 2013-07-15 14:07:36 -07:00
Steve Fink
7e603e6f0f No bug. Minor comment tweaks. DONTBUILD.
--HG--
extra : rebase_source : 315e111f0b8655ab2f7c4ffcde0f6f823239544f
2013-07-15 14:08:15 -07:00
Brian Hackett
d030b5be8e Bug 887075 - Use original function when compiling lazy scripts, r=luke. 2013-07-15 14:53:13 -06:00
Jason Orendorff
d434e621c7 Bug 892561 - Inline Parser::bracketedExpr() into its only call site, in Parser::parenExpr(). r=Waldo.
--HG--
extra : rebase_source : a1e9ce81638fd543c1e21cb69d81c9767118b7c9
2013-07-15 11:22:06 -05:00
Jason Orendorff
27e58b7442 Bug 889628, part 5 - Enforce ES6 rules about assigning to eval or arguments in destructuring assignment. r=Waldo.
--HG--
extra : rebase_source : 865c3056ded7d74d26bc2e24f3f2e66066a7bd3f
2013-07-15 11:21:17 -05:00
Jason Orendorff
6d50b49fc4 Bug 889628, part 4 - Remove another redundant BindNameToSlot call. r=Waldo.
--HG--
extra : rebase_source : 9408237df183256ecddf4ee9f2de505a80a9a086
2013-07-15 10:28:57 -05:00
Jason Orendorff
42a225dc95 Bug 889628, part 3 - Don't set pn_op on PNK_DOT and PNK_ELEM nodes in assignment. r=Waldo.
--HG--
extra : rebase_source : fbcd7b2cb4cecbbdcd6326e4f4726232d9af7f51
2013-07-15 10:28:46 -05:00
Jason Orendorff
aacc80805b Bug 889628, part 2 - Do not look at lhs->getOp() when selecting opcodes for destructuring assignment, except if lhs is a name and we just called BindNameToSlot. r=Waldo.
--HG--
extra : rebase_source : 955e32774099d85cab5b5d6b83a9d5233493fa08
2013-07-15 10:28:35 -05:00
Jason Orendorff
cc804ca758 Bug 889628, part 1 - Merge setLvalKid with setIncOpKid. Rename it to checkAndMarkAsIncOperand. Rename setAssignmentLhsOps to checkAndMarkAsAssignmentLhs. r=Waldo.
--HG--
extra : rebase_source : cd6f0c140aa6e11ca6fd5a60230f7d623e957455
2013-07-15 10:28:18 -05:00
Jason Orendorff
1e6e464596 Fix trailing whitespace in jsobj.cpp, noted by Ms2ger in bug 886087 comment 5. no_r=me.
--HG--
extra : rebase_source : b0a5cd29a6f3e5322d080343a1d4d15d54cb3f35
2013-07-15 10:26:49 -05:00