wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 889628, part 3 - Don't set pn_op on PNK_DOT and PNK_ELEM nodes in assignment. r=Waldo.

Browse Source 
--HG--
extra : rebase_source : fbcd7b2cb4cecbbdcd6326e4f4726232d9af7f51
This commit is contained in:
Jason Orendorff 2013-07-15 10:28:46 -05:00
parent aacc80805b
commit 42a225dc95
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
js/src/frontend/Parser.cpp
View File

@ -2926,10 +2926,7 @@ Parser<FullParseHandler>::bindDestructuringLHS(ParseNode *pn)
switch (pn->getKind()) {
case PNK_NAME:
pn->markAsAssigned();
/* FALL THROUGH */
case PNK_DOT:
case PNK_ELEM:
/*
* We may be called on a name node that has already been specialized,
* in the very weird and ECMA-262-required "for (var [x] = i in o) ..."
@ -2939,6 +2936,10 @@ Parser<FullParseHandler>::bindDestructuringLHS(ParseNode *pn)
pn->setOp(JSOP_SETNAME);
break;
case PNK_DOT:
case PNK_ELEM:
break;
case PNK_CALL:
if (!makeSetCall(pn, JSMSG_BAD_LEFTSIDE_OF_ASS))
return false;
@ -5077,12 +5078,11 @@ Parser<FullParseHandler>::checkAndMarkAsAssignmentLhs(ParseNode *pn, bool isPlai
pn->setOp(pn->isOp(JSOP_GETLOCAL) ? JSOP_SETLOCAL : JSOP_SETNAME);
pn->markAsAssigned();
break;
case PNK_DOT:
pn->setOp(JSOP_SETPROP);
break;
case PNK_ELEM:
pn->setOp(JSOP_SETELEM);
break;
#if JS_HAS_DESTRUCTURING
case PNK_ARRAY:
case PNK_OBJECT:
@ -5094,10 +5094,12 @@ Parser<FullParseHandler>::checkAndMarkAsAssignmentLhs(ParseNode *pn, bool isPlai
return false;
break;
#endif
case PNK_CALL:
if (!makeSetCall(pn, JSMSG_BAD_LEFTSIDE_OF_ASS))
return false;
break;
default:
report(ParseError, false, null(), JSMSG_BAD_LEFTSIDE_OF_ASS);
return false;