Bug 855270 - splice off trailing null entries from NewTabUtils pinnedLinks when unpinning. r=ttaubert

This commit is contained in:
Sam Foster 2013-03-27 15:05:00 +00:00
parent 7c559477dc
commit 5c1d0e9155

View File

@ -406,10 +406,15 @@ let PinnedLinks = {
*/ */
unpin: function PinnedLinks_unpin(aLink) { unpin: function PinnedLinks_unpin(aLink) {
let index = this._indexOfLink(aLink); let index = this._indexOfLink(aLink);
if (index != -1) { if (index == -1)
this.links[index] = null; return;
this.save(); let links = this.links;
} links[index] = null;
// trim trailing nulls
let i=links.length-1;
while (i >= 0 && links[i] == null)
i--;
links.splice(i +1);
}, },
/** /**