Bug 808410 - checkForCrashes should return true for cases where we hit an exception during minidump stackwalk; r=jmaher

This commit is contained in:
Ed Morley 2012-11-20 15:24:28 +00:00
parent 0cbab45c91
commit 295652c85c

View File

@ -146,7 +146,6 @@ def checkForCrashes(dumpDir, symbolsPath, testName=None):
if len(dumps) == 0: if len(dumps) == 0:
return False return False
foundCrash = False
removeSymbolsPath = False removeSymbolsPath = False
# If our symbols are at a remote URL, download them now # If our symbols are at a remote URL, download them now
@ -198,12 +197,11 @@ def checkForCrashes(dumpDir, symbolsPath, testName=None):
extra = os.path.splitext(d)[0] + ".extra" extra = os.path.splitext(d)[0] + ".extra"
if os.path.exists(extra): if os.path.exists(extra):
os.remove(extra) os.remove(extra)
foundCrash = True
finally: finally:
if removeSymbolsPath: if removeSymbolsPath:
shutil.rmtree(symbolsPath) shutil.rmtree(symbolsPath)
return foundCrash return True
def getFullPath(directory, path): def getFullPath(directory, path):
"Get an absolute path relative to 'directory'." "Get an absolute path relative to 'directory'."