From 295652c85c432ed459cf830c9aa7c9d465b13c14 Mon Sep 17 00:00:00 2001 From: Ed Morley Date: Tue, 20 Nov 2012 15:24:28 +0000 Subject: [PATCH] Bug 808410 - checkForCrashes should return true for cases where we hit an exception during minidump stackwalk; r=jmaher --- build/automationutils.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/build/automationutils.py b/build/automationutils.py index 2376ad015cd..d1a9971df7a 100644 --- a/build/automationutils.py +++ b/build/automationutils.py @@ -146,7 +146,6 @@ def checkForCrashes(dumpDir, symbolsPath, testName=None): if len(dumps) == 0: return False - foundCrash = False removeSymbolsPath = False # If our symbols are at a remote URL, download them now @@ -198,12 +197,11 @@ def checkForCrashes(dumpDir, symbolsPath, testName=None): extra = os.path.splitext(d)[0] + ".extra" if os.path.exists(extra): os.remove(extra) - foundCrash = True finally: if removeSymbolsPath: shutil.rmtree(symbolsPath) - return foundCrash + return True def getFullPath(directory, path): "Get an absolute path relative to 'directory'."