waveterm/xterm.js
0
0
Fork 0
mirror of https://github.com/wavetermdev/xterm.js.git synced 2026-08-05 13:43:48 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2962 from JoshuaKGoldberg/dom-renderer-dispose-children

Browse Source 
Only removeChild valid children in DomRenderer dispose
This commit is contained in:
Daniel Imms
2020-06-04 07:15:38 -07:00
committed by GitHub
parent 289014b32e fbb8c6273b
commit fb25be3ecd
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/browser/renderer/dom/DomRenderer.ts
+8 -4
View File
@@ -95,10 +95,14 @@ export class DomRenderer extends Disposable implements IRenderer {
public dispose(): void {
this._element.classList.remove(TERMINAL_CLASS_PREFIX + this._terminalClass);
this._screenElement.removeChild(this._rowContainer);
this._screenElement.removeChild(this._selectionContainer);
this._screenElement.removeChild(this._themeStyleElement);
this._screenElement.removeChild(this._dimensionsStyleElement);
// Outside influences such as React unmounts may manipulate the DOM before our disposal.
// https://github.com/xtermjs/xterm.js/issues/2960
this._rowContainer.parentElement?.removeChild(this._rowContainer);
this._selectionContainer.parentElement?.removeChild(this._selectionContainer);
this._themeStyleElement.parentElement?.removeChild(this._themeStyleElement);
this._dimensionsStyleElement.parentElement?.removeChild(this._dimensionsStyleElement);
super.dispose();
}