waveterm/xterm.js
0
0
Fork 0
mirror of https://github.com/wavetermdev/xterm.js.git synced 2026-08-05 13:43:48 -07:00
Code Issues Packages Projects Releases Wiki Activity

Don't skip new tests, implement CSI Ps ^

Browse Source
This commit is contained in:
Daniel Imms
2025-12-30 06:59:27 -08:00
parent 54e66f3ac4
commit da4243cf02
3 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/copilot-instructions.md
+2 -2
View File
@@ -24,8 +24,8 @@ npm run build && npm run esbuild # Build all TypeScript and bundle
- Unit tests filtering to file: `npm run test-unit -- **/fileName.ts
- Per-addon unit tests: `npm run test-unit addons/addon-image/out-esbuild/*.test.js`
- Integration tests: `npm run test-integration` (Playwright across Chrome/Firefox/WebKit)
- Integration tests by file: `npm run test-integration -- test/playwright/InputHandler.test.ts`
- Per-addon integration tests: `npm run test-integration --suite=addon-search`
- Integration tests by file: `npm run test-integration -- test/playwright/InputHandler.test.ts`. Never use grep to filter tests, it doesn't work
- Integration tests by addon: `npm run test-integration --suite=addon-search`. Suites always follow the format `addon-<something>`
## Addon Development Pattern
src/common/InputHandler.ts
+1
View File
@@ -240,6 +240,7 @@ export class InputHandler extends Disposable implements IInputHandler {
this._parser.registerCsiHandler({ final: 'T' }, params => this.scrollDown(params));
this._parser.registerCsiHandler({ final: 'X' }, params => this.eraseChars(params));
this._parser.registerCsiHandler({ final: 'Z' }, params => this.cursorBackwardTab(params));
this._parser.registerCsiHandler({ final: '^' }, params => this.scrollDown(params));
this._parser.registerCsiHandler({ final: '`' }, params => this.charPosAbsolute(params));
this._parser.registerCsiHandler({ final: 'a' }, params => this.hPositionRelative(params));
this._parser.registerCsiHandler({ final: 'b' }, params => this.repeatPrecedingCharacter(params));
test/playwright/InputHandler.test.ts
+4 -9
View File
@@ -26,6 +26,7 @@ test.describe('InputHandler Integration Tests', () => {
});
test.beforeEach(async () => {
recordedData.length = 0;
await ctx.proxy.resize(80, 24);
});
test.describe('CSI', () => {
@@ -245,22 +246,18 @@ test.describe('InputHandler Integration Tests', () => {
test.skip('CSI > Pm T - XTRMTITLE: Reset title mode features to default value, xterm', async () => {
// TODO: Implement
});
test.skip('CSI Ps X - ECH: Erase Ps Character(s) (default = 1)', async () => {
// TODO: Test needs investigation - erase character behavior differs from expectation
test('CSI Ps X - ECH: Erase Ps Character(s) (default = 1)', async () => {
await ctx.proxy.write('abcdef\x1b[1;1H\x1b[X');
await pollFor(ctx.page, () => getLinesAsArray(1), [' bcdef']);
await ctx.proxy.reset();
await ctx.proxy.write('abcdef\x1b[1;1H\x1b[3X');
await pollFor(ctx.page, () => getLinesAsArray(1), [' def']);
});
// TODO: CSI Z (CBT) appears to move cursor to column 0 instead of previous tab stop
test.skip('CSI Ps Z - CBT: Cursor Backward Tabulation Ps tab stops (default = 1)', async () => {
// Write 'a' at col 17, go back 1 tab stop to col 9, write 'b'
test('CSI Ps Z - CBT: Cursor Backward Tabulation Ps tab stops (default = 1)', async () => {
await ctx.proxy.write('\x1b[17Ga\x1b[17G\x1b[Zb');
await pollFor(ctx.page, () => getLinesAsArray(1), [' b a']);
});
test.skip('CSI Ps ^ - SD: Scroll down Ps lines (default = 1) (SD), ECMA-48', async () => {
// CSI ^ for scroll down is not implemented - xterm.js treats ^ (0x5e) as PM string start
test('CSI Ps ^ - SD: Scroll down Ps lines (default = 1) (SD), ECMA-48', async () => {
await ctx.proxy.write('1\r\n2\r\n3\r\n4\r\n5');
await pollFor(ctx.page, () => getLinesAsArray(5), ['1', '2', '3', '4', '5']);
await ctx.proxy.write('\x1b[^');
@@ -271,8 +268,6 @@ test.describe('InputHandler Integration Tests', () => {
await pollFor(ctx.page, () => getLinesAsArray(5), ['', '', '1', '2', '3']);
});
test('CSI Ps ` - HPA: Character Position Absolute [column] (default = [row,1])', async () => {
// Ensure terminal is wide enough (other tests may resize)
await ctx.proxy.resize(80, 24);
// Default
await ctx.proxy.write('foo\x1b[`a');
// Explicit