waveterm/xterm.js
0
0
Fork 0
mirror of https://github.com/wavetermdev/xterm.js.git synced 2026-08-05 13:43:48 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix force transparent foreground colors to be opaque

Browse Source
This commit is contained in:
dennnnny
2023-08-13 17:52:49 +08:00
parent fb7349bc87
commit bef87403db
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/browser/renderer/shared/TextureAtlas.ts
+1 -1
View File
@@ -277,7 +277,7 @@ export class TextureAtlas implements ITextureAtlas {
}
private _getBackgroundColor(bgColorMode: number, bgColor: number, inverse: boolean, dim: boolean): IColor {
if (this._config.allowTransparency || (inverse && !color.isOpaque(this._config.colors.foreground))) {
if (this._config.allowTransparency) {
// The background color might have some transparency, so we need to render it as fully
// transparent in the atlas. Otherwise we'd end up drawing the transparent background twice
// around the anti-aliased edges of the glyph, and it would look too dark.
src/browser/services/ThemeService.ts
+2 -1
View File
@@ -122,7 +122,8 @@ export class ThemeService extends Disposable implements IThemeService {
*/
private _setTheme(theme: ITheme = {}): void {
const colors = this._colors;
colors.foreground = parseColor(theme.foreground, DEFAULT_FOREGROUND);
colors.foreground = color.opaque(parseColor(theme.foreground, DEFAULT_FOREGROUND));
console.warn("xterm.js is not fully support foreground colors with transparent, so it will the foreground colors alpha channel to 255.")
colors.background = parseColor(theme.background, DEFAULT_BACKGROUND);
colors.cursor = parseColor(theme.cursor, DEFAULT_CURSOR);
colors.cursorAccent = parseColor(theme.cursorAccent, DEFAULT_CURSOR_ACCENT);